Re: [HACKERS] pgsql crollable cursor doesn't support one form ofpostgresql's cu

2007-04-28 Thread Neil Conway 
On Fri, 2007-04-27 at 07:36 +0200, Pavel Stehule wrote:
 it's true. There is bug. I'll send actualised version tomorrow.

No need: I fixed the bug and applied the patch. Thanks for the patch.

-Neil



---(end of broadcast)---
TIP 6: explain analyze is your friend

Re: [HACKERS] pgsql crollable cursor doesn't support one form ofpostgresql's cu

2007-04-26 Thread Pavel Stehule 

Hello,

it's true. There is bug. I'll send actualised version tomorrow.

Regards
Pavel


I haven't read the rest of the thread yet, but is this hunk not buggy?
yylex() is side-effecting, so the two calls to yylex() do not do what
the comment suggests.


 ! /* check FROM or IN keyword after direction's specification */
 ! if (check_FROM  (yylex() != K_FROM  yylex() != K_IN))
 ! yyerror(expected \FROM/IN\);

   return fetch;

-Neil




_
Emotikony a pozadi programu MSN Messenger ozivi vasi konverzaci. 
http://messenger.msn.cz/



---(end of broadcast)---
TIP 6: explain analyze is your friend