Re: [PATCHES] [HACKERS] External Sort timing debug statements

2005-10-03 Thread Dave Page
 

 -Original Message-
 From: [EMAIL PROTECTED] 
 [mailto:[EMAIL PROTECTED] On Behalf Of Tom Lane
 Sent: 03 October 2005 15:37
 To: Simon Riggs
 Cc: pgsql-hackers@postgresql.org; pgsql-patches@postgresql.org
 Subject: Re: [PATCHES] [HACKERS] External Sort timing debug 
 statements 
 
 Simon Riggs [EMAIL PROTECTED] writes:
  The following patch implements a fairly light set of timing 
 statements
  aimed at understanding external sort performance. There is 
 no attempt to
  alter the algorithms.
 
 What do people think about putting something like this into 8.1?
 Strictly speaking it's a new feature, but the patch seems pretty
 noninvasive, and we'd be much more likely to get data points if the
 code exists in the mainline release than if people have to patch
 their copies.

Agreed.

  postgres=# set debug_sort=true;
 
 I'm a bit inclined to call it trace_sort instead, and to document it
 under Developer Options.  Comments?

Sounds reasonable to me.

Regards, Dave.

---(end of broadcast)---
TIP 9: In versions below 8.0, the planner will ignore your desire to
   choose an index scan if your joining column's datatypes do not
   match


Re: [PATCHES] [HACKERS] External Sort timing debug statements

2005-10-03 Thread David Fetter
On Mon, Oct 03, 2005 at 10:36:57AM -0400, Tom Lane wrote:
 Simon Riggs [EMAIL PROTECTED] writes:
  The following patch implements a fairly light set of timing
  statements aimed at understanding external sort performance. There
  is no attempt to alter the algorithms.
 
 What do people think about putting something like this into 8.1?
 Strictly speaking it's a new feature, but the patch seems pretty
 noninvasive, and we'd be much more likely to get data points if the
 code exists in the mainline release than if people have to patch
 their copies.

This would be good :)

  postgres=# set debug_sort=true;
 
 I'm a bit inclined to call it trace_sort instead, and to document it
 under Developer Options.  Comments?

+1

Cheers,
D
-- 
David Fetter [EMAIL PROTECTED] http://fetter.org/
phone: +1 510 893 6100   mobile: +1 415 235 3778

Remember to vote!

---(end of broadcast)---
TIP 6: explain analyze is your friend