Re: [PATCHES] [HACKERS] to_char and i18n

2006-03-02 Thread Bruce Momjian

Added to TODO:

* Allow to_date() and to_timestamp() accept localized month names

Comment added to the C code to show where it has to happen.

---

Karel Zak wrote:
 On Sun, 2005-12-25 at 17:56 -0300, Euler Taveira de Oliveira wrote:
  --- Euler Taveira de Oliveira [EMAIL PROTECTED] escreveu:
  
   I have a patch like this. But this was for 7.4.x. I have to take a
   look
   at it.
  
  The patch is attached. It implements day and month i18n. I fixed a few
  misspelling comments. Docs is attached too.
  
  template1=# select to_char(now(), 'Day, DD Month ');
 to_char
  --
   Sunday   , 25 December  2005
  (1 registro)
  
  template1=# select to_char(now(), 'TMDay, DD TMMonth ');
to_char  
  ---
   Domingo, 25 Dezembro 2005
  (1 registro)
  
  template1=# 
  
  
  Comments?
 
 I think it looks like a good patch. There's small problem that the
 current to_char() output is possible use as argument for to_timestamp()
 or to_date() function. It means you should implement vice-versa
 conversion from string with TMMonth/TMDay to timestamp.
 
to_timestamp('Domingo, 25 Dezembro 2005', 'TMDay, DD TMMonth ')
 
 Or.. at least describe in the docs that this way is unsupported
 for 'TM' prefix.
 
   Karel
 
 -- 
 Karel Zak [EMAIL PROTECTED]
 
 
 ---(end of broadcast)---
 TIP 2: Don't 'kill -9' the postmaster
 

-- 
  Bruce Momjian   http://candle.pha.pa.us
  SRA OSS, Inc.   http://www.sraoss.com

  + If your life is a hard drive, Christ can be your backup. +

---(end of broadcast)---
TIP 9: In versions below 8.0, the planner will ignore your desire to
   choose an index scan if your joining column's datatypes do not
   match


Re: [PATCHES] [HACKERS] to_char and i18n

2005-12-26 Thread Karel Zak
On Sun, 2005-12-25 at 17:56 -0300, Euler Taveira de Oliveira wrote:
 --- Euler Taveira de Oliveira [EMAIL PROTECTED] escreveu:
 
  I have a patch like this. But this was for 7.4.x. I have to take a
  look
  at it.
 
 The patch is attached. It implements day and month i18n. I fixed a few
 misspelling comments. Docs is attached too.
 
 template1=# select to_char(now(), 'Day, DD Month ');
to_char
 --
  Sunday   , 25 December  2005
 (1 registro)
 
 template1=# select to_char(now(), 'TMDay, DD TMMonth ');
   to_char  
 ---
  Domingo, 25 Dezembro 2005
 (1 registro)
 
 template1=# 
 
 
 Comments?

I think it looks like a good patch. There's small problem that the
current to_char() output is possible use as argument for to_timestamp()
or to_date() function. It means you should implement vice-versa
conversion from string with TMMonth/TMDay to timestamp.

   to_timestamp('Domingo, 25 Dezembro 2005', 'TMDay, DD TMMonth ')

Or.. at least describe in the docs that this way is unsupported
for 'TM' prefix.

Karel

-- 
Karel Zak [EMAIL PROTECTED]


---(end of broadcast)---
TIP 2: Don't 'kill -9' the postmaster