.psqlrc version dependence (was Re: [HACKERS] about EDITOR_LINENUMBER_SWITCH)

2011-10-15 Thread Tom Lane
Peter Eisentraut pete...@gmx.net writes:
 Contrary to what the subject suggests, I think the main reason people
 wanted this feature was to be able to set the linestyle to unicode
 without getting a warning from older releases about unknown linestyle or
 something.  But in a few years, they'll have to
 maintain .psqlrc-9.2, .psqlrc-9.3, .psqlrc-9.4, etc.  That doesn't sound
 like a useful long-term solution either.

Well, in a few years they won't need that conditionality any more at
all, so I'm not sure I believe the above argument.  The problem seems
inherently self-limiting.

What struck me while looking at the patch is that it is conditional
based on *psql's* version.  Not the version of the server you're
connected to.  I'm not too sure what use-cases people have for version
dependence here, but I'd think that the server version would enter into
it sometimes.

(Of course, for server version to be used usefully, you'd need to
re-execute the rc file during \c, something we don't do now.)

regards, tom lane

-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers


Re: .psqlrc version dependence (was Re: [HACKERS] about EDITOR_LINENUMBER_SWITCH)

2011-10-15 Thread Bruce Momjian
Tom Lane wrote:
 Peter Eisentraut pete...@gmx.net writes:
  Contrary to what the subject suggests, I think the main reason people
  wanted this feature was to be able to set the linestyle to unicode
  without getting a warning from older releases about unknown linestyle or
  something.  But in a few years, they'll have to
  maintain .psqlrc-9.2, .psqlrc-9.3, .psqlrc-9.4, etc.  That doesn't sound
  like a useful long-term solution either.
 
 Well, in a few years they won't need that conditionality any more at
 all, so I'm not sure I believe the above argument.  The problem seems
 inherently self-limiting.
 
 What struck me while looking at the patch is that it is conditional
 based on *psql's* version.  Not the version of the server you're
 connected to.  I'm not too sure what use-cases people have for version
 dependence here, but I'd think that the server version would enter into
 it sometimes.

The assumption is that the .psqlrc is controlling psql behavior.  Not
sure what setting would be changed based on server version, maybe psql
variables. 

I have updated the docs to indicate it is the psql version.

 (Of course, for server version to be used usefully, you'd need to
 re-execute the rc file during \c, something we don't do now.)

Yep, yuck.

-- 
  Bruce Momjian  br...@momjian.ushttp://momjian.us
  EnterpriseDB http://enterprisedb.com

  + It's impossible for everything to be true. +

-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers