Re: [HACKERS] Last call for back-branch fixes

[Bruce Momjian]

This has been saved for the 8.2 release:

http://momjian.postgresql.org/cgi-bin/pgpatches_hold

---


Greg Sabino Mullane wrote:
[ There is text before PGP section. ]
> 
> -BEGIN PGP SIGNED MESSAGE-
> Hash: SHA1
> 
> 
> > ! (void) sprintf((char *) rp, "%03o", *vp);
> > ! (void) snprintf((char *) rp, 6, "%03o", *vp);
>   
> > Hardly looks like a critical fix, or even a needed one.  Why bother?
> 
> No, not critical. Just something that tripped me up a few months ago when
> writing some code based on this section, and I finally remembered it when
> I saw your email. It's more of a nice to have, as the surrounding code
> should prevent the %03o from making more than 3 characters.
> 
> - --
> Greg Sabino Mullane [EMAIL PROTECTED]
> PGP Key: 0x14964AC8 200510032127
> http://biglumber.com/x/web?pk=2529DF6AB8F79407E94445B4BC9B906714964AC8
> -BEGIN PGP SIGNATURE-
> 
> iD8DBQFDQdq9vJuQZxSWSsgRAgeRAKCujcqJFtPf+LSlQ17BBCbGmfelmACgr30s
> 5OFfHfL3evrwV/FQI/XRMJI=
> =ZTcO
> -END PGP SIGNATURE-
> 
> 
> 
> ---(end of broadcast)---
> TIP 3: Have you checked our extensive FAQ?
> 
>http://www.postgresql.org/docs/faq
> 

-- 
  Bruce Momjian|  http://candle.pha.pa.us
  pgman@candle.pha.pa.us   |  (610) 359-1001
  +  If your life is a hard drive, |  13 Roberts Road
  +  Christ can be your backup.|  Newtown Square, Pennsylvania 19073

---(end of broadcast)---
TIP 9: In versions below 8.0, the planner will ignore your desire to
   choose an index scan if your joining column's datatypes do not
   match

Re: [HACKERS] Last call for back-branch fixes

[Greg Sabino Mullane]

-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1


> ! (void) sprintf((char *) rp, "%03o", *vp);
> ! (void) snprintf((char *) rp, 6, "%03o", *vp);
  
> Hardly looks like a critical fix, or even a needed one.  Why bother?

No, not critical. Just something that tripped me up a few months ago when
writing some code based on this section, and I finally remembered it when
I saw your email. It's more of a nice to have, as the surrounding code
should prevent the %03o from making more than 3 characters.

- --
Greg Sabino Mullane [EMAIL PROTECTED]
PGP Key: 0x14964AC8 200510032127
http://biglumber.com/x/web?pk=2529DF6AB8F79407E94445B4BC9B906714964AC8
-BEGIN PGP SIGNATURE-

iD8DBQFDQdq9vJuQZxSWSsgRAgeRAKCujcqJFtPf+LSlQ17BBCbGmfelmACgr30s
5OFfHfL3evrwV/FQI/XRMJI=
=ZTcO
-END PGP SIGNATURE-



---(end of broadcast)---
TIP 3: Have you checked our extensive FAQ?

   http://www.postgresql.org/docs/faq

Re: [HACKERS] Last call for back-branch fixes

[Tom Lane]

"Greg Sabino Mullane" <[EMAIL PROTECTED]> writes:
> ! (void) sprintf((char *) rp, "%03o", *vp);

> ! (void) snprintf((char *) rp, 6, "%03o", *vp);

Hardly looks like a critical fix, or even a needed one.  Why bother?

regards, tom lane

---(end of broadcast)---
TIP 3: Have you checked our extensive FAQ?

   http://www.postgresql.org/docs/faq

Re: [HACKERS] Last call for back-branch fixes

[Greg Sabino Mullane]

Index: fe-exec.c
===
RCS file: /projects/cvsroot/pgsql/src/interfaces/libpq/fe-exec.c,v
retrieving revision 1.175
diff -c -r1.175 fe-exec.c
*** fe-exec.c   24 Sep 2005 17:53:28 -  1.175
--- fe-exec.c   3 Oct 2005 12:49:08 -
***
*** 2429,2435 
{
if (*vp < 0x20 || *vp > 0x7e)
{
!   (void) sprintf((char *) rp, "%03o", *vp);
rp += 5;
}
else if (*vp == '\'')
--- 2429,2435 
{
if (*vp < 0x20 || *vp > 0x7e)
{
!   (void) snprintf((char *) rp, 6, "%03o", *vp);
rp += 5;
}
else if (*vp == '\'')



---(end of broadcast)---
TIP 3: Have you checked our extensive FAQ?

   http://www.postgresql.org/docs/faq