Re: [HACKERS] patch (for 9.1) string functions ( correct patch attached )

2011-02-17 Thread Bruce Momjian
Erik Rijkers wrote:
> On Thu, July 29, 2010 22:43, Erik Rijkers wrote:
> > Hi Pavel,
> >
> > In xfunc.sgml, I came across a function example (for use of VARIADIC in 
> > polymorphic functions),
> > where the function name is concat():  (in the manual: 35.4.10. Polymorphic 
> > SQL Functions).
> > Although that is not strictly wrong, it seems better to change that name 
> > when concat goes into
> > core, as seems to be the plan.
> >
> > If you agree, it seems best to include this change in your patch and change 
> > that example
> > function's name when the stringfunc patch gets applied.
> >
> 
> My apologies, the previous email had the wrong doc-patch attached.
> 
> Here is the correct one.

Applied for 9.1.  Thanks.

-- 
  Bruce Momjian  http://momjian.us
  EnterpriseDB http://enterprisedb.com

  + It's impossible for everything to be true. +

-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers


Re: [HACKERS] patch (for 9.1) string functions ( correct patch attached )

2010-07-30 Thread Pavel Stehule
Hello

2010/7/29 Erik Rijkers :
> On Thu, July 29, 2010 22:43, Erik Rijkers wrote:
>> Hi Pavel,
>>
>> In xfunc.sgml, I came across a function example (for use of VARIADIC in 
>> polymorphic functions),
>> where the function name is concat():  (in the manual: 35.4.10. Polymorphic 
>> SQL Functions).
>> Although that is not strictly wrong, it seems better to change that name 
>> when concat goes into
>> core, as seems to be the plan.
>>
>> If you agree, it seems best to include this change in your patch and change 
>> that example
>> function's name when the stringfunc patch gets applied.
>>
>
> My apologies, the previous email had the wrong doc-patch attached.
>
> Here is the correct one.
>

it is good idea, thank you

Pavel

>
> Erik Rijkers
>

-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers


Re: [HACKERS] patch (for 9.1) string functions ( correct patch attached )

2010-07-29 Thread Erik Rijkers
On Thu, July 29, 2010 22:43, Erik Rijkers wrote:
> Hi Pavel,
>
> In xfunc.sgml, I came across a function example (for use of VARIADIC in 
> polymorphic functions),
> where the function name is concat():  (in the manual: 35.4.10. Polymorphic 
> SQL Functions).
> Although that is not strictly wrong, it seems better to change that name when 
> concat goes into
> core, as seems to be the plan.
>
> If you agree, it seems best to include this change in your patch and change 
> that example
> function's name when the stringfunc patch gets applied.
>

My apologies, the previous email had the wrong doc-patch attached.

Here is the correct one.


Erik Rijkers


xfunc.sgml.diff
Description: Binary data

-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers