Re: [HACKERS] pg_dump COMMENT ON DATABASE sometimes inappropriate

2005-09-21 Thread Robert Treat
On Wednesday 21 September 2005 01:10, Michael Fuhr wrote:
 pg_dump emits COMMENT ON DATABASE (if the database has a comment)
 even when dumping only an individual schema or table.  That seems
 inappropriate, especially when copying data to a different cluster
 where the named database might not exist or might have a different
 comment that shouldn't be overwritten.  Does anybody else think
 pg_dump shouldn't emit COMMENT ON DATABASE in these cases?

+1

-- 
Robert Treat
Build A Brighter Lamp :: Linux Apache {middleware} PostgreSQL

---(end of broadcast)---
TIP 1: if posting/reading through Usenet, please send an appropriate
   subscribe-nomail command to [EMAIL PROTECTED] so that your
   message can get through to the mailing list cleanly


Re: [HACKERS] pg_dump COMMENT ON DATABASE sometimes inappropriate

2005-09-21 Thread Tom Lane
Michael Fuhr [EMAIL PROTECTED] writes:
 pg_dump emits COMMENT ON DATABASE (if the database has a comment)
 even when dumping only an individual schema or table.  That seems
 inappropriate,

Agreed, this seems like a bug.  Fix applied.

regards, tom lane

---(end of broadcast)---
TIP 6: explain analyze is your friend