Re: [HACKERS] pg_tablespace.spclocation column removed in 9.2

2012-06-25 Thread Guillaume Lelarge
Hi Pavel,

On Mon, 2012-06-25 at 08:26 +0300, Pavel Golub wrote:
 Hello, Pgsql-bugs.
 
 According to the Moving tablespaces thread started by Bruce
 http://archives.postgresql.org/pgsql-docs/2011-12/msg3.php
 pg_tablespace.spclocation column is removed in the 9.2beta. However
 this breaks backward compatibility for a bunch of products, e.g.
 pgAdmin, phpPgAdmin, PgMDD etc.
 
 I'm not sure this is the best choice. Because each application with
 tablespace support will need additional check now to determine what
 way to use for obtaining tablespace location:
 pg_get_tablespace_location(oid) or tablespace.spclocation
 
 I'm aware of problems caused by this hard coded column. My proposal is
 to convert pg_tablespace to system view may be?
 

I don't see why it causes you so much trouble. You should already have
many locations in your code where you need to check the version to be
compatible with the latest major releases. I know pgAdmin does. So I
guess that one more is not a big deal.

And this change in PostgreSQL helps a lot DBAs who want to move
tablespaces (not really common work AFAIK, I agree).


-- 
Guillaume
http://blog.guillaume.lelarge.info
http://www.dalibo.com


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers


Re: [HACKERS] pg_tablespace.spclocation column removed in 9.2

2012-06-25 Thread Pavel Golub
Hello, Guillaume.

You wrote:

GL Hi Pavel,

GL On Mon, 2012-06-25 at 08:26 +0300, Pavel Golub wrote:
 Hello, Pgsql-bugs.
 
 According to the Moving tablespaces thread started by Bruce
 http://archives.postgresql.org/pgsql-docs/2011-12/msg3.php
 pg_tablespace.spclocation column is removed in the 9.2beta. However
 this breaks backward compatibility for a bunch of products, e.g.
 pgAdmin, phpPgAdmin, PgMDD etc.
 
 I'm not sure this is the best choice. Because each application with
 tablespace support will need additional check now to determine what
 way to use for obtaining tablespace location:
 pg_get_tablespace_location(oid) or tablespace.spclocation
 
 I'm aware of problems caused by this hard coded column. My proposal is
 to convert pg_tablespace to system view may be?
 

GL I don't see why it causes you so much trouble.

Not so much. However.

GL You should already have
GL many locations in your code where you need to check the version to be
GL compatible with the latest major releases.

This is holy true.

GL I know pgAdmin does. So I
GL guess that one more is not a big deal.

GL And this change in PostgreSQL helps a lot DBAs who want to move
GL tablespaces (not really common work AFAIK, I agree).

I know. I just followed the advice of Josh Berkus and added this as a
bug.

-- 
With best wishes,
 Pavel  mailto:pa...@gf.microolap.com


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers