Re: [HACKERS] pidfile location missing after restarting crashed server in 8.1

2005-10-26 Thread Tom Lane 
Robert Treat [EMAIL PROTECTED] writes:
 the difference being that in 8.0 we printed the full path of the pid file, in
 8.1 we do not.  there could be a good reason for this,

Yeah: it's now being accessed by a relative path (relative to $PGDATA,
which we have already chdir'd into at this point).

regards, tom lane

---(end of broadcast)---
TIP 5: don't forget to increase your free space map settings

Re: [HACKERS] pidfile location missing after restarting crashed server in 8.1

2005-10-26 Thread Alvaro Herrera 
Tom Lane wrote:
 Robert Treat [EMAIL PROTECTED] writes:
  the difference being that in 8.0 we printed the full path of the pid file, 
  in
  8.1 we do not.  there could be a good reason for this,
 
 Yeah: it's now being accessed by a relative path (relative to $PGDATA,
 which we have already chdir'd into at this point).

So we should include PGDATA in the error message (DataDir actually, I
guess).

-- 
Alvaro Herrera Architect, http://www.EnterpriseDB.com
When the proper man does nothing (wu-wei),
his thought is felt ten thousand miles. (Lao Tse)

---(end of broadcast)---
TIP 6: explain analyze is your friend

Re: [HACKERS] pidfile location missing after restarting crashed server in 8.1

2005-10-26 Thread Tom Lane 
Alvaro Herrera [EMAIL PROTECTED] writes:
 Tom Lane wrote:
 Yeah: it's now being accessed by a relative path (relative to $PGDATA,
 which we have already chdir'd into at this point).

 So we should include PGDATA in the error message (DataDir actually, I
 guess).

I don't think that follows.  The code prints exactly the path name it's
using to access the file, and I think that's exactly what it should
print.  Are we going to editorialize similarly on every other message
that includes a file name?

regards, tom lane

---(end of broadcast)---
TIP 1: if posting/reading through Usenet, please send an appropriate
   subscribe-nomail command to [EMAIL PROTECTED] so that your
   message can get through to the mailing list cleanly

Re: [HACKERS] pidfile location missing after restarting crashed server in 8.1

2005-10-26 Thread Robert Treat 
On Wednesday 26 October 2005 14:59, Tom Lane wrote:
 Robert Treat [EMAIL PROTECTED] writes:
  the difference being that in 8.0 we printed the full path of the pid
  file, in 8.1 we do not.  there could be a good reason for this,

 Yeah: it's now being accessed by a relative path (relative to $PGDATA,
 which we have already chdir'd into at this point).


I thought about this, but it didn't seem to me this would actually prevent us 
from explicitly stating the full path to the pid file, just make an extra 
hoop we would have to go to.  ISTM the helpfulness of the information and the 
fact that we are in a fatal startup mode would make it worth it. 

-- 
Robert Treat
Build A Brighter Lamp :: Linux Apache {middleware} PostgreSQL

---(end of broadcast)---
TIP 6: explain analyze is your friend

Re: [HACKERS] pidfile location missing after restarting crashed server in 8.1

2005-10-26 Thread Alvaro Herrera 
Tom Lane wrote:
 Alvaro Herrera [EMAIL PROTECTED] writes:
  Tom Lane wrote:
  Yeah: it's now being accessed by a relative path (relative to $PGDATA,
  which we have already chdir'd into at this point).
 
  So we should include PGDATA in the error message (DataDir actually, I
  guess).
 
 I don't think that follows.  The code prints exactly the path name it's
 using to access the file, and I think that's exactly what it should
 print.

It's not useful for the user that way.  Besides, we know what we did
chdir() to, so we could present that information to the user.

-- 
Alvaro Herrera
Amanece.   (Ignacio Reyes)
 El Cerro San Cristóbal me mira, cínicamente, con ojos de virgen

---(end of broadcast)---
TIP 1: if posting/reading through Usenet, please send an appropriate
   subscribe-nomail command to [EMAIL PROTECTED] so that your
   message can get through to the mailing list cleanly