Re: [HACKERS] pl/pgsql exported functions

2016-03-03 Thread Magnus Hagander 
On Wed, Mar 2, 2016 at 5:07 PM, Marko Tiikkaja  wrote:

> On 11/02/16 18:29, Magnus Hagander wrote:
>
>> Most of the pl/pgsql functions and variables are prefixed plpgsql_, so
>> they
>> don't risk conflicting with other shared libraries loaded.
>>
>> There are a couple that are not prefixed. Attached patch fixes that. It's
>> mostly a cleanup, but I think it's something we should do since it's only
>> 2
>> variables and 2 functions.
>>
>> AFAICT these are clearly meant to be internal. (the plugin variable is
>> accessed through find_rendezvous_variable)
>>
>> Comments?
>>
>
> Looks good to me.
>
>
Thanks, pushed.


-- 
 Magnus Hagander
 Me: http://www.hagander.net/
 Work: http://www.redpill-linpro.com/

Re: [HACKERS] pl/pgsql exported functions

2016-03-02 Thread Marko Tiikkaja 

On 11/02/16 18:29, Magnus Hagander wrote:

Most of the pl/pgsql functions and variables are prefixed plpgsql_, so they
don't risk conflicting with other shared libraries loaded.

There are a couple that are not prefixed. Attached patch fixes that. It's
mostly a cleanup, but I think it's something we should do since it's only 2
variables and 2 functions.

AFAICT these are clearly meant to be internal. (the plugin variable is
accessed through find_rendezvous_variable)

Comments?


Looks good to me.


.m


--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] pl/pgsql exported functions

2016-02-11 Thread Pavel Stehule 
2016-02-11 18:29 GMT+01:00 Magnus Hagander :

> Most of the pl/pgsql functions and variables are prefixed plpgsql_, so
> they don't risk conflicting with other shared libraries loaded.
>
> There are a couple that are not prefixed. Attached patch fixes that. It's
> mostly a cleanup, but I think it's something we should do since it's only 2
> variables and 2 functions.
>
> AFAICT these are clearly meant to be internal. (the plugin variable is
> accessed through find_rendezvous_variable)
>

+1

Pavel


>
> Comments?
>
> --
>  Magnus Hagander
>  Me: http://www.hagander.net/
>  Work: http://www.redpill-linpro.com/
>
>
> --
> Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgsql-hackers
>
>