Re: [HACKERS] psql document fix about showing FDW options
2011/8/11 Shigeru Hanada : > Yeah, I have (hopefully) working FDW for PostgreSQL which is based on > the one which has been proposed for 9.1, and updates done by Heikki. > I've implemented: > > * SELECT clause omitting > * WHERE clause pushdown (assuming remote has same functions/oprators) > * private connection caching, and VIEW which shows active connections > * switch simple SELECT and CURSOR based on estimated # of rows, > and FDW options to control this behavior > > I'd like to submit this fdw in CF 2011-09 (ASAP) for discussion of > itself and FDW API enhancement. Please see the wiki page below for details. Great stuff. Look forward to seeing the patch(es). -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
Re: [HACKERS] psql document fix about showing FDW options
(2011/08/12 0:48), Robert Haas wrote:
> 2011/8/9 Shigeru Hanada:
>> postgres=# \d pgbench_accounts
>>Foreign table "public.pgbench_accounts"
>> Column | Type | Modifiers |Options
>> --+---+---+---
>> aid | integer | not null | {colname=aid}
>> bid | integer | |
>> abalance | integer | |
>> filler | character(84) | |
>> Server: pgbench
>> Options: {nspname=public,"relname=foo bar"}
>
> Looks like you've got postgresql_fdw working there... do you plan to
> submit that for 9.2 soon? Any plans for qual pushdown?
Yeah, I have (hopefully) working FDW for PostgreSQL which is based on
the one which has been proposed for 9.1, and updates done by Heikki.
I've implemented:
* SELECT clause omitting
* WHERE clause pushdown (assuming remote has same functions/oprators)
* private connection caching, and VIEW which shows active connections
* switch simple SELECT and CURSOR based on estimated # of rows,
and FDW options to control this behavior
I'd like to submit this fdw in CF 2011-09 (ASAP) for discussion of
itself and FDW API enhancement. Please see the wiki page below for details.
http://wiki.postgresql.org/wiki/SQL/MED#PostgreSQL
>> I attached WIP patch for these fixes.
>> Please apply show_per_table_options.patch first against head, and then
>> rename_desc_headers.patch can be applied.
>
> Looks good to me. Committed.
Thanks!
Regards,
--
Shigeru Hanada
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
Re: [HACKERS] psql document fix about showing FDW options
2011/8/9 Shigeru Hanada :
> postgres=# \d pgbench_accounts
> Foreign table "public.pgbench_accounts"
> Column | Type | Modifiers | Options
> --+---+---+---
> aid | integer | not null | {colname=aid}
> bid | integer | |
> abalance | integer | |
> filler | character(84) | |
> Server: pgbench
> Options: {nspname=public,"relname=foo bar"}
Looks like you've got postgresql_fdw working there... do you plan to
submit that for 9.2 soon? Any plans for qual pushdown?
> I attached WIP patch for these fixes.
> Please apply show_per_table_options.patch first against head, and then
> rename_desc_headers.patch can be applied.
Looks good to me. Committed.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
Re: [HACKERS] psql document fix about showing FDW options
2011/8/8 Shigeru Hanada : > I noticed that psql document wrongly says that \d+ command shows > per-table FDW options of a foreign table, but in fact, per-table FDW > options are shown only in the result of \det+ command. Attached patch > removes this wrong description. > > This fix should be applied to 9.1 too. I think we ought to fix the behavior, rather than the documentation. It's just weird to have something show up in the list view that doesn't appear in the detail view. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
