Re: [HACKERS] spgist metapage

2012-05-23 Thread Tom Lane
Robert Haas robertmh...@gmail.com writes:
 Since we haven't actually released spgist yet, I'm wondering if it
 should be revised to look more like btree and hash - that is, add a
 32-bit version number immediately following the magic number.  All
 experience hath shown that it is often much more work to add such
 things later.

With the beta already out, I think we have released it, for some
admittedly-small value of released.  I think it's too late to make
non-pg_upgrade-able changes on mere speculation that they might be a
good idea.

In any case, I would've expected we'd end up changing all these page
formats if we go over to your concept of a metapage for everything.
Fixing indexes that already have some kind of metapage will surely be
trivial compared to fixing heaps.

regards, tom lane

-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers


Re: [HACKERS] spgist metapage

2012-05-23 Thread Robert Haas
On Wed, May 23, 2012 at 2:05 PM, Tom Lane t...@sss.pgh.pa.us wrote:
 Robert Haas robertmh...@gmail.com writes:
 Since we haven't actually released spgist yet, I'm wondering if it
 should be revised to look more like btree and hash - that is, add a
 32-bit version number immediately following the magic number.  All
 experience hath shown that it is often much more work to add such
 things later.

 With the beta already out, I think we have released it, for some
 admittedly-small value of released.  I think it's too late to make
 non-pg_upgrade-able changes on mere speculation that they might be a
 good idea.

 In any case, I would've expected we'd end up changing all these page
 formats if we go over to your concept of a metapage for everything.
 Fixing indexes that already have some kind of metapage will surely be
 trivial compared to fixing heaps.

I thought you might say that, but I thought I'd ask just in case.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers