Re: 7.2.3 fixes (was Re: [HACKERS] Cause of missing pg_clog files)
Tom Lane wrote: > One thing I am undecided about: I am more than half tempted to put in > the fix that makes us able to cope with mktime's broken-before-1970 > behavior in recent glibc versions (e.g., Red Hat 7.3). This seems like > a good idea considering that other Linux distros will surely be updating > glibc soon too. On the other hand, it's hard to call it a critical bug > fix --- it ain't on a par with the vacuum/clog problem, for sure. And > the patch has received only limited testing (basically just whatever > use 7.3beta1 has had). On the third hand, the patch only does something > if mktime() has already failed, so it's hard to see how it could make > life worse even if it's buggy. > > Any votes on whether to fix that or leave it alone in 7.2.3? I need > some input in the next few hours ... > +1 for fixing it Joe ---(end of broadcast)--- TIP 5: Have you checked our extensive FAQ? http://www.postgresql.org/users-lounge/docs/faq.html
Re: 7.2.3 fixes (was Re: [HACKERS] Cause of missing pg_clog files)
Tom Lane wrote: > Any votes on whether to fix that or leave it alone in 7.2.3? I need > some input in the next few hours ... Including it sounds like a good idea. 'Yes' from me. :) Regards and best wishes, Justin Clift > regards, tom lane > > ---(end of broadcast)--- > TIP 4: Don't 'kill -9' the postmaster -- "My grandfather once told me that there are two kinds of people: those who work and those who take the credit. He told me to try to be in the first group; there was less competition there." - Indira Gandhi ---(end of broadcast)--- TIP 1: subscribe and unsubscribe commands go to [EMAIL PROTECTED]
Re: 7.2.3 fixes (was Re: [HACKERS] Cause of missing pg_clog files)
Tom Lane wrote: > Andrew Sullivan <[EMAIL PROTECTED]> writes: > > On Fri, Sep 27, 2002 at 08:30:38PM -0400, Bruce Momjian wrote: > >> OK, we need a decision on whether we are going to do a 7.2,3 or just > >> have it in beta3. If it is in 7.2.3, I would not mention it in the > >> beta3 release notes. > > > If there won't be any 7.2.3, > > There will be; I will backport the fixes today, and Marc promised to > roll the tarball tonight. > > One thing I am undecided about: I am more than half tempted to put in > the fix that makes us able to cope with mktime's broken-before-1970 > behavior in recent glibc versions (e.g., Red Hat 7.3). This seems like > a good idea considering that other Linux distros will surely be updating > glibc soon too. On the other hand, it's hard to call it a critical bug > fix --- it ain't on a par with the vacuum/clog problem, for sure. And > the patch has received only limited testing (basically just whatever > use 7.3beta1 has had). On the third hand, the patch only does something > if mktime() has already failed, so it's hard to see how it could make > life worse even if it's buggy. > > Any votes on whether to fix that or leave it alone in 7.2.3? I need > some input in the next few hours ... I think it should be put in. You work for Red Hat, and that's the least we can do for them. -- Bruce Momjian| http://candle.pha.pa.us [EMAIL PROTECTED] | (610) 359-1001 + If your life is a hard drive, | 13 Roberts Road + Christ can be your backup.| Newtown Square, Pennsylvania 19073 ---(end of broadcast)--- TIP 3: if posting/reading through Usenet, please send an appropriate subscribe-nomail command to [EMAIL PROTECTED] so that your message can get through to the mailing list cleanly
Re: 7.2.3 fixes (was Re: [HACKERS] Cause of missing pg_clog files)
Nothing against including it from me ... On Mon, 30 Sep 2002, Tom Lane wrote: > Andrew Sullivan <[EMAIL PROTECTED]> writes: > > On Fri, Sep 27, 2002 at 08:30:38PM -0400, Bruce Momjian wrote: > >> OK, we need a decision on whether we are going to do a 7.2,3 or just > >> have it in beta3. If it is in 7.2.3, I would not mention it in the > >> beta3 release notes. > > > If there won't be any 7.2.3, > > There will be; I will backport the fixes today, and Marc promised to > roll the tarball tonight. > > One thing I am undecided about: I am more than half tempted to put in > the fix that makes us able to cope with mktime's broken-before-1970 > behavior in recent glibc versions (e.g., Red Hat 7.3). This seems like > a good idea considering that other Linux distros will surely be updating > glibc soon too. On the other hand, it's hard to call it a critical bug > fix --- it ain't on a par with the vacuum/clog problem, for sure. And > the patch has received only limited testing (basically just whatever > use 7.3beta1 has had). On the third hand, the patch only does something > if mktime() has already failed, so it's hard to see how it could make > life worse even if it's buggy. > > Any votes on whether to fix that or leave it alone in 7.2.3? I need > some input in the next few hours ... > > regards, tom lane > > ---(end of broadcast)--- > TIP 4: Don't 'kill -9' the postmaster > ---(end of broadcast)--- TIP 3: if posting/reading through Usenet, please send an appropriate subscribe-nomail command to [EMAIL PROTECTED] so that your message can get through to the mailing list cleanly
Re: 7.2.3 fixes (was Re: [HACKERS] Cause of missing pg_clog files)
On Mon, Sep 30, 2002 at 11:18:27AM -0400, Tom Lane wrote: > use 7.3beta1 has had). On the third hand, the patch only does something > if mktime() has already failed, so it's hard to see how it could make > life worse even if it's buggy. On those grounds alone, it seems worth putting in. As you say, it's hard to see how it can be worse than not putting it in, even if it turns out to be buggy. It's probably worth noting prominently in the release notes that it has received minimal testing, though. A -- Andrew Sullivan 204-4141 Yonge Street Liberty RMS Toronto, Ontario Canada <[EMAIL PROTECTED]> M2P 2A8 +1 416 646 3304 x110 ---(end of broadcast)--- TIP 2: you can get off all lists at once with the unregister command (send "unregister YourEmailAddressHere" to [EMAIL PROTECTED])
