Re: Trailing Whitespace Tips (was: [HACKERS] Re: starting to review the Extend NOT NULL representation to pg_constraint patch)
On fre, 2010-10-15 at 22:45 +0200, Dimitri Fontaine wrote: I suppose people using other editors or tools will come up with other tricks and tips. Here is an alternative recipe that I have been using: (require 'show-wspace) (add-hook 'font-lock-mode-hook 'show-ws-highlight-hard-spaces) (add-hook 'font-lock-mode-hook 'show-ws-highlight-tabs) (add-hook 'font-lock-mode-hook 'show-ws-highlight-trailing-whitespace) Maybe it should go in src/tools/editors/emacs.samples, too? Yeah, I think we should recommend some way to highlight faulty whitespace. The problem is, after you turn it on, it will make you cry as you realize how sloppy most code and other files are written. -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
Re: Trailing Whitespace Tips (was: [HACKERS] Re: starting to review the Extend NOT NULL representation to pg_constraint patch)
--On 16. Oktober 2010 12:35:06 +0300 Peter Eisentraut pete...@gmx.net wrote: Maybe it should go in src/tools/editors/emacs.samples, too? Yeah, I think we should recommend some way to highlight faulty whitespace. The problem is, after you turn it on, it will make you cry as you realize how sloppy most code and other files are written. That's exactly why it is mostly off in my case. But you always can put it in a special editing mode, which i currently experimenting with. Thanks for your tips. -- Thanks Bernd -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
Trailing Whitespace Tips (was: [HACKERS] Re: starting to review the Extend NOT NULL representation to pg_constraint patch)
Tom Lane t...@sss.pgh.pa.us writes: * Lots of bogus trailing whitespace. git diff --check can help you with that. This is a repetitive common remark that I think sharing tips to avoid that problem is a good idea. Here's an emacs setup to have trailing whitespace hurt the eyes, and more-than-80 columns lines too. This one is more controversial as we find lots of long lines in the PostgreSQL sources. Still: ;; display only tails of lines longer than 80 columns, and ;; trailing whitespaces (require 'whitespace) (setq whitespace-line-column 80 whitespace-style '(face trailing lines-tail empty)) ;; face for tabs long lines' tails (set-face-attribute 'whitespace-tab nil :background red1 :foreground yellow :weight 'bold) (set-face-attribute 'whitespace-line nil :background red1 :foreground yellow :weight 'bold) ;; activate minor whitespace mode when in some coding modes (add-hook 'emacs-lisp-mode-hook 'whitespace-mode) (add-hook 'python-mode-hook 'whitespace-mode) (add-hook 'c-mode-hook 'whitespace-mode) Now, it's easy to find some more about it, including images of how it looks. You can't miss trailing whitespace any more : http://ruslanspivak.com/2010/09/27/keep-track-of-whitespaces-and-column-80-overflow/ http://panela.blog-city.com/python_and_emacs_4_whitespace_tabs_tabwidth_visualizi.htm http://www.emacswiki.org/emacs/WhiteSpace I suppose people using other editors or tools will come up with other tricks and tips. Maybe it should go in src/tools/editors/emacs.samples, too? Regards, -- Dimitri Fontaine http://2ndQuadrant.fr PostgreSQL : Expertise, Formation et Support -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
