Re: [JDBC] JDBC test suite patch
On Thu, 20 Sep 2001 16:24:45 -0400, you wrote: > . failure in TimestampTest (testSetTimestamp) fixed. The failure is >because testSetTimestamp was inserting a timestamp with hour 7 but >checkTimeTest was expecting a timestamp with hour 8. AFAICS, there are >no issues wrt daylight savings time and timestamps being pushed in and >pulled out (but more explicit tests should be added in the future) > > . failure in TimeTest (testGetTime) fixed. Times to be inserted were >interpreted in the localtime zone but checking was done with the >assumption that the insertion was done in GMT. Unfortunately, I'm still getting one failure: [junit] Time: 2.716 [junit] There was 1 failure: [junit] 1) testGetTimestamp(org.postgresql.test.jdbc2.TimestampTest)junit.framework.AssertionFailedError [junit] at org.postgresql.test.jdbc2.TimestampTest.timestampTest(TimestampTest.java:112) [junit] at org.postgresql.test.jdbc2.TimestampTest.testGetTimestamp(TimestampTest.java:54) [junit] [junit] FAILURES!!! [junit] Tests run: 43, Failures: 1, Errors: 0 I haven't looked into it yet. Will do later. Regards, René Pijlman <[EMAIL PROTECTED]> ---(end of broadcast)--- TIP 6: Have you searched our list archives? http://archives.postgresql.org
Re: [JDBC] JDBC test suite patch
Your name has been added to the bottom of the TODO list. > > I tried sending the email to jdbc and patches on the 17th but it didn't get > through. I'm attempting again.. > > The attached patch is my first run-through of the JDBC test suite. A > summary of changes: > > . removal of the tablename property from build.xml > > . addition of a dropTable method in JDBC2Tests and cleanups of many > methods in the same > > . all tests now use non-deprecated assertXYZ methods instead of the > deprecated assert method > > . failure in TimestampTest (testSetTimestamp) fixed. The failure is > because testSetTimestamp was inserting a timestamp with hour 7 but > checkTimeTest was expecting a timestamp with hour 8. AFAICS, there are > no issues wrt daylight savings time and timestamps being pushed in and > pulled out (but more explicit tests should be added in the future) > > . failure in TimeTest (testGetTime) fixed. Times to be inserted were > interpreted in the localtime zone but checking was done with the > assumption that the insertion was done in GMT. > > . formatting changes in a few of the source files (because I found > it convenient to have consistent formatting while working on them). The > formatting is consistent with the new format for java source files in > PostgreSQL. > > Liam > > -- > Liam Stewart :: Red Hat Canada, Ltd. :: [EMAIL PROTECTED] [ Attachment, skipping... ] > > ---(end of broadcast)--- > TIP 4: Don't 'kill -9' the postmaster -- Bruce Momjian| http://candle.pha.pa.us [EMAIL PROTECTED] | (610) 853-3000 + If your life is a hard drive, | 830 Blythe Avenue + Christ can be your backup.| Drexel Hill, Pennsylvania 19026 ---(end of broadcast)--- TIP 6: Have you searched our list archives? http://archives.postgresql.org
Re: [JDBC] JDBC test suite patch
Patch applied. Thanks. > > I tried sending the email to jdbc and patches on the 17th but it didn't get > through. I'm attempting again.. > > The attached patch is my first run-through of the JDBC test suite. A > summary of changes: > > . removal of the tablename property from build.xml > > . addition of a dropTable method in JDBC2Tests and cleanups of many > methods in the same > > . all tests now use non-deprecated assertXYZ methods instead of the > deprecated assert method > > . failure in TimestampTest (testSetTimestamp) fixed. The failure is > because testSetTimestamp was inserting a timestamp with hour 7 but > checkTimeTest was expecting a timestamp with hour 8. AFAICS, there are > no issues wrt daylight savings time and timestamps being pushed in and > pulled out (but more explicit tests should be added in the future) > > . failure in TimeTest (testGetTime) fixed. Times to be inserted were > interpreted in the localtime zone but checking was done with the > assumption that the insertion was done in GMT. > > . formatting changes in a few of the source files (because I found > it convenient to have consistent formatting while working on them). The > formatting is consistent with the new format for java source files in > PostgreSQL. > > Liam > > -- > Liam Stewart :: Red Hat Canada, Ltd. :: [EMAIL PROTECTED] [ Attachment, skipping... ] > > ---(end of broadcast)--- > TIP 4: Don't 'kill -9' the postmaster -- Bruce Momjian| http://candle.pha.pa.us [EMAIL PROTECTED] | (610) 853-3000 + If your life is a hard drive, | 830 Blythe Avenue + Christ can be your backup.| Drexel Hill, Pennsylvania 19026 ---(end of broadcast)--- TIP 1: subscribe and unsubscribe commands go to [EMAIL PROTECTED]
Re: [JDBC] JDBC test suite patch
Your patch has been added to the PostgreSQL unapplied patches list at: http://candle.pha.pa.us/cgi-bin/pgpatches I will try to apply it within the next 48 hours. > > I tried sending the email to jdbc and patches on the 17th but it didn't get > through. I'm attempting again.. > > The attached patch is my first run-through of the JDBC test suite. A > summary of changes: > > . removal of the tablename property from build.xml > > . addition of a dropTable method in JDBC2Tests and cleanups of many > methods in the same > > . all tests now use non-deprecated assertXYZ methods instead of the > deprecated assert method > > . failure in TimestampTest (testSetTimestamp) fixed. The failure is > because testSetTimestamp was inserting a timestamp with hour 7 but > checkTimeTest was expecting a timestamp with hour 8. AFAICS, there are > no issues wrt daylight savings time and timestamps being pushed in and > pulled out (but more explicit tests should be added in the future) > > . failure in TimeTest (testGetTime) fixed. Times to be inserted were > interpreted in the localtime zone but checking was done with the > assumption that the insertion was done in GMT. > > . formatting changes in a few of the source files (because I found > it convenient to have consistent formatting while working on them). The > formatting is consistent with the new format for java source files in > PostgreSQL. > > Liam > > -- > Liam Stewart :: Red Hat Canada, Ltd. :: [EMAIL PROTECTED] [ Attachment, skipping... ] > > ---(end of broadcast)--- > TIP 4: Don't 'kill -9' the postmaster -- Bruce Momjian| http://candle.pha.pa.us [EMAIL PROTECTED] | (610) 853-3000 + If your life is a hard drive, | 830 Blythe Avenue + Christ can be your backup.| Drexel Hill, Pennsylvania 19026 ---(end of broadcast)--- TIP 1: subscribe and unsubscribe commands go to [EMAIL PROTECTED]
