Re: [PATCHES] [BUGS] ISM shared memory on solaris
Please use new patch. This uses __sun__ rather than sun. --- Josh Wilmes wrote: > > Bruce Momjian wrote: > > > Josh Wilmes wrote: > > > >>Nope, __solaris__ is not defined on our system either. > > > > > > I thought our configure defined __portname__ for every platform, but I > > don't see that anywhere, so it seems we rely on the compiler to supply > > defines for the cpu and OS. > > > > Does src/tools/ccsym show you your defines? I would like to have > > something that identifies Solaris rather than something that checks for > > ISM so that if the ISM define isn't found, we throw an error and we hear > > about it. > > That would be preferable- i didn't know what was safe to assume would > always be defined. > > ccsym is pretty neat. Here's what it shows (gcc) > > __GNUC__=2 > __GNUC_MINOR__=95 > sparc > sun > unix > __svr4__ > __SVR4 > __sparc__ > __sun__ > __unix__ > __svr4__ > __SVR4 > __sparc > __sun > __unix > system=unix > system=svr4 > __GCC_NEW_VARARGS__ > cpu=sparc > machine=sparc > > > > ---(end of broadcast)--- > TIP 7: don't forget to increase your free space map settings > -- Bruce Momjian| http://candle.pha.pa.us [EMAIL PROTECTED] | (610) 359-1001 + If your life is a hard drive, | 13 Roberts Road + Christ can be your backup.| Newtown Square, Pennsylvania 19073 Index: src/backend/port/sysv_shmem.c === RCS file: /cvsroot/pgsql-server/src/backend/port/sysv_shmem.c,v retrieving revision 1.21 diff -c -c -r1.21 sysv_shmem.c *** src/backend/port/sysv_shmem.c 13 Oct 2003 22:47:15 - 1.21 --- src/backend/port/sysv_shmem.c 26 Oct 2003 04:52:33 - *** *** 133,139 on_shmem_exit(IpcMemoryDelete, Int32GetDatum(shmid)); /* OK, should be able to attach to the segment */ ! #if defined(solaris) && defined(__sparc__) /* use intimate shared memory on SPARC Solaris */ memAddress = shmat(shmid, 0, SHM_SHARE_MMU); #else --- 133,139 on_shmem_exit(IpcMemoryDelete, Int32GetDatum(shmid)); /* OK, should be able to attach to the segment */ ! #if defined(__sun__) && defined(__sparc__) /* use intimate shared memory on SPARC Solaris */ memAddress = shmat(shmid, 0, SHM_SHARE_MMU); #else *** *** 352,358 hdr = (PGShmemHeader *) shmat(*shmid, UsedShmemSegAddr, ! #if defined(solaris) && defined(__sparc__) /* use intimate shared memory on Solaris */ SHM_SHARE_MMU #else --- 352,358 hdr = (PGShmemHeader *) shmat(*shmid, UsedShmemSegAddr, ! #if defined(__sun__) && defined(__sparc__) /* use intimate shared memory on Solaris */ SHM_SHARE_MMU #else ---(end of broadcast)--- TIP 9: the planner will ignore your desire to choose an index scan if your joining column's datatypes do not match
Re: [PATCHES] [BUGS] ISM shared memory on solaris
OK, attached patch applied. I tested for 'sun' rather than 'solaris'. --- Josh Wilmes wrote: > > Bruce Momjian wrote: > > > Josh Wilmes wrote: > > > >>Nope, __solaris__ is not defined on our system either. > > > > > > I thought our configure defined __portname__ for every platform, but I > > don't see that anywhere, so it seems we rely on the compiler to supply > > defines for the cpu and OS. > > > > Does src/tools/ccsym show you your defines? I would like to have > > something that identifies Solaris rather than something that checks for > > ISM so that if the ISM define isn't found, we throw an error and we hear > > about it. > > That would be preferable- i didn't know what was safe to assume would > always be defined. > > ccsym is pretty neat. Here's what it shows (gcc) > > __GNUC__=2 > __GNUC_MINOR__=95 > sparc > sun > unix > __svr4__ > __SVR4 > __sparc__ > __sun__ > __unix__ > __svr4__ > __SVR4 > __sparc > __sun > __unix > system=unix > system=svr4 > __GCC_NEW_VARARGS__ > cpu=sparc > machine=sparc > > > > ---(end of broadcast)--- > TIP 7: don't forget to increase your free space map settings > -- Bruce Momjian| http://candle.pha.pa.us [EMAIL PROTECTED] | (610) 359-1001 + If your life is a hard drive, | 13 Roberts Road + Christ can be your backup.| Newtown Square, Pennsylvania 19073 Index: src/backend/port/sysv_shmem.c === RCS file: /cvsroot/pgsql-server/src/backend/port/sysv_shmem.c,v retrieving revision 1.21 diff -c -c -r1.21 sysv_shmem.c *** src/backend/port/sysv_shmem.c 13 Oct 2003 22:47:15 - 1.21 --- src/backend/port/sysv_shmem.c 26 Oct 2003 04:52:33 - *** *** 133,139 on_shmem_exit(IpcMemoryDelete, Int32GetDatum(shmid)); /* OK, should be able to attach to the segment */ ! #if defined(solaris) && defined(__sparc__) /* use intimate shared memory on SPARC Solaris */ memAddress = shmat(shmid, 0, SHM_SHARE_MMU); #else --- 133,139 on_shmem_exit(IpcMemoryDelete, Int32GetDatum(shmid)); /* OK, should be able to attach to the segment */ ! #if defined(sun) && defined(__sparc__) /* use intimate shared memory on SPARC Solaris */ memAddress = shmat(shmid, 0, SHM_SHARE_MMU); #else *** *** 352,358 hdr = (PGShmemHeader *) shmat(*shmid, UsedShmemSegAddr, ! #if defined(solaris) && defined(__sparc__) /* use intimate shared memory on Solaris */ SHM_SHARE_MMU #else --- 352,358 hdr = (PGShmemHeader *) shmat(*shmid, UsedShmemSegAddr, ! #if defined(sun) && defined(__sparc__) /* use intimate shared memory on Solaris */ SHM_SHARE_MMU #else ---(end of broadcast)--- TIP 3: if posting/reading through Usenet, please send an appropriate subscribe-nomail command to [EMAIL PROTECTED] so that your message can get through to the mailing list cleanly
Re: [PATCHES] Tutorial fixes
Patch applied. Thanks. --- Christopher Kings-Lynne wrote: > Fix two bugs in funcs.source that made the tutorial script fail. > > Make a LOT of fixes to syscat.source to: > > * Set search_path properly (and reset it) > * Add schema name to all results > * Add schema name to ORDER BY first > * Make checks for user-defined objects match reality > * format_type all type names > * Respect attisdropped > * Change !~ to 'not like' since it's more standard > > All changes have been tested. > > Chris > Content-Description: [ Attachment, skipping... ] > > ---(end of broadcast)--- > TIP 9: the planner will ignore your desire to choose an index scan if your > joining column's datatypes do not match -- Bruce Momjian| http://candle.pha.pa.us [EMAIL PROTECTED] | (610) 359-1001 + If your life is a hard drive, | 13 Roberts Road + Christ can be your backup.| Newtown Square, Pennsylvania 19073 ---(end of broadcast)--- TIP 6: Have you searched our list archives? http://archives.postgresql.org
Re: [PATCHES] more improvements to release notes
Neil Conway wrote: > On Wed, 2003-10-22 at 13:26, Bruce Momjian wrote: > > > * Cause FETCH 1 to return the next cursor row, or zero if at > > > > >beginning/end of cursor, per SQL spec (Bruce) > > That's better, but still wrong: what does it mean for FETCH 1 to "return > zero if at the beginning/end of cursor"? If we're at the end of the > cursor, we return an empty result set, not "zero". > OK, updated: Make MOVE/FETCH 0 now does nothing (Bruce) Cause MOVE/FETCH now returns the number of rows moved/fetched, or zero if at the beginning/end of cursor, per SQL spec (Bruce) -- Bruce Momjian| http://candle.pha.pa.us [EMAIL PROTECTED] | (610) 359-1001 + If your life is a hard drive, | 13 Roberts Road + Christ can be your backup.| Newtown Square, Pennsylvania 19073 ---(end of broadcast)--- TIP 6: Have you searched our list archives? http://archives.postgresql.org
Re: [PATCHES] minor psql cleanup
This has been saved for the 7.5 release: http:/momjian.postgresql.org/cgi-bin/pgpatches2 --- Neil Conway wrote: > This patch reduces some unsightly #ifdefs, and fixes two typos in > comments in the psql code. This doesn't make any functional change, so > feel free to save it for 7.5 > > -Neil > [ Attachment, skipping... ] > > ---(end of broadcast)--- > TIP 3: if posting/reading through Usenet, please send an appropriate > subscribe-nomail command to [EMAIL PROTECTED] so that your > message can get through to the mailing list cleanly -- Bruce Momjian| http://candle.pha.pa.us [EMAIL PROTECTED] | (610) 359-1001 + If your life is a hard drive, | 13 Roberts Road + Christ can be your backup.| Newtown Square, Pennsylvania 19073 ---(end of broadcast)--- TIP 7: don't forget to increase your free space map settings
Re: [PATCHES] spanish psql update
Alvaro Herrera writes: > The spanish psql message catalog is attached. Installed as well. -- Peter Eisentraut [EMAIL PROTECTED] ---(end of broadcast)--- TIP 7: don't forget to increase your free space map settings
Re: [PATCHES] spanish updates, take 2
Alvaro Herrera writes: > I attach the whole spanish PO catalogs again, correcting some typos. Installed. -- Peter Eisentraut [EMAIL PROTECTED] ---(end of broadcast)--- TIP 2: you can get off all lists at once with the unregister command (send "unregister YourEmailAddressHere" to [EMAIL PROTECTED])
Re: [PATCHES] [BUGS] PostgreSQL Patch: Test-and-set routine for HP-UX
I am unable to get this patch to compile: gcc version : gcc (GCC) 3.2 20020329 (experimental) uname -srm : HP-UX B.11.22 ia64 tar xvf postgresql-7.3.4.tar cd postgresql-7.3.4 patch -p0 ../PostgreSQL-7.3.4_hpux3_11iv2_IA-64.patch ./configure [snip] make [snip] gmake[4]: Entering directory `/home/postgres/src/postgresql-7.3.4/src/backend/ac cess/transam' gcc -O2 -Wall -Wmissing-prototypes -Wmissing-declarations -I../../../../src/incl ude -c -o xlog.o xlog.c xlog.c: In function `XLogInsert': xlog.c:641: incompatible types in assignment xlog.c:870: incompatible types in assignment xlog.c: In function `AdvanceXLInsertBuffer': xlog.c:929: incompatible types in assignment xlog.c: In function `XLogWrite': xlog.c:1189: incompatible types in assignment xlog.c: In function `XLogFlush': xlog.c:1248: incompatible types in assignment xlog.c: In function `XLOGShmemInit': xlog.c:2361: incompatible types in assignment xlog.c: In function `GetRedoRecPtr': xlog.c:2918: incompatible types in assignment xlog.c: In function `CreateCheckPoint': xlog.c:3068: incompatible types in assignment gmake[4]: *** [xlog.o] Error 1 gmake[4]: Leaving directory `/home/postgres/src/postgresql-7.3.4/src/backend/acc ess/transam' gmake[3]: *** [transam-recursive] Error 2 This seems to be a problem with SpinLockRelease_NoHoldoff. On Fri, 2003-10-24 at 11:51, ViSolve Open Source Team wrote: > Subject: PostgreSQL Patch: Test-and-set routine for HP-UX (IA-64) > > > Hello, > > The attached patch provides a test-and-set routine for PostgreSQL for HP-UX > 11iV2 for the Intel Itanium architecture (known to the PostgreSQL code as > IA-64). There are actually two issues: > > 1. There is currently no tas (test-and-set) routine for HP-UX IA-64 in the > s_lock.h header file. > 2. In HP-UX IA-64, the suffix of shared libraries is ".so", but PostgreSQL > generates a ".sl" suffix. > > The attached patch fixes both issues. The bug template (also attached) > contains the details. > > We (ViSolve) are a group that works closely with HP on their OpenSource > initiative. We would really appreciate a timely inclusion of this patch > into mainstream PostgreSQL. > > thanks > ViSolve OpenSource Team (for HP) > > __ > ---(end of broadcast)--- > TIP 8: explain analyze is your friend ---(end of broadcast)--- TIP 2: you can get off all lists at once with the unregister command (send "unregister YourEmailAddressHere" to [EMAIL PROTECTED])
Re: [PATCHES] NLS: Swedish update of psql.po
On Sat, 18 Oct 2003, Dennis Bjorklund wrote: > All strings in the swedish psql.po have been translated. The above have not been commited. I also see on the translate page that pg_dump is now at 99%, it was at a beautiful 100% before.. Is it possible to get cvs access, with say a promise that I only touch the swedish po files. It would be much easier to just keep the files translated if one can make a couple of changes and check it in, instead of trying to do a lot of changes at a time so that it's worth the extra job of sending mails. -- /Dennis ---(end of broadcast)--- TIP 9: the planner will ignore your desire to choose an index scan if your joining column's datatypes do not match
[PATCHES] spanish psql update
The spanish psql message catalog is attached. -- Alvaro Herrera () "La gente vulgar solo piensa en pasar el tiempo; el que tiene talento, en aprovecharlo" psql-es.po.gz Description: Binary data ---(end of broadcast)--- TIP 3: if posting/reading through Usenet, please send an appropriate subscribe-nomail command to [EMAIL PROTECTED] so that your message can get through to the mailing list cleanly
[PATCHES] spanish updates, take 2
I attach the whole spanish PO catalogs again, correcting some typos. They are at 100% again. I already posted them three days ago, but they got lost probably because the size of the mail. I will post the backend and libpq catalog separately. -- Alvaro Herrera () Si no sabes adonde vas, es muy probable que acabes en otra parte. libpq-es.po.gz Description: Binary data pg_controldata-es.po.gz Description: Binary data pg_dump-es.po.gz Description: Binary data pg_resetxlog-es.po.gz Description: Binary data scripts-es.po.gz Description: Binary data ---(end of broadcast)--- TIP 8: explain analyze is your friend