Re: [PATCHES] [pgsql-hackers-win32] 300 seconds in less than 1 second

2005-01-23 Thread Bruce Momjian

[ Previous sleep() patch removed.]

Your patch has been added to the PostgreSQL unapplied patches list at:

http://momjian.postgresql.org/cgi-bin/pgpatches

It will be applied as soon as one of the PostgreSQL committers reviews
and approves it.

---


Dave Page wrote:
  
 
  -Original Message-
  From: Andrew Dunstan [mailto:[EMAIL PROTECTED] 
  Sent: 21 January 2005 14:01
  To: Dave Page
  Cc: [EMAIL PROTECTED]; [EMAIL PROTECTED]; 
  pgsql-patches@postgresql.org
  Subject: Re: [PATCHES] [pgsql-hackers-win32] 300 seconds in 
  less than 1 second with pg_autovacuum
  
 
  
  We should not be using either of these, should we? 
  pg_usleep() is platform
  independent.
 
 True. Attached.
 
 Regards, Dave.

Content-Description: pg_autovacuum.c.diff

[ Attachment, skipping... ]

 
 ---(end of broadcast)---
 TIP 2: you can get off all lists at once with the unregister command
 (send unregister YourEmailAddressHere to [EMAIL PROTECTED])

-- 
  Bruce Momjian|  http://candle.pha.pa.us
  pgman@candle.pha.pa.us   |  (610) 359-1001
  +  If your life is a hard drive, |  13 Roberts Road
  +  Christ can be your backup.|  Newtown Square, Pennsylvania 19073

---(end of broadcast)---
TIP 3: if posting/reading through Usenet, please send an appropriate
  subscribe-nomail command to [EMAIL PROTECTED] so that your
  message can get through to the mailing list cleanly


Re: [PATCHES] Tiny patch on print.c of psql

2005-01-23 Thread Bruce Momjian

This has been saved for the 8.1 release:

http://momjian.postgresql.org/cgi-bin/pgpatches2

---

Jean-Paul Argudo wrote:
 Hi all,
 
 This is my 1st patch ever in C :-)... I was just borried by a bad psql
 \H html output of an EXPLAIN
 
 because it didnt respected spaces sent from backend like:
 
 - Sort
 - Sort
 
 I just remarked in this print.c the case of a white space wasnt handled 
 in the function escaping special caracters to HTML codes, so I added it 
 replacing a space by special html nbsp; ( n b s p).
 
 So we'll have now:
 
 -nbsp;Sort
 nbsp;nbsp;-nbsp;Sort
 
 ... in the html generated
 
 (see example at http://www.pack-solutions.net/~jpargudo/explain.html)
 
 Then, every single space in the html source is replaced by this. The
 source looks ugly, yes, I will look to *only replacing starting spaces* 
 of each row of the EXPLAIN, thats will be my 1st patch ever, version 2 :)
 
 So I post this patch only FYI..  I had much fun playing with C a bit :-)
 (yes, I dont code C, just a bit of Perl and Python).
 
 Cheers! Thanks again for such a powerfull release.
 
 -- 
 Jean-Paul Argudo
 www.PostgreSQLFr.org


 
 ---(end of broadcast)---
 TIP 9: the planner will ignore your desire to choose an index scan if your
   joining column's datatypes do not match

-- 
  Bruce Momjian|  http://candle.pha.pa.us
  pgman@candle.pha.pa.us   |  (610) 359-1001
  +  If your life is a hard drive, |  13 Roberts Road
  +  Christ can be your backup.|  Newtown Square, Pennsylvania 19073

---(end of broadcast)---
TIP 6: Have you searched our list archives?

   http://archives.postgresql.org


Re: [PATCHES] pg_autovacuum/Win32 Fixes

2005-01-23 Thread Neil Conway
On Sat, 2005-01-22 at 21:13 +1100, Neil Conway wrote:
 Barring any objections I'll apply this patch to REL8_0_STABLE and HEAD 
 on Monday.

Applied, thanks for the patch.

-Neil



---(end of broadcast)---
TIP 3: if posting/reading through Usenet, please send an appropriate
  subscribe-nomail command to [EMAIL PROTECTED] so that your
  message can get through to the mailing list cleanly


Re: [PATCHES] pg_autovacuum/Win32 Fixes

2005-01-23 Thread Bruce Momjian

All your pg_autovacuum patches were applied by Neil.

---

Dave Page wrote:
  
 
  -Original Message-
  From: Neil Conway [mailto:[EMAIL PROTECTED] 
  Sent: 22 January 2005 10:13
  To: Dave Page
  Cc: pgsql-patches@postgresql.org
  Subject: Re: [PATCHES] pg_autovacuum/Win32 Fixes
  
  Dave Page wrote:
   Theis patch supercedes *all* my earlier ones from today - 
  apologies for
   the noise, clearly I need a beer or 3 and a few nights away from the
   laptop.
  
  @@ -1166,7 +1166,9 @@
  exit(0);
#ifdef WIN32
  case 'E':
  -   args-service_dependencies = optarg;
  +   ZeroMemory(deps, sizeof(deps));
  +   snprintf(deps, sizeof(deps) - 2, %s, optarg);
  +   args-service_dependencies = (char *)deps;
  break;
  case 'I':
  args-install_as_service++;
  
  After googling around I can see what this code is intended to 
  do; in the 
  future a comment might be nice. 
 
 Sorry - as you probably noticed it was one of 'those days'.
 
  Also, why not strncpy()?
 
 No reason, just a hangover from some experimentation I was doing. I've
 no objections if you want to change it.
 
  Barring any objections I'll apply this patch to REL8_0_STABLE 
  and HEAD 
  on Monday.
 
 Thanks, Dave.
 
 ---(end of broadcast)---
 TIP 3: if posting/reading through Usenet, please send an appropriate
   subscribe-nomail command to [EMAIL PROTECTED] so that your
   message can get through to the mailing list cleanly
 

-- 
  Bruce Momjian|  http://candle.pha.pa.us
  pgman@candle.pha.pa.us   |  (610) 359-1001
  +  If your life is a hard drive, |  13 Roberts Road
  +  Christ can be your backup.|  Newtown Square, Pennsylvania 19073

---(end of broadcast)---
TIP 4: Don't 'kill -9' the postmaster