Re: [PATCHES] [HACKERS] Remove lossy-operator RECHECK flag?

2008-04-14 Thread Teodor Sigaev

Actually, I think I figured it out.  Please look over the GIST/GIN parts
of this patch and see if they're OK with you.


Looks good, thank you.

Why don't use suggested way for GIN index over tsvector?
http://archives.postgresql.org/pgsql-hackers/2008-04/msg00812.php
It's nothing to cost light optimization...


This is still WIP because I haven't touched any contrib code, but
as far as the main backend goes I think it's ready to apply.


Patch to all contrib modules:
http://www.sigaev.ru/misc/contrib.patch.gz


--
Teodor Sigaev   E-mail: [EMAIL PROTECTED]
   WWW: http://www.sigaev.ru/

--
Sent via pgsql-patches mailing list (pgsql-patches@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-patches


Re: [PATCHES] [HACKERS] Remove lossy-operator RECHECK flag?

2008-04-14 Thread Tom Lane
Teodor Sigaev [EMAIL PROTECTED] writes:
 Why don't use suggested way for GIN index over tsvector?
 http://archives.postgresql.org/pgsql-hackers/2008-04/msg00812.php

I had forgotten the details :-(.  Will adopt that code.

 This is still WIP because I haven't touched any contrib code, but
 as far as the main backend goes I think it's ready to apply.

 Patch to all contrib modules:
 http://www.sigaev.ru/misc/contrib.patch.gz

Ooops, we duplicated work :-(.  Will compare with your version before
applying.

regards, tom lane

-- 
Sent via pgsql-patches mailing list (pgsql-patches@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-patches


Re: [PATCHES] [HACKERS] Remove lossy-operator RECHECK flag?

2008-04-13 Thread Tom Lane
I wrote:
 I've committed changes that move the determination of whether recheck is
 required into the index AMs.  Right now, GIST and GIN just always set
 the recheck flag to TRUE.  Obviously that control should be pushed down
 to the opclass consistent() functions, but I don't know that code well
 enough to be clear on exactly what should happen.  Are you willing to
 do that part?

Actually, I think I figured it out.  Please look over the GIST/GIN parts
of this patch and see if they're OK with you.

This is still WIP because I haven't touched any contrib code, but
as far as the main backend goes I think it's ready to apply.

regards, tom lane



binI2STY1wRy8.bin
Description: run-time-recheck-1.patch.gz

-- 
Sent via pgsql-patches mailing list (pgsql-patches@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-patches