Re: [PATCHES] [HACKERS] buildenv.pl/buildenv.bat
On Fri, Dec 14, 2007 at 10:47:02AM -0500, Andrew Dunstan wrote: > > > Magnus Hagander wrote: > >On Fri, Dec 14, 2007 at 03:39:14PM +, Dave Page wrote: > > > >>Andrew Dunstan wrote: > >> > >>>Writing and calling a temp .bat file might be yucky - having to keep two > >>>environment files is a lot more yucky, IMNSHO, and we shouldn't make > >>>people do it. > >>> > >>+1 > >> > > > >Ok, I guess I'm outvoted ;-) I don't care *that* much about it, so let's do > >it your way. > > > >You need help testing that patch further, or do you consider it ready for > >application? If so, go. > > > > > > > > Yes, please do test it - I don't use buildenv.* at all normally, as then > buildfarm client takes care of its own environment, and that's what I > usually use to build on Windows. It works in my two standalone environments (win32 and win64 machine), so I've applied the patch now to get full buildfarm testing. //Magnus ---(end of broadcast)--- TIP 2: Don't 'kill -9' the postmaster
Re: [PATCHES] [HACKERS] buildenv.pl/buildenv.bat
Magnus Hagander wrote: On Fri, Dec 14, 2007 at 03:39:14PM +, Dave Page wrote: Andrew Dunstan wrote: Writing and calling a temp .bat file might be yucky - having to keep two environment files is a lot more yucky, IMNSHO, and we shouldn't make people do it. +1 Ok, I guess I'm outvoted ;-) I don't care *that* much about it, so let's do it your way. You need help testing that patch further, or do you consider it ready for application? If so, go. Yes, please do test it - I don't use buildenv.* at all normally, as then buildfarm client takes care of its own environment, and that's what I usually use to build on Windows. cheers andrew. ---(end of broadcast)--- TIP 7: You can help support the PostgreSQL project by donating at http://www.postgresql.org/about/donate
Re: [PATCHES] [HACKERS] buildenv.pl/buildenv.bat
On Fri, Dec 14, 2007 at 03:39:14PM +, Dave Page wrote: > Andrew Dunstan wrote: > > Writing and calling a temp .bat file might be yucky - having to keep two > > environment files is a lot more yucky, IMNSHO, and we shouldn't make > > people do it. > > +1 Ok, I guess I'm outvoted ;-) I don't care *that* much about it, so let's do it your way. You need help testing that patch further, or do you consider it ready for application? If so, go. //Magnus ---(end of broadcast)--- TIP 3: Have you checked our extensive FAQ? http://www.postgresql.org/docs/faq
Re: [PATCHES] [HACKERS] buildenv.pl/buildenv.bat
Andrew Dunstan wrote: > Writing and calling a temp .bat file might be yucky - having to keep two > environment files is a lot more yucky, IMNSHO, and we shouldn't make > people do it. +1 /D ---(end of broadcast)--- TIP 9: In versions below 8.0, the planner will ignore your desire to choose an index scan if your joining column's datatypes do not match
