Re: [PATCHES] [PERFORM] [pgsql-hackers-win32] scalability issues on win32

[Tom Lane]

"Magnus Hagander" <[EMAIL PROTECTED]> writes:
> Attached patch solves the problem for me.Didn't see anything of the
> problem you described about hangs in my implementation. Probably because
> mine exits at the first sign of a linebreak.

Applied with some trivial legibility improvements.

regards, tom lane

---(end of broadcast)---
TIP 4: Don't 'kill -9' the postmaster

Re: [PATCHES] [PERFORM] [pgsql-hackers-win32] scalability issues on win32

[Merlin Moncure]

> Attached patch solves the problem for me.Didn't see anything of the
> problem you described about hangs in my implementation. Probably
because
> mine exits at the first sign of a linebreak.

I confirmed the fix.  8.0.0 now starts up with net start (this is where
I first noticed the problem).  When I get some time I'll investigate if
this is related to the problems I was having with the statistics
collector.

Merlin

---(end of broadcast)---
TIP 8: explain analyze is your friend

Re: [PATCHES] [PERFORM] [pgsql-hackers-win32] scalability issues on win32

[Magnus Hagander]

Attached patch solves the problem for me.Didn't see anything of the
problem you described about hangs in my implementation. Probably because
mine exits at the first sign of a linebreak.

//Magnus

>-Original Message-
>From: [EMAIL PROTECTED] 
>[mailto:[EMAIL PROTECTED] On Behalf Of 
>Claudio Natoli
>Sent: den 17 december 2004 01:31
>To: Bruce Momjian
>Cc: Merlin Moncure; Tom Lane; Win 32 hackers PGSQL
>Subject: Re: [PERFORM] [pgsql-hackers-win32] scalability 
>issues on win32
>
>
>
>Hi Bruce and all,
>
>sorry guys, I won't have a chance to get to this until after 
>the Christmas break.
>
>If one of the other usual suspects (Dave, Andrew, Magnus, 
>Merlin) can claim it sooner, please do!
>
>Cheers,
>Claudio
>
>
>
>> -Original Message-
>> From: Bruce Momjian [mailto:[EMAIL PROTECTED]
>> Sent: Friday, 17 December 2004 11:25 AM
>> To: Claudio Natoli
>> Cc: 'Merlin Moncure'; Tom Lane; Win 32 hackers PGSQL
>> Subject: Re: [PERFORM] [pgsql-hackers-win32] scalability 
>> issues on win32
>> 
>> 
>> 
>> Claudio, I need this completed so we can get it into CVS.  
>> Without it a
>> 8.0.0 version string will fail to compare.
>> 
>> --
>> -
>> 
>> Claudio Natoli wrote:
>> > 
>> > Hi Merlin,
>> > 
>> > > On a probably unrelated note:
>> > > Can some other win32 hacker try the following?
>> > > Download the latest cvs sources from the server and edit 
>> configure,
>> > > replacing all instances of '8.0beta5' with '8.0' etc. as is 
>> > > will be when released.  Following that do a full 
>> make/make clean.  After 
>> > > that try and start he server with pg_ctl.exe and tell me 
>> if it succeeds or
>> > not.
>> > 
>> > I can confirm this failure.
>> > 
>> > (in my case at least) pg_ctl is not seeing the full version 
>> string of the
>> > postmaster in find_other_exec. This is due to the single 
>> call to ReadFile in
>> > pipe_read_line, which is not returning the entire version 
>> string (losing all
>> > characters beyond the last decimal point in the version string). A
>> > subsequent call to ReadFile picks up the remainder of the 
>> string. I don't
>> > see that we can rely on a single call returning the entire 
>> version string.
>> > 
>> > If someone can run with this, I've attached initial looping 
>> changes for
>> > pipe_read_line. However I'm not sure of the correct 
>> terminating condition
>> > (gets into a call to ReadFile that never returns; the 
>> WaitForSingleObject
>> > appears insufficient as a precondition for ReadFile) and 
>> just don't have
>> > time to complete it right now.
>> > 
>> > Cheers,
>> > Claudio
>> > 


exec_pipe.patch
Description: exec_pipe.patch

---(end of broadcast)---
TIP 3: if posting/reading through Usenet, please send an appropriate
  subscribe-nomail command to [EMAIL PROTECTED] so that your
  message can get through to the mailing list cleanly