Re: [PATCHES] [pgsql-hackers-win32] Contrib modules on Win32
Dave Page wrote:
cube
seg
patch attached. Compiles, but not tested.
miscutil
Needs review; includes some deprecated stuff (backend_pid)
pg_logger
deprecated; use redirect_stderr (BTW, is it default on win32 now?)
pgcrypto
misses -lws2_32. According to README, it needs some tuning concerning
random() before deploying.
Regards,
Andreas
Index: cube.c
===
RCS file: /projects/cvsroot/pgsql-server/contrib/cube/cube.c,v
retrieving revision 1.16
diff -u -r1.16 cube.c
--- cube.c 29 Aug 2004 05:06:34 - 1.16
+++ cube.c 8 Sep 2004 17:45:32 -
@@ -15,8 +15,12 @@
#include "cubedata.h"
+#ifndef max
#define max(a,b) ((a) > (b) ? (a) : (b))
+#endif
+#ifndef min
#define min(a,b) ((a) <= (b) ? (a) : (b))
+#endif
#define abs(a) ((a) < (0) ? (-a) : (a))
extern int cube_yyparse();
Index: cubeparse.y
===
RCS file: /projects/cvsroot/pgsql-server/contrib/cube/cubeparse.y,v
retrieving revision 1.11
diff -u -r1.11 cubeparse.y
--- cubeparse.y 2 Sep 2004 20:53:42 - 1.11
+++ cubeparse.y 8 Sep 2004 17:45:43 -
@@ -28,7 +28,7 @@
%}
/* BISON Declarations */
-%token FLOAT O_PAREN C_PAREN O_BRACKET C_BRACKET COMMA
+%token CUBEFLOAT O_PAREN C_PAREN O_BRACKET C_BRACKET COMMA
%start box
/* Grammar follows */
@@ -128,13 +128,13 @@
;
list:
- FLOAT {
+ CUBEFLOAT {
/* alloc enough space to be sure whole list will fit */
$$ = palloc(scanbuflen + 1);
strcpy($$, $1);
}
|
- list COMMA FLOAT {
+ list COMMA CUBEFLOAT {
$$ = $1;
strcat($$, ",");
strcat($$, $3);
Index: cubescan.l
===
RCS file: /projects/cvsroot/pgsql-server/contrib/cube/cubescan.l,v
retrieving revision 1.8
diff -u -r1.8 cubescan.l
--- cubescan.l 24 Feb 2004 22:06:32 - 1.8
+++ cubescan.l 8 Sep 2004 17:45:50 -
@@ -39,7 +39,7 @@
%%
-{float} yylval = yytext; return FLOAT;
+{float} yylval = yytext; return CUBEFLOAT;
\[ yylval = "("; return O_BRACKET;
\] yylval = ")"; return C_BRACKET;
\( yylval = "("; return O_PAREN;
Index: seg.c
===
RCS file: /projects/cvsroot/pgsql-server/contrib/seg/seg.c,v
retrieving revision 1.10
diff -u -r1.10 seg.c
--- seg.c 29 Aug 2004 05:06:38 - 1.10
+++ seg.c 8 Sep 2004 17:58:00 -
@@ -14,8 +14,12 @@
#include "segdata.h"
+#ifndef max
#define max(a,b) ((a) > (b) ? (a) : (b))
+#endif
+#ifndef min
#define min(a,b) ((a) <= (b) ? (a) : (b))
+#endif
#define abs(a) ((a) < (0) ? (-a) : (a))
/*
@@ -946,7 +950,7 @@
if (exp == 0)
{
/* use the supplied mantyssa with sign */
- strcpy((char *) index(result, 'e'), "");
+ strcpy((char *) strchr(result, 'e'), "");
}
else
{
Index: segscan.l
===
RCS file: /projects/cvsroot/pgsql-server/contrib/seg/segscan.l,v
retrieving revision 1.7
diff -u -r1.7 segscan.l
--- segscan.l 24 Feb 2004 22:06:32 - 1.7
+++ segscan.l 8 Sep 2004 17:58:20 -
@@ -41,7 +41,7 @@
{range} yylval.text = yytext; return RANGE;
{plumin} yylval.text = yytext; return PLUMIN;
-{float} yylval.text = yytext; return FLOAT;
+{float} yylval.text = yytext; return SEGFLOAT;
\< yylval.text = "<"; return EXTENSION;
\> yylval.text = ">"; return EXTENSION;
\~ yylval.text = "~"; return EXTENSION;
Index: segparse.y
===
RCS file: /projects/cvsroot/pgsql-server/contrib/seg/segparse.y,v
retrieving revision 1.12
diff -u -r1.12 segparse.y
--- segparse.y 2 Sep 2004 20:53:42 - 1.12
+++ segparse.y 8 Sep 2004 17:59:28 -
@@ -38,7 +38,7 @@
} bnd;
char * text;
}
-%token FLOAT
+%token SEGFLOAT
%token RANGE
%token PLUMIN
%token EXTENSION
@@ -105,13 +105,13 @@
;
boundary:
- FLOAT {
+ SEGFLOAT {
$$.ext = '\0';
$$.sigd = significant_digits($1);
$$.val = seg_atof($1);
}
|
- EXTENSION FLOAT {
+ EXTENSION SEGFLOAT {
$$.ext = $1[0];
$$.sigd = significant_digits($2);
$$.val = seg_atof($2);
@@ -119,7 +119,7 @@
;
deviation:
- FLOAT {
+ SEGFLOAT {
$$.ext = '\0';
$$.sigd = significant_digits($1);
$$.val = seg_atof($1);
* CVS exited normally with code 1 *
---(end of broadcast)---
TIP 7: don't forget to increase your free space map settings
Re: [PATCHES] [pgsql-hackers-win32] Contrib modules on Win32
> -Original Message- > From: Andreas Pflug [mailto:[EMAIL PROTECTED] > Sent: 08 September 2004 19:15 > To: Dave Page > Cc: PgSQL Win32 developers; PostgreSQL Patches > Subject: Re: [pgsql-hackers-win32] Contrib modules on Win32 > > Dave Page wrote: > > > > cube > > seg > > patch attached. Compiles, but not tested. > > > miscutil > Needs review; includes some deprecated stuff (backend_pid) > > > pg_logger > deprecated; use redirect_stderr (BTW, is it default on win32 now?) Yes, it's the default on Win32 (installer releases anyhoo). I take it this should be removed from /contrib then. > > pgcrypto > misses -lws2_32. According to README, it needs some tuning concerning > random() before deploying. I must have missed that - I've been using it in production on Linux for years... Regards, Dave. ---(end of broadcast)--- TIP 1: subscribe and unsubscribe commands go to [EMAIL PROTECTED]
Re: [PATCHES] [pgsql-hackers-win32] Contrib modules on Win32
Win32 compile fixes for pgbench, pgcrypto, and tsearch. Note: pgbench is the only one I actually use, and hence have tested Cheers, Claudio --- Certain disclaimers and policies apply to all email sent from Memetrics. For the full text of these disclaimers and policies see http://www.memetrics.com/emailpolicy.html";>http://www.memetrics.com/em ailpolicy.html diff.patch Description: Binary data ---(end of broadcast)--- TIP 4: Don't 'kill -9' the postmaster
Re: [PATCHES] [pgsql-hackers-win32] Contrib modules on Win32
Win32 compile fix for misc_utils. Note: As before, un-tested. --- Certain disclaimers and policies apply to all email sent from Memetrics. For the full text of these disclaimers and policies see http://www.memetrics.com/emailpolicy.html";>http://www.memetrics.com/em ailpolicy.html misc_utils.patch Description: Binary data ---(end of broadcast)--- TIP 2: you can get off all lists at once with the unregister command (send "unregister YourEmailAddressHere" to [EMAIL PROTECTED])
Re: [PATCHES] [pgsql-hackers-win32] Contrib modules on Win32
Removal of pg_logger. Your patch has been added to the PostgreSQL unapplied patches list at: http://momjian.postgresql.org/cgi-bin/pgpatches It will be applied as soon as one of the PostgreSQL committers reviews and approves it. --- Dave Page wrote: > > > > -Original Message- > > From: Andreas Pflug [mailto:[EMAIL PROTECTED] > > Sent: 08 September 2004 19:15 > > To: Dave Page > > Cc: PgSQL Win32 developers; PostgreSQL Patches > > Subject: Re: [pgsql-hackers-win32] Contrib modules on Win32 > > > > Dave Page wrote: > > > > > > cube > > > seg > > > > patch attached. Compiles, but not tested. > > > > > miscutil > > Needs review; includes some deprecated stuff (backend_pid) > > > > > pg_logger > > deprecated; use redirect_stderr (BTW, is it default on win32 now?) > > Yes, it's the default on Win32 (installer releases anyhoo). I take it > this should be removed from /contrib then. > > > > pgcrypto > > misses -lws2_32. According to README, it needs some tuning concerning > > random() before deploying. > > I must have missed that - I've been using it in production on Linux for > years... > > Regards, Dave. > > ---(end of broadcast)--- > TIP 5: Have you checked our extensive FAQ? > >http://www.postgresql.org/docs/faqs/FAQ.html > -- Bruce Momjian| http://candle.pha.pa.us [EMAIL PROTECTED] | (610) 359-1001 + If your life is a hard drive, | 13 Roberts Road + Christ can be your backup.| Newtown Square, Pennsylvania 19073 ---(end of broadcast)--- TIP 8: explain analyze is your friend
Re: [PATCHES] [pgsql-hackers-win32] Contrib modules on Win32
Your patch has been added to the PostgreSQL unapplied patches list at: http://momjian.postgresql.org/cgi-bin/pgpatches It will be applied as soon as one of the PostgreSQL committers reviews and approves it. --- Claudio Natoli wrote: > > Win32 compile fix for misc_utils. > > Note: As before, un-tested. > > --- > Certain disclaimers and policies apply to all email sent from Memetrics. > For the full text of these disclaimers and policies see > href="http://www.memetrics.com/emailpolicy.html";>http://www.memetrics.com/em > ailpolicy.html > > [ Attachment, skipping... ] > > ---(end of broadcast)--- > TIP 3: if posting/reading through Usenet, please send an appropriate > subscribe-nomail command to [EMAIL PROTECTED] so that your > message can get through to the mailing list cleanly -- Bruce Momjian| http://candle.pha.pa.us [EMAIL PROTECTED] | (610) 359-1001 + If your life is a hard drive, | 13 Roberts Road + Christ can be your backup.| Newtown Square, Pennsylvania 19073 ---(end of broadcast)--- TIP 9: the planner will ignore your desire to choose an index scan if your joining column's datatypes do not match
Re: [PATCHES] [pgsql-hackers-win32] Contrib modules on Win32
Claudio Natoli <[EMAIL PROTECTED]> writes: > Win32 compile fixes for pgbench, pgcrypto, and tsearch. Applied, thanks. regards, tom lane ---(end of broadcast)--- TIP 7: don't forget to increase your free space map settings
Re: [PATCHES] [pgsql-hackers-win32] Contrib modules on Win32
Claudio Natoli <[EMAIL PROTECTED]> writes: > Win32 compile fix for misc_utils. Applied. regards, tom lane ---(end of broadcast)--- TIP 2: you can get off all lists at once with the unregister command (send "unregister YourEmailAddressHere" to [EMAIL PROTECTED])
Re: [PATCHES] [pgsql-hackers-win32] Contrib modules on Win32
Andreas Pflug <[EMAIL PROTECTED]> writes: >> cube >> seg > patch attached. Compiles, but not tested. Applied, thanks. (The modules still pass their regression tests on Unix, FWIW.) regards, tom lane ---(end of broadcast)--- TIP 7: don't forget to increase your free space map settings
Re: [PATCHES] [pgsql-hackers-win32] Contrib modules on Win32
Pg_logger removed by Tom. --- Dave Page wrote: > > > > -Original Message- > > From: Andreas Pflug [mailto:[EMAIL PROTECTED] > > Sent: 08 September 2004 19:15 > > To: Dave Page > > Cc: PgSQL Win32 developers; PostgreSQL Patches > > Subject: Re: [pgsql-hackers-win32] Contrib modules on Win32 > > > > Dave Page wrote: > > > > > > cube > > > seg > > > > patch attached. Compiles, but not tested. > > > > > miscutil > > Needs review; includes some deprecated stuff (backend_pid) > > > > > pg_logger > > deprecated; use redirect_stderr (BTW, is it default on win32 now?) > > Yes, it's the default on Win32 (installer releases anyhoo). I take it > this should be removed from /contrib then. > > > > pgcrypto > > misses -lws2_32. According to README, it needs some tuning concerning > > random() before deploying. > > I must have missed that - I've been using it in production on Linux for > years... > > Regards, Dave. > > ---(end of broadcast)--- > TIP 5: Have you checked our extensive FAQ? > >http://www.postgresql.org/docs/faqs/FAQ.html > -- Bruce Momjian| http://candle.pha.pa.us [EMAIL PROTECTED] | (610) 359-1001 + If your life is a hard drive, | 13 Roberts Road + Christ can be your backup.| Newtown Square, Pennsylvania 19073 ---(end of broadcast)--- TIP 1: subscribe and unsubscribe commands go to [EMAIL PROTECTED]
