Re: [PATCHES] Further patch for VS2005
Patch applied. Thanks. --- Magnus Hagander wrote: > Hi! > > Attached patch is required ot build with the CRT that comes with Visual > Studio 2005. Basically MS defined errcode in the headers with a typedef, > so we have to #define it out of the way. > > While at it, fix a function declaration in plpython that didn't match > the implementation (volatile missing). > > //Magnus > Content-Description: vc.patch [ Attachment, skipping... ] > > ---(end of broadcast)--- > TIP 1: if posting/reading through Usenet, please send an appropriate >subscribe-nomail command to [EMAIL PROTECTED] so that your >message can get through to the mailing list cleanly -- Bruce Momjian [EMAIL PROTECTED] EnterpriseDBhttp://www.enterprisedb.com + If your life is a hard drive, Christ can be your backup. + ---(end of broadcast)--- TIP 4: Have you searched our list archives? http://archives.postgresql.org
Re: [PATCHES] Further patch for VS2005
> > *** src/pl/plpython/plpython.c 25 Jun 2006 00:18:24 > - 1.83 > > --- src/pl/plpython/plpython.c 26 Jun 2006 13:58:56 - > > *** > > *** 10,16 > > --- 10,19 > > /* Python uses #pragma to bring in a non-default > libpython on VC++ if > >* _DEBUG is defined */ > > #undef _DEBUG > > + /* Also hide away errcode, since we load Python.h before > postgres.h > > + */ #define errcode __vc_errcode > > #include > > + #undef errcode > > #define _DEBUG > > #else > > #include > > BTW, it strikes me as a fairly bad idea to be including > first; that goes directly against the conventions > we established to be sure that largefile support doesn't > break. Has anyone looked into making plpython.c conform to > project standards by including postgres.h first? Not me. Last time I did something like that it came back and bit me because apparantly python does things significantly different on different platforms. Now that we have the buildfarm it might be worth a try. I don't have a *nix box around with python ATM, but if nobody beats me to it I can try it later... //Magnus ---(end of broadcast)--- TIP 3: Have you checked our extensive FAQ? http://www.postgresql.org/docs/faq
Re: [PATCHES] Further patch for VS2005
"Magnus Hagander" <[EMAIL PROTECTED]> writes: > *** src/pl/plpython/plpython.c25 Jun 2006 00:18:24 - 1.83 > --- src/pl/plpython/plpython.c26 Jun 2006 13:58:56 - > *** > *** 10,16 > --- 10,19 > /* Python uses #pragma to bring in a non-default libpython on VC++ if >* _DEBUG is defined */ > #undef _DEBUG > + /* Also hide away errcode, since we load Python.h before postgres.h */ > + #define errcode __vc_errcode > #include > + #undef errcode > #define _DEBUG > #else > #include BTW, it strikes me as a fairly bad idea to be including first; that goes directly against the conventions we established to be sure that largefile support doesn't break. Has anyone looked into making plpython.c conform to project standards by including postgres.h first? regards, tom lane ---(end of broadcast)--- TIP 9: In versions below 8.0, the planner will ignore your desire to choose an index scan if your joining column's datatypes do not match
[PATCHES] Further patch for VS2005
Hi! Attached patch is required ot build with the CRT that comes with Visual Studio 2005. Basically MS defined errcode in the headers with a typedef, so we have to #define it out of the way. While at it, fix a function declaration in plpython that didn't match the implementation (volatile missing). //Magnus vc.patch Description: vc.patch ---(end of broadcast)--- TIP 1: if posting/reading through Usenet, please send an appropriate subscribe-nomail command to [EMAIL PROTECTED] so that your message can get through to the mailing list cleanly
