Hi,
i found out that the function textToQualifiedNameList doesn't use the
second argument it receive (caller). i suppose in the past was used
and now it is useless, if that is the case here is a patch removing.
Or are any reasons to keep that argument?
--
regards,
Jaime Casanova
(DBA: DataBase Aniquilator ;)
diff -cr pgsql_head/contrib/dblink/dblink.c pgsql_args/contrib/dblink/dblink.c
*** pgsql_head/contrib/dblink/dblink.c 2005-05-25 22:14:11.0 -0500
--- pgsql_args/contrib/dblink/dblink.c 2005-05-25 22:21:39.0 -0500
***
*** 1971,1977
Relationrel;
Oid relid;
! relvar = makeRangeVarFromNameList(textToQualifiedNameList(relname_text,
get_relid_from_relname));
rel = heap_openrv(relvar, AccessShareLock);
relid = RelationGetRelid(rel);
relation_close(rel, AccessShareLock);
--- 1971,1977
Relationrel;
Oid relid;
! relvar =
makeRangeVarFromNameList(textToQualifiedNameList(relname_text));
rel = heap_openrv(relvar, AccessShareLock);
relid = RelationGetRelid(rel);
relation_close(rel, AccessShareLock);
diff -cr pgsql_head/contrib/dbsize/dbsize.c pgsql_args/contrib/dbsize/dbsize.c
*** pgsql_head/contrib/dbsize/dbsize.c 2005-05-25 22:14:12.0 -0500
--- pgsql_args/contrib/dbsize/dbsize.c 2005-05-25 22:22:15.0 -0500
***
*** 290,297
Oid relnodeOid;
Oid tblspcOid;
! relrv = makeRangeVarFromNameList(textToQualifiedNameList(relname,
!
relation_size));
relation = relation_openrv(relrv, AccessShareLock);
tblspcOid = relation-rd_rel-reltablespace;
--- 290,296
Oid relnodeOid;
Oid tblspcOid;
! relrv = makeRangeVarFromNameList(textToQualifiedNameList(relname));
relation = relation_openrv(relrv, AccessShareLock);
tblspcOid = relation-rd_rel-reltablespace;
diff -cr pgsql_head/contrib/pgstattuple/pgstattuple.c
pgsql_args/contrib/pgstattuple/pgstattuple.c
*** pgsql_head/contrib/pgstattuple/pgstattuple.c2005-05-25
22:14:13.0 -0500
--- pgsql_args/contrib/pgstattuple/pgstattuple.c2005-05-25
22:22:54.0 -0500
***
*** 63,70
Datum result;
/* open relation */
! relrv = makeRangeVarFromNameList(textToQualifiedNameList(relname,
!
pgstattuple));
rel = heap_openrv(relrv, AccessShareLock);
result = pgstattuple_real(rel);
--- 63,69
Datum result;
/* open relation */
! relrv = makeRangeVarFromNameList(textToQualifiedNameList(relname));
rel = heap_openrv(relrv, AccessShareLock);
result = pgstattuple_real(rel);
diff -cr pgsql_head/src/backend/catalog/pg_conversion.c
pgsql_args/src/backend/catalog/pg_conversion.c
*** pgsql_head/src/backend/catalog/pg_conversion.c 2005-05-25
22:17:33.0 -0500
--- pgsql_args/src/backend/catalog/pg_conversion.c 2005-05-25
22:24:10.0 -0500
***
*** 298,304
*(str + len) = '\0';
/* Look up the conversion name */
! parsed_name = textToQualifiedNameList(conv_name, convert_using);
convoid = FindConversionByName(parsed_name);
if (!OidIsValid(convoid))
ereport(ERROR,
--- 298,304
*(str + len) = '\0';
/* Look up the conversion name */
! parsed_name = textToQualifiedNameList(conv_name);
convoid = FindConversionByName(parsed_name);
if (!OidIsValid(convoid))
ereport(ERROR,
diff -cr pgsql_head/src/backend/commands/sequence.c
pgsql_args/src/backend/commands/sequence.c
*** pgsql_head/src/backend/commands/sequence.c 2005-05-25 22:17:34.0
-0500
--- pgsql_args/src/backend/commands/sequence.c 2005-05-25 22:26:35.0
-0500
***
*** 387,394
rescnt = 0;
boollogit = false;
! sequence = makeRangeVarFromNameList(textToQualifiedNameList(seqin,
!
nextval));
/* open and AccessShareLock sequence */
init_sequence(sequence, elm, seqrel);
--- 387,393
rescnt = 0;
boollogit = false;
! sequence = makeRangeVarFromNameList(textToQualifiedNameList(seqin));
/* open and AccessShareLock sequence */
init_sequence(sequence, elm, seqrel);
***
*** 579,586
Relationseqrel;
int64 result;
!
