[PATCHES] gendef fixes
Attached patch fixes two problems: 1) gendef works from inside visual studio - use a tempfile instead of redirection, because for some reason you can't redirect dumpbin from inside (patch from Joachim Wieland) 2) gendef must process only *.obj, or you get weird errors in some build scenarios when it tries to process a logfile //Magnus Index: src/tools/msvc/gendef.pl === RCS file: /projects/cvsroot/pgsql/src/tools/msvc/gendef.pl,v retrieving revision 1.2 diff -c -r1.2 gendef.pl *** src/tools/msvc/gendef.pl22 Oct 2006 17:17:08 - 1.2 --- src/tools/msvc/gendef.pl9 Jan 2007 10:12:59 - *** *** 10,18 print Generating $defname.DEF from directory $ARGV[0]\n; ! while ($ARGV[0]/*) { print .; ! open(F,dumpbin /symbols $_|) || die Could not open $_\n; while (F) { s/\(\)//g; next unless /^\d/; --- 10,19 print Generating $defname.DEF from directory $ARGV[0]\n; ! while ($ARGV[0]/*.obj) { print .; ! system(dumpbin /symbols /out:symbols.out $_ NUL) die Could not call dumpbin; ! open(F, symbols.out) || die Could not open symbols.out for $_\n; while (F) { s/\(\)//g; next unless /^\d/; *** *** 31,36 --- 32,38 push @def, $pieces[6]; } close(F); + unlink(symbols.out); } print \n; ---(end of broadcast)--- TIP 5: don't forget to increase your free space map settings
Re: [PATCHES] gendef fixes
Your patch has been added to the PostgreSQL unapplied patches list at: http://momjian.postgresql.org/cgi-bin/pgpatches It will be applied as soon as one of the PostgreSQL committers reviews and approves it. --- Magnus Hagander wrote: Attached patch fixes two problems: 1) gendef works from inside visual studio - use a tempfile instead of redirection, because for some reason you can't redirect dumpbin from inside (patch from Joachim Wieland) 2) gendef must process only *.obj, or you get weird errors in some build scenarios when it tries to process a logfile //Magnus [ Attachment, skipping... ] ---(end of broadcast)--- TIP 5: don't forget to increase your free space map settings -- Bruce Momjian [EMAIL PROTECTED] EnterpriseDBhttp://www.enterprisedb.com + If your life is a hard drive, Christ can be your backup. + ---(end of broadcast)--- TIP 9: In versions below 8.0, the planner will ignore your desire to choose an index scan if your joining column's datatypes do not match
Re: [PATCHES] gendef fixes
On Tue, 2007-01-09 at 12:29 +0100, Magnus Hagander wrote: Attached patch fixes two problems: Applied, thanks. -Neil ---(end of broadcast)--- TIP 1: if posting/reading through Usenet, please send an appropriate subscribe-nomail command to [EMAIL PROTECTED] so that your message can get through to the mailing list cleanly