Re: [PATCHES] high values for client_min_messages

[Bruce Momjian]

Patch applied.  Thanks.

---


Kris Jurka wrote:
> 
> The patch updates the documentation to reflect the fact that higher values 
> of client_min_messages (fatal + panic) are valid and also fixes a slight 
> issue with how psql tried to display error messages that aren't sent to 
> the client.
> 
> We often tell people to ignore errors in response to requests for things 
> like "drop if exists", but there's no good way to completely hide this 
> without upping client_min_messages past ERROR.  When running a file like
> 
> SET client_min_messages TO 'FATAL';
> 
> DROP TABLE doesntexist;
> 
> with "psql -f filename" you get an error prefix of 
> "psql:/home/username/filename:3" even though there is no error message to 
> prefix because it isn't sent to the client.
> 
> Kris Jurka

Content-Description: 

[ Attachment, skipping... ]

> 
> ---(end of broadcast)---
> TIP 9: In versions below 8.0, the planner will ignore your desire to
>choose an index scan if your joining column's datatypes do not
>match

-- 
  Bruce Momjian|  http://candle.pha.pa.us
  pgman@candle.pha.pa.us   |  (610) 359-1001
  +  If your life is a hard drive, |  13 Roberts Road
  +  Christ can be your backup.|  Newtown Square, Pennsylvania 19073

---(end of broadcast)---
TIP 9: In versions below 8.0, the planner will ignore your desire to
   choose an index scan if your joining column's datatypes do not
   match

[PATCHES] high values for client_min_messages

[Kris Jurka]

The patch updates the documentation to reflect the fact that higher values 
of client_min_messages (fatal + panic) are valid and also fixes a slight 
issue with how psql tried to display error messages that aren't sent to 
the client.


We often tell people to ignore errors in response to requests for things 
like "drop if exists", but there's no good way to completely hide this 
without upping client_min_messages past ERROR.  When running a file like


SET client_min_messages TO 'FATAL';

DROP TABLE doesntexist;

with "psql -f filename" you get an error prefix of 
"psql:/home/username/filename:3" even though there is no error message to 
prefix because it isn't sent to the client.


Kris JurkaIndex: doc/src/sgml/config.sgml
===
RCS file: /projects/cvsroot/pgsql/doc/src/sgml/config.sgml,v
retrieving revision 1.23
diff -c -r1.23 config.sgml
*** doc/src/sgml/config.sgml24 Sep 2005 23:25:31 -  1.23
--- doc/src/sgml/config.sgml28 Sep 2005 01:03:14 -
***
*** 2295,2301 
  Valid values are DEBUG5,
  DEBUG4, DEBUG3, DEBUG2,
  DEBUG1, LOG, NOTICE,
! WARNING, and ERROR.  Each level
  includes all the levels that follow it.  The later the level,
  the fewer messages are sent.  The default is
  NOTICE.  Note that LOG has a different
--- 2295,2302 
  Valid values are DEBUG5,
  DEBUG4, DEBUG3, DEBUG2,
  DEBUG1, LOG, NOTICE,
! WARNING, ERROR, FATAL,
! and PANIC.  Each level
  includes all the levels that follow it.  The later the level,
  the fewer messages are sent.  The default is
  NOTICE.  Note that LOG has a different
Index: src/bin/psql/common.c
===
RCS file: /projects/cvsroot/pgsql/src/bin/psql/common.c,v
retrieving revision 1.105
diff -c -r1.105 common.c
*** src/bin/psql/common.c   20 Sep 2005 21:43:08 -  1.105
--- src/bin/psql/common.c   28 Sep 2005 01:03:14 -
***
*** 681,687 
  
if (!OK)
{
!   psql_error("%s", PQerrorMessage(pset.db));
ReportSyntaxErrorPosition(result, query);
CheckConnection();
}
--- 681,690 
  
if (!OK)
{
!   const char *error = PQerrorMessage(pset.db);
!   if (strlen(error))
!   psql_error("%s", error);
! 
ReportSyntaxErrorPosition(result, query);
CheckConnection();
}

---(end of broadcast)---
TIP 9: In versions below 8.0, the planner will ignore your desire to
   choose an index scan if your joining column's datatypes do not
   match