Re: [PATCHES] pg_autovacuum vacuum cost variables patch v2

2004-11-17 Thread Tom Lane 
Matthew T. O'Connor [EMAIL PROTECTED] writes:
 Ok, here is an updated version of the patch I submitted last night.  
 This patch now sets the appropriate vacuum cost variables for both 
 vacuum commands and analyze commands.   In addition I have added the new 
 vacuum cost options to the win32 InstallService function.

Applied with minor corrections.

regards, tom lane

---(end of broadcast)---
TIP 5: Have you checked our extensive FAQ?

   http://www.postgresql.org/docs/faqs/FAQ.html

Re: [PATCHES] pg_autovacuum vacuum cost variables patch v2

2004-10-29 Thread Matthew T. O'Connor 
Tom Lane wrote:
Matthew T. O'Connor [EMAIL PROTECTED] writes:
 

+ 	if(operation == VACUUM_ANALYZE)
+ 		update_table_thresholds(dbi, tbl, VACUUM_ANALYZE);
+ 	else if(operation == VACUUM_ANALYZE)
+ 		update_table_thresholds(dbi, tbl, ANALYZE_ONLY);
   

Surely that's not right ... are there any third cases here?  Why
not just a one-liner
	update_table_thresholds(dbi, tbl, operation);
 

Whoops  I think that was both a thinko and a typeo :-)  Yes your one 
line will work much better.  I'll submit another patch in a few days, 
unless someone beats me to it.

Thanks for fixing that.
Matthew
---(end of broadcast)---
TIP 8: explain analyze is your friend

Re: [PATCHES] pg_autovacuum vacuum cost variables patch v2

2004-10-28 Thread Tom Lane 
Matthew T. O'Connor [EMAIL PROTECTED] writes:
 + if(operation == VACUUM_ANALYZE)
 + update_table_thresholds(dbi, tbl, VACUUM_ANALYZE);
 + else if(operation == VACUUM_ANALYZE)
 + update_table_thresholds(dbi, tbl, ANALYZE_ONLY);

Surely that's not right ... are there any third cases here?  Why
not just a one-liner
update_table_thresholds(dbi, tbl, operation);

regards, tom lane

---(end of broadcast)---
TIP 8: explain analyze is your friend