Re: [PATCHES] ecpg DllMain fix
On Wed, Oct 03, 2007 at 03:22:12PM +0200, Michael Meskes wrote: > On Wed, Oct 03, 2007 at 02:27:20PM +0200, Magnus Hagander wrote: > > However, shouldn't we be doing it for other ECPG libraries as well? > > Done. Added to MSVC build. //Magnus ---(end of broadcast)--- TIP 7: You can help support the PostgreSQL project by donating at http://www.postgresql.org/about/donate
Re: [PATCHES] ecpg DllMain fix
On Wed, Oct 03, 2007 at 02:27:20PM +0200, Magnus Hagander wrote: > However, shouldn't we be doing it for other ECPG libraries as well? Done. Michael -- Michael Meskes Email: Michael at Fam-Meskes dot De, Michael at Meskes dot (De|Com|Net|Org) ICQ: 179140304, AIM/Yahoo: michaelmeskes, Jabber: [EMAIL PROTECTED] Go SF 49ers! Go Rhein Fire! Use Debian GNU/Linux! Use PostgreSQL! ---(end of broadcast)--- TIP 4: Have you searched our list archives? http://archives.postgresql.org
Re: [PATCHES] ecpg DllMain fix
On Wed, Oct 03, 2007 at 01:13:58PM +0200, Michael Meskes wrote: > Just committed. I also renamed the functions that are not exported to > make this job easier. Should there be a problem with this it should only > be a missed rename. However the new sources successfully run through the > regression suite on my Linux system with and without multithreading. > > As for the export list I copied the stuff from libpq, it's untested on > all other archs. I've update the msvc build to deal with this, and it works. However, shouldn't we be doing it for other ECPG libraries as well? //Magnus ---(end of broadcast)--- TIP 4: Have you searched our list archives? http://archives.postgresql.org
Re: [PATCHES] ecpg DllMain fix
On Wed, Oct 03, 2007 at 01:13:58PM +0200, Michael Meskes wrote: > On Wed, Oct 03, 2007 at 12:22:41PM +0200, Magnus Hagander wrote: > > It passes compile. Rebuilding my full tree now to try to work on making the > > regression tests actually be able to test it. > > Sounds good. :-) At least we're proceeding. Going further, all the new threading tests fail on msvc. Haven't investigated why yet, but will do. > > > I'm working on an export list atm. > > > > Good. I think we want that regardless of things being fixed by removing > > Dllmain. > > Just committed. I also renamed the functions that are not exported to > make this job easier. Should there be a problem with this it should only > be a missed rename. However the new sources successfully run through the > regression suite on my Linux system with and without multithreading. > > As for the export list I copied the stuff from libpq, it's untested on > all other archs. Ok. I'll take a look at that on msvc when I'm done with the reg tests, but I'll try to get those running first. //Magnus ---(end of broadcast)--- TIP 5: don't forget to increase your free space map settings
Re: [PATCHES] ecpg DllMain fix
On Wed, Oct 03, 2007 at 12:22:41PM +0200, Magnus Hagander wrote: > It passes compile. Rebuilding my full tree now to try to work on making the > regression tests actually be able to test it. Sounds good. :-) > > I'm working on an export list atm. > > Good. I think we want that regardless of things being fixed by removing > Dllmain. Just committed. I also renamed the functions that are not exported to make this job easier. Should there be a problem with this it should only be a missed rename. However the new sources successfully run through the regression suite on my Linux system with and without multithreading. As for the export list I copied the stuff from libpq, it's untested on all other archs. Michael -- Michael Meskes Email: Michael at Fam-Meskes dot De, Michael at Meskes dot (De|Com|Net|Org) ICQ: 179140304, AIM/Yahoo: michaelmeskes, Jabber: [EMAIL PROTECTED] Go SF 49ers! Go Rhein Fire! Use Debian GNU/Linux! Use PostgreSQL! ---(end of broadcast)--- TIP 4: Have you searched our list archives? http://archives.postgresql.org
Re: [PATCHES] ecpg DllMain fix
On Wed, Oct 03, 2007 at 12:19:14PM +0200, Michael Meskes wrote: > On Wed, Oct 03, 2007 at 11:13:27AM +0200, Magnus Hagander wrote: > > Heh, I was about to review that. I'll try to get to it right after lunch. > > Thanks and sorry for jumping the gun. If it doesn't work we can remove > it easily. Np. It passes compile. Rebuilding my full tree now to try to work on making the regression tests actually be able to test it. > I'm working on an export list atm. Good. I think we want that regardless of things being fixed by removing Dllmain. //Magnus ---(end of broadcast)--- TIP 7: You can help support the PostgreSQL project by donating at http://www.postgresql.org/about/donate
Re: [PATCHES] ecpg DllMain fix
On Wed, Oct 03, 2007 at 11:13:27AM +0200, Magnus Hagander wrote: > Heh, I was about to review that. I'll try to get to it right after lunch. Thanks and sorry for jumping the gun. If it doesn't work we can remove it easily. I'm working on an export list atm. Michael -- Michael Meskes Email: Michael at Fam-Meskes dot De, Michael at Meskes dot (De|Com|Net|Org) ICQ: 179140304, AIM/Yahoo: michaelmeskes, Jabber: [EMAIL PROTECTED] Go SF 49ers! Go Rhein Fire! Use Debian GNU/Linux! Use PostgreSQL! ---(end of broadcast)--- TIP 2: Don't 'kill -9' the postmaster
Re: [PATCHES] ecpg DllMain fix
On Wed, Oct 03, 2007 at 10:58:18AM +0200, Michael Meskes wrote: > On Wed, Oct 03, 2007 at 11:54:44AM +0900, ITAGAKI Takahiro wrote: > > Here is a patch to remove DllMain from libecpg on Win32 build. > > I brought the initialization routine from libpq and implemented > > pthread_once() using a lock that serializes all pthread_once calls. > > I don't have msvc build environment, but I hope it will fix the > > build failure on it. > > We will see. Since it doesn't break my linux system I committed the > patch. If anyone notices a problem please tell me. Heh, I was about to review that. I'll try to get to it right after lunch. //Magnus ---(end of broadcast)--- TIP 3: Have you checked our extensive FAQ? http://www.postgresql.org/docs/faq
Re: [PATCHES] ecpg DllMain fix
On Wed, Oct 03, 2007 at 11:54:44AM +0900, ITAGAKI Takahiro wrote: > Here is a patch to remove DllMain from libecpg on Win32 build. > I brought the initialization routine from libpq and implemented > pthread_once() using a lock that serializes all pthread_once calls. > I don't have msvc build environment, but I hope it will fix the > build failure on it. We will see. Since it doesn't break my linux system I committed the patch. If anyone notices a problem please tell me. Michael -- Michael Meskes Email: Michael at Fam-Meskes dot De, Michael at Meskes dot (De|Com|Net|Org) ICQ: 179140304, AIM/Yahoo: michaelmeskes, Jabber: [EMAIL PROTECTED] Go SF 49ers! Go Rhein Fire! Use Debian GNU/Linux! Use PostgreSQL! ---(end of broadcast)--- TIP 4: Have you searched our list archives? http://archives.postgresql.org
