Re: [Pharo-dev] [PROPOSAL] Put the WorldMenu in a Menu bar

2018-06-02 Thread Peter Uhnák
>  I believe we should move to Commander with first class commands.

How would that work when menu entries can be generated dynamically?

Peter

On Sat, Jun 2, 2018 at 1:32 PM, H. Hirzel  wrote:

> On 6/1/18, Torsten Bergmann  wrote:
> >
> >>Guille & Cyril wrote>
> >> > Since some decades now the default way to display a menu in
> >> > applications
> >> > is to have a bar at the top of the windows.
> >
> >
> > Alistair wrote
> >>> Instead of a menu bar at the top, which takes quite a bit of space,
> >>> and as mentioned may not fit on a small screen how about a "Start"
> >>button in the task-bar that pops up the menu a-la Windows
> >
> >
> > So this basically reduces to the two UI options:
> >
> >  1. Should Pharo look like an application (and have the menu at the top)
> >
> >  2. Should Pharo look like an OS itself (with a primary "Start" menu in
> the
> > taskbar as on Windows)
> >
> > Maybe we should support both styles using a setting.
> >
> > Bye
> > T.
> +1
> >
>
>


[Pharo-dev] memory leak

2018-06-02 Thread John Brant
On 05/26/2018 05:21 AM, Tudor Girba wrote:
> Yes, Glamour is stable since years. Yes, we did have some leak issues that 
> appeared along the way. Last year, we discovered that a memory leak came from 
> Rubric (specifically there was a global variable in it). People saw 
> inspectors laying around, so naturally, the issue was seen as being due to 
> GT. And now there is another one, which is still under investigation. For me, 
> the main issue is not the memory leak, but the fact that we have no tool to 
> reason about them.

I found a memory leak in GLMHintableActionButtonBrick. It has an
asyncTask class instance variable that holds a GLMAsyncTask. After
running for a while -- opening and closing inspectors and other tools, I
closed several windows, did a GC and expected to not have any AST nodes
hanging around. However, I found several, so I used my ReferenceFinder
tool to find a reference path. That path went through the
GLMHintableActionButtonBrick to a GLMAsyncTask to a block that holds a
reference to a GLMHintableActionButtonBrick instance. Following
references out of the GLMHintableActionButtonBrick instance eventually
leads to a NodeMorph which has a NodeModel that contained my AST node.

I'm running a Pharo 7 build from a few weeks ago
(Pharo-7.0+alpha.build.843.sha.edceb623c1a3ac3358f7e46ca1048d455657e10c)
so this may have been fixed.


John Brant



Re: [Pharo-dev] [PROPOSAL] Put the WorldMenu in a Menu bar

2018-06-02 Thread H. Hirzel
On 6/1/18, Torsten Bergmann  wrote:
>
>>Guille & Cyril wrote>
>> > Since some decades now the default way to display a menu in
>> > applications
>> > is to have a bar at the top of the windows.
>
>
> Alistair wrote
>>> Instead of a menu bar at the top, which takes quite a bit of space,
>>> and as mentioned may not fit on a small screen how about a "Start"
>>button in the task-bar that pops up the menu a-la Windows
>
>
> So this basically reduces to the two UI options:
>
>  1. Should Pharo look like an application (and have the menu at the top)
>
>  2. Should Pharo look like an OS itself (with a primary "Start" menu in the
> taskbar as on Windows)
>
> Maybe we should support both styles using a setting.
>
> Bye
> T.
+1
>



Re: [Pharo-dev] [PROPOSAL] Put the WorldMenu in a Menu bar

2018-06-02 Thread p...@highoctane.be
Yes, Commander should drive a lot of these things.

Very useful for scripting things as well and add new macros.

Phil

On Fri, Jun 1, 2018, 21:06 Denis Kudriashov  wrote:

> Looks like Pharo 7 will be the most impressive release in all aspects of
> system:).
>
> About pragmas:
> I believe we should move to Commander with first class commands.
> It requires to create command classes for all menu items. For example
> "Save image":
>
> SaveImageCommand>>execute
>
> Smalltalk
> snapshot: true
> andQuit: false.
>
> SaveImageCommand class>>worldMenuActivation
> 
> ^CmdContextMenuCommandActivation byRootGroupItemFor:
> *CmdWorldMenuContext *
>
> SaveImageCommand class>>globalShortcutActivation
>
> 
> ^CmdShortcutCommandActivation by: $s meta shift for:
> *CmdWorldMenuContext *
>
> It will bring reusable commands which activation can be extended
>
>
> 2018-06-01 20:23 GMT+03:00 Peter Uhnák :
>
>> On Fri, Jun 1, 2018 at 6:46 PM, Sean P. DeNigris 
>> wrote:
>>
>>> Peter Uhnák wrote
>>> > Pharo adds 25px margin on all sides of a full-screen window.
>>>
>>> Good point. I wonder why that's the case!
>>
>>
>> According to the github issue discussion, this is the case.
>>
>>
>>> Peter Uhnák wrote
>>> > it provides the most important/common options that user needs
>>>
>>> Ah! Good to know and interesting, but presumably very subjective.
>>
>>
>> For sure. But for an end-user application it is my responsibility to
>> figure out the UI/UX.
>>
>>
>>> Although it is currently flexible, I don't think we have that now.
>>>
>>
>> The pragma collection can be filtered, but it is not used by the code, so
>> it is all-or-nothing, not very flexible. I think this is for future
>> iterations.
>>
>> Peter Uhnák wrote
>>> > very often I find myself having to move windows, just so I can expose a
>>> > piece of desktop to click on.
>>>
>>> Why don't you use the 25px margin?! ha ha j/k
>>>
>>
>> This applies to fullscreen only. It doesn't apply when you manually move
>> a window to this space.
>> And for fullscreen, I often have the margin disabled. So that's why. :)
>>
>> Peter
>>
>
>


Re: [Pharo-dev] Updated syntax postcard

2018-06-02 Thread p...@highoctane.be
I see & but not

aBool and: [ ...]

The latter is more in line with the actual usage, no?

Phil

On Fri, Jun 1, 2018, 12:57 Pavel Krivanek  wrote:

> Hi,
>
> for the Wikipedia article I prepared an updated version of Phar syntax
> postcard:
>
>
> https://upload.wikimedia.org/wikipedia/commons/a/a7/Pharo_syntax_postcard.svg
>
> Cheers,
> -- Pavel
>


Re: [Pharo-dev] Updated syntax postcard

2018-06-02 Thread p...@highoctane.be
I would love to see:

select: thenCollect:

Or at lease collect: since this is where we do have more power.

do: yeah but not that inspiring.

Phil

On Fri, Jun 1, 2018, 12:57 Pavel Krivanek  wrote:

> Hi,
>
> for the Wikipedia article I prepared an updated version of Phar syntax
> postcard:
>
>
> https://upload.wikimedia.org/wikipedia/commons/a/a7/Pharo_syntax_postcard.svg
>
> Cheers,
> -- Pavel
>


Re: [Pharo-dev] Updated syntax postcard

2018-06-02 Thread p...@highoctane.be
Super light gray on white is hard to see for me (and I guess other vision
challenged people).

Other than that, yes, definitely great.

Phil

On Fri, Jun 1, 2018, 13:21 Peter Uhnák  wrote:

> This is a really nice overview!
>
> Two "p" characters are rendered weirdly for me (Chrome 66), but the
> remaining "p"s are good. The zoom level doesn't matter.
>
>
> Could you please include keyword message with multiple parameters? From my
> teaching this always confuses people. :)
>
> And if you want it to be really complete (maybe you've just missed these):
> annotation for block (only block parameter is annotated), and mayhaps
> definition of unary/binary message?
>
> Peter
>
> On Fri, Jun 1, 2018 at 12:56 PM, Pavel Krivanek 
> wrote:
>
>> Hi,
>>
>> for the Wikipedia article I prepared an updated version of Phar syntax
>> postcard:
>>
>>
>> https://upload.wikimedia.org/wikipedia/commons/a/a7/Pharo_syntax_postcard.svg
>>
>> Cheers,
>> -- Pavel
>>
>
>