Re: [Pharo-dev] [update 3.0] #30296
Thanks a lot Marcus and Clément. Le 26 juil. 2013 à 11:30, Marcus Denker a écrit : > > On Jul 26, 2013, at 8:37 AM, Marcus Denker wrote: > >> >> On Jul 25, 2013, at 11:31 PM, Christophe Demarey >> wrote: >> >>> Hello, >>> >>> This release breaks the right click on the mouse. The event is not handled >>> anymore. >>> I checked #30295 => ok, images >= #30296 ko >>> >> >> Yes, I saw that, too. It seems to be side effect of integrating >> >> 10448 Smalltalk os should use instance of OSPlatform >> >> But the question is why? >> > > We found it! swapMouseButtons should be: > > swapMouseButtons > ^ Smalltalk os isWindows not > > We will integrate it now > > Marcus > > smime.p7s Description: S/MIME cryptographic signature
Re: [Pharo-dev] [update 3.0] #30296
On Jul 26, 2013, at 8:37 AM, Marcus Denker wrote: > > On Jul 25, 2013, at 11:31 PM, Christophe Demarey > wrote: > >> Hello, >> >> This release breaks the right click on the mouse. The event is not handled >> anymore. >> I checked #30295 => ok, images >= #30296 ko >> > > Yes, I saw that, too. It seems to be side effect of integrating > > 10448 Smalltalk os should use instance of OSPlatform > > But the question is why? > We found it! swapMouseButtons should be: swapMouseButtons ^ Smalltalk os isWindows not We will integrate it now Marcus
Re: [Pharo-dev] [update 3.0] #30296
2013/7/26 Camillo Bruni > > On 2013-07-26, at 08:37, Marcus Denker wrote: > > > > > On Jul 25, 2013, at 11:31 PM, Christophe Demarey < > christophe.dema...@inria.fr> wrote: > > > >> Hello, > >> > >> This release breaks the right click on the mouse. The event is not > handled anymore. > >> I checked #30295 => ok, images >= #30296 ko > >> > > > > Yes, I saw that, too. It seems to be side effect of integrating > > > > 10448 Smalltalk os should use instance of OSPlatform > > > > But the question is why? > > > > Marcus > > I remember seing some old keybinding code, but only for windows. > Might be that I accidentally refactored something wrong in one of the > platform checks. > > Does it still work under win/linux? > No, win and linux -- Best regards, Douaille Erwan
Re: [Pharo-dev] [update 3.0] #30296
On 2013-07-26, at 08:37, Marcus Denker wrote: > > On Jul 25, 2013, at 11:31 PM, Christophe Demarey > wrote: > >> Hello, >> >> This release breaks the right click on the mouse. The event is not handled >> anymore. >> I checked #30295 => ok, images >= #30296 ko >> > > Yes, I saw that, too. It seems to be side effect of integrating > > 10448 Smalltalk os should use instance of OSPlatform > > But the question is why? > > Marcus I remember seing some old keybinding code, but only for windows. Might be that I accidentally refactored something wrong in one of the platform checks. Does it still work under win/linux?
Re: [Pharo-dev] [update 3.0] #30296
On Jul 25, 2013, at 11:31 PM, Christophe Demarey wrote: > Hello, > > This release breaks the right click on the mouse. The event is not handled > anymore. > I checked #30295 => ok, images >= #30296 ko > Yes, I saw that, too. It seems to be side effect of integrating 10448 Smalltalk os should use instance of OSPlatform But the question is why? Marcus
Re: [Pharo-dev] [update 3.0] #30296
Hello, This release breaks the right click on the mouse. The event is not handled anymore. I checked #30295 => ok, images >= #30296 ko Christophe. Le 24 juil. 2013 à 14:46, Marcus Denker a écrit : > 30296 > - > > 10448 Smalltalk os should use instance of OSPlatform > https://pharo.fogbugz.com/f/cases/10448 > > 11225 fix DebuggerTest>>testBasic for the new debugger > https://pharo.fogbugz.com/f/cases/11225 > > 11218 SettingDeclaration>>exportAction not send and returns self > https://pharo.fogbugz.com/f/cases/11218 > > > Diff information: > http://smalltalkhub.com/mc/Pharo/Pharo30/main/ToolsTest-MarcusDenker.denker.51.diff > http://smalltalkhub.com/mc/Pharo/Pharo30/main/Tools-MarcusDenker.1194.diff > http://smalltalkhub.com/mc/Pharo/Pharo30/main/Tests-MarcusDenker.597.diff > http://smalltalkhub.com/mc/Pharo/Pharo30/main/System-Support-MarcusDenker.882.diff > http://smalltalkhub.com/mc/Pharo/Pharo30/main/System-Platforms-MarcusDenker.43.diff > http://smalltalkhub.com/mc/Pharo/Pharo30/main/System-Localization-MarcusDenker.69.diff > http://smalltalkhub.com/mc/Pharo/Pharo30/main/System-Hashing-MarcusDenker.25.diff > http://smalltalkhub.com/mc/Pharo/Pharo30/main/System-Clipboard-MarcusDenker.27.diff > http://smalltalkhub.com/mc/Pharo/Pharo30/main/StartupPreferences-MarcusDenker.100.diff > http://smalltalkhub.com/mc/Pharo/Pharo30/main/Ring-Tests-Kernel-MarcusDenker.52.diff > http://smalltalkhub.com/mc/Pharo/Pharo30/main/Network-Kernel-MarcusDenker.89.diff > http://smalltalkhub.com/mc/Pharo/Pharo30/main/Multilingual-Languages-MarcusDenker.32.diff > http://smalltalkhub.com/mc/Pharo/Pharo30/main/Morphic-Base-MarcusDenker.52.diff > http://smalltalkhub.com/mc/Pharo/Pharo30/main/Keys-MarcusDenker.10.diff > http://smalltalkhub.com/mc/Pharo/Pharo30/main/Keymapping-KeyCombinations-MarcusDenker.16.diff > http://smalltalkhub.com/mc/Pharo/Pharo30/main/Keymapping-Core-MarcusDenker.154.diff > http://smalltalkhub.com/mc/Pharo/Pharo30/main/KernelTests-MarcusDenker.537.diff > http://smalltalkhub.com/mc/Pharo/Pharo30/main/Kernel-MarcusDenker.1532.diff > http://smalltalkhub.com/mc/Pharo/Pharo30/main/FreeType-MarcusDenker.621.diff > http://smalltalkhub.com/mc/Pharo/Pharo30/main/Files-MarcusDenker.ducasse.300.diff > http://smalltalkhub.com/mc/Pharo/Pharo30/main/FileSystem-Disk-MarcusDenker.63.diff > http://smalltalkhub.com/mc/Pharo/Pharo30/main/FileSystem-Core-MarcusDenker.104.diff > http://smalltalkhub.com/mc/Pharo/Pharo30/main/Compatibility-MarcusDenker.18.diff > > smime.p7s Description: S/MIME cryptographic signature
[Pharo-dev] [update 3.0] #30296
30296 - 10448 Smalltalk os should use instance of OSPlatform https://pharo.fogbugz.com/f/cases/10448 11225 fix DebuggerTest>>testBasic for the new debugger https://pharo.fogbugz.com/f/cases/11225 11218 SettingDeclaration>>exportAction not send and returns self https://pharo.fogbugz.com/f/cases/11218 Diff information: http://smalltalkhub.com/mc/Pharo/Pharo30/main/ToolsTest-MarcusDenker.denker.51.diff http://smalltalkhub.com/mc/Pharo/Pharo30/main/Tools-MarcusDenker.1194.diff http://smalltalkhub.com/mc/Pharo/Pharo30/main/Tests-MarcusDenker.597.diff http://smalltalkhub.com/mc/Pharo/Pharo30/main/System-Support-MarcusDenker.882.diff http://smalltalkhub.com/mc/Pharo/Pharo30/main/System-Platforms-MarcusDenker.43.diff http://smalltalkhub.com/mc/Pharo/Pharo30/main/System-Localization-MarcusDenker.69.diff http://smalltalkhub.com/mc/Pharo/Pharo30/main/System-Hashing-MarcusDenker.25.diff http://smalltalkhub.com/mc/Pharo/Pharo30/main/System-Clipboard-MarcusDenker.27.diff http://smalltalkhub.com/mc/Pharo/Pharo30/main/StartupPreferences-MarcusDenker.100.diff http://smalltalkhub.com/mc/Pharo/Pharo30/main/Ring-Tests-Kernel-MarcusDenker.52.diff http://smalltalkhub.com/mc/Pharo/Pharo30/main/Network-Kernel-MarcusDenker.89.diff http://smalltalkhub.com/mc/Pharo/Pharo30/main/Multilingual-Languages-MarcusDenker.32.diff http://smalltalkhub.com/mc/Pharo/Pharo30/main/Morphic-Base-MarcusDenker.52.diff http://smalltalkhub.com/mc/Pharo/Pharo30/main/Keys-MarcusDenker.10.diff http://smalltalkhub.com/mc/Pharo/Pharo30/main/Keymapping-KeyCombinations-MarcusDenker.16.diff http://smalltalkhub.com/mc/Pharo/Pharo30/main/Keymapping-Core-MarcusDenker.154.diff http://smalltalkhub.com/mc/Pharo/Pharo30/main/KernelTests-MarcusDenker.537.diff http://smalltalkhub.com/mc/Pharo/Pharo30/main/Kernel-MarcusDenker.1532.diff http://smalltalkhub.com/mc/Pharo/Pharo30/main/FreeType-MarcusDenker.621.diff http://smalltalkhub.com/mc/Pharo/Pharo30/main/Files-MarcusDenker.ducasse.300.diff http://smalltalkhub.com/mc/Pharo/Pharo30/main/FileSystem-Disk-MarcusDenker.63.diff http://smalltalkhub.com/mc/Pharo/Pharo30/main/FileSystem-Core-MarcusDenker.104.diff http://smalltalkhub.com/mc/Pharo/Pharo30/main/Compatibility-MarcusDenker.18.diff
