Re: [Pharo-dev] QualityAssistant feedback

[Marcus Denker]

Hello,

Yes. Another side effect is that you do not get all these “tempX is not used 
should it be remove”
messages when saving a method.

Instead, semantic analysis tags the variable as not used and the editor shows 
an icon/highlight.

What we need to do is to integrate this more with the code critique.

> On 30 Jan 2016, at 02:39, Ben Coman  wrote:
> 
> I've just noticed for "Temporary variables not read AND written" that
> the offending variable in the temporary variable definition is
> highlighted.  Is this new? Its very nice to have this visual
> indication.
> 
> cheers -ben
> 

Re: [Pharo-dev] QualityAssistant feedback

[Nicolai Hess]

2016-02-02 14:46 GMT+01:00 Marcus Denker :

> Hello,
>
> Yes. Another side effect is that you do not get all these “tempX is not
> used should it be remove”
> messages when saving a method.
>
> Instead, semantic analysis tags the variable as not used and the editor
> shows an icon/highlight.
>
> What we need to do is to integrate this more with the code critique.
>

It would be good to have an action associated with the highlighted temp var
for
removing the unused var. Or does this already work ?



>
> > On 30 Jan 2016, at 02:39, Ben Coman  wrote:
> >
> > I've just noticed for "Temporary variables not read AND written" that
> > the offending variable in the temporary variable definition is
> > highlighted.  Is this new? Its very nice to have this visual
> > indication.
> >
> > cheers -ben
> >
>
>
>

Re: [Pharo-dev] QualityAssistant feedback

[Marcus Denker]

> On 02 Feb 2016, at 14:55, Nicolai Hess  wrote:
> 
> 
> 
> 2016-02-02 14:46 GMT+01:00 Marcus Denker  >:
> Hello,
> 
> Yes. Another side effect is that you do not get all these “tempX is not used 
> should it be remove”
> messages when saving a method.
> 
> Instead, semantic analysis tags the variable as not used and the editor shows 
> an icon/highlight.
> 
> What we need to do is to integrate this more with the code critique.
> 
> It would be good to have an action associated with the highlighted temp var 
> for
> removing the unused var. Or does this already work ?
> 
No, but it should be easy to add…

Marcus

[Pharo-dev] QualityAssistant feedback

[Ben Coman]

I've just noticed for "Temporary variables not read AND written" that
the offending variable in the temporary variable definition is
highlighted.  Is this new? Its very nice to have this visual
indication.

cheers -ben