Re: [Pharo-dev] pillar highlight text in code

2016-11-06 Thread Nicolai Hess
2016-11-06 19:35 GMT+01:00 Nicolai Hess :

>
>
> 2016-11-05 13:41 GMT+01:00 stepharo :
>
>> Yes I should fix them.
>>
>>
>>
> I added a pull request fixing the ">>>" vs. ">>" in the reflection
> chapter. (some other chapters are using >># instead, I think we should
> convert them all to use ">>" only)
>
> will now update the reflection chapter screenshots.
>

some texts (for the screenshots) needs to be updated as well, for example,
there is no OBBrowser or Refactoring browser


>
>
>
>>
>> Le 3/11/16 à 23:52, Nicolai Hess a écrit :
>>
>>
>>
>> 2016-11-03 23:50 GMT+01:00 Nicolai Hess :
>>
>>> Can we highlight a piece of code?
>>> In the updated PBE (Reflection chapter) there is the text:
>>> "Change the definition of Integer>>>factorial by inserting the
>>> underlined expression as shown below"
>>> But I can not see the "underline" in the code example. Is it even
>>> possible to add such text properties to a "code-style" formatted text ?
>>>
>>> BTW, the method name is wrong (in both places)
>>> Integer>>#factorial
>>> not
>>> Integer>>>factorial
>>>
>>
>>
>> actually all code examples in that chapter uses
>> >>>
>> instead of
>> >>#
>>
>>
>>
>


Re: [Pharo-dev] pillar highlight text in code

2016-11-06 Thread Nicolai Hess
2016-11-05 13:41 GMT+01:00 stepharo :

> Yes I should fix them.
>
>
>
I added a pull request fixing the ">>>" vs. ">>" in the reflection chapter.
(some other chapters are using >># instead, I think we should convert them
all to use ">>" only)

will now update the reflection chapter screenshots.



>
> Le 3/11/16 à 23:52, Nicolai Hess a écrit :
>
>
>
> 2016-11-03 23:50 GMT+01:00 Nicolai Hess :
>
>> Can we highlight a piece of code?
>> In the updated PBE (Reflection chapter) there is the text:
>> "Change the definition of Integer>>>factorial by inserting the underlined
>> expression as shown below"
>> But I can not see the "underline" in the code example. Is it even
>> possible to add such text properties to a "code-style" formatted text ?
>>
>> BTW, the method name is wrong (in both places)
>> Integer>>#factorial
>> not
>> Integer>>>factorial
>>
>
>
> actually all code examples in that chapter uses
> >>>
> instead of
> >>#
>
>
>


Re: [Pharo-dev] pillar highlight text in code

2016-11-05 Thread Nicolai Hess
2016-11-05 13:41 GMT+01:00 stepharo :

> Yes I should fix them.
>
>
> Are you working on this right now? Otherwise I can do it too.
And I was about to create new screenshots for that chapter. Just tell if
you would need them or if you are
about to change them yourself.



>
> Le 3/11/16 à 23:52, Nicolai Hess a écrit :
>
>
>
> 2016-11-03 23:50 GMT+01:00 Nicolai Hess :
>
>> Can we highlight a piece of code?
>> In the updated PBE (Reflection chapter) there is the text:
>> "Change the definition of Integer>>>factorial by inserting the underlined
>> expression as shown below"
>> But I can not see the "underline" in the code example. Is it even
>> possible to add such text properties to a "code-style" formatted text ?
>>
>> BTW, the method name is wrong (in both places)
>> Integer>>#factorial
>> not
>> Integer>>>factorial
>>
>
>
> actually all code examples in that chapter uses
> >>>
> instead of
> >>#
>
>
>


Re: [Pharo-dev] pillar highlight text in code

2016-11-05 Thread stepharo

Yes I should fix them.



Le 3/11/16 à 23:52, Nicolai Hess a écrit :



2016-11-03 23:50 GMT+01:00 Nicolai Hess >:


Can we highlight a piece of code?
In the updated PBE (Reflection chapter) there is the text:
"Change the definition of Integer>>>factorial by inserting the
underlined expression as shown below"
But I can not see the "underline" in the code example. Is it even
possible to add such text properties to a "code-style" formatted
text ?

BTW, the method name is wrong (in both places)
Integer>>#factorial
not
Integer>>>factorial



actually all code examples in that chapter uses
>>>
instead of
>>#





Re: [Pharo-dev] pillar highlight text in code

2016-11-03 Thread Nicolai Hess
2016-11-03 23:50 GMT+01:00 Nicolai Hess :

> Can we highlight a piece of code?
> In the updated PBE (Reflection chapter) there is the text:
> "Change the definition of Integer>>>factorial by inserting the underlined
> expression as shown below"
> But I can not see the "underline" in the code example. Is it even possible
> to add such text properties to a "code-style" formatted text ?
>
> BTW, the method name is wrong (in both places)
> Integer>>#factorial
> not
> Integer>>>factorial
>


actually all code examples in that chapter uses
>>>
instead of
>>#


[Pharo-dev] pillar highlight text in code

2016-11-03 Thread Nicolai Hess
Can we highlight a piece of code?
In the updated PBE (Reflection chapter) there is the text:
"Change the definition of Integer>>>factorial by inserting the underlined
expression as shown below"
But I can not see the "underline" in the code example. Is it even possible
to add such text properties to a "code-style" formatted text ?

BTW, the method name is wrong (in both places)
Integer>>#factorial
not
Integer>>>factorial