[Pharo-project] About RBLiteralArrayContainsCommaRule

2012-12-30 Thread Stéphane Ducasse
Hi 

I'm going over all the SmallLint rule and extending their rationale and fixing 
sometimes their default check.
Now I'm reading 

RBLiteralArrayContainsCommaRule

rationale
^ 'Checks for literal arrays that contain the #, symbol.'

and I have no idea why this would be a problem. 

Anybody has an idea?

Stef




Re: [Pharo-project] About RBLiteralArrayContainsCommaRule

2012-12-30 Thread Peter Hugosson-Miller
Possibly it's useful as a warning to one who comes from a C-syntax language, 
and might accidentally define a literal array containing some. For example, 
#(1, 2, 3) - not an error, but not (as the perpetrator might believe) an array 
containing three integers ;)
--
Cheers,
Peter.

On 30 dec 2012, at 20:48, Stéphane Ducasse  wrote:

> Hi 
> 
> I'm going over all the SmallLint rule and extending their rationale and 
> fixing sometimes their default check.
> Now I'm reading 
> 
> RBLiteralArrayContainsCommaRule
> 
> rationale
>^ 'Checks for literal arrays that contain the #, symbol.'
> 
> and I have no idea why this would be a problem. 
> 
> Anybody has an idea?
> 
> Stef
> 
> 



Re: [Pharo-project] About RBLiteralArrayContainsCommaRule

2012-12-30 Thread Stéphane Ducasse
Ok :)
for now I kept it.
And I'm creating an unused category to group the rules that we do not follow.
I hope soon that we will develop some good rules to drive our development.

Stef

On Dec 30, 2012, at 9:05 PM, Peter Hugosson-Miller wrote:

> Possibly it's useful as a warning to one who comes from a C-syntax language, 
> and might accidentally define a literal array containing some. For example, 
> #(1, 2, 3) - not an error, but not (as the perpetrator might believe) an 
> array containing three integers ;)
> --
> Cheers,
> Peter.
> 
> On 30 dec 2012, at 20:48, Stéphane Ducasse  wrote:
> 
>> Hi 
>> 
>> I'm going over all the SmallLint rule and extending their rationale and 
>> fixing sometimes their default check.
>> Now I'm reading 
>> 
>> RBLiteralArrayContainsCommaRule
>> 
>> rationale
>>   ^ 'Checks for literal arrays that contain the #, symbol.'
>> 
>> and I have no idea why this would be a problem. 
>> 
>> Anybody has an idea?
>> 
>> Stef
>> 
>> 
>