Re: [Pharo-users] In P7 scrpt variable to tmp when in debugger

2018-04-16 Thread Marcus Denker


> On 12 Apr 2018, at 17:18, Marcus Denker  wrote:
> 
> 
> 
>> On 12 Apr 2018, at 17:06, Hilaire  wrote:
>> 
>> Hi Marcus, Benoit,
>> 
>> Nice to know. I was testing in a set up with both .changes and source files. 
>> So I was suspecting something like what your described. I can imagine in 
>> production code your feature to speed up compilation will be appreciated. 
>> For Dr. Geo and Smalltalk sketch, it is better to have variable names.
>> 
> 
> I should have a fix ready tomorrow.
> 

I will for now revert the change:

https://github.com/pharo-project/pharo/pull/1199 


This way it behaves as people expect, I have an idea how to provide an option 
for the faster way.
This will come next.

Marcus 



Re: [Pharo-users] In P7 scrpt variable to tmp when in debugger

2018-04-12 Thread Hilaire

Thanks.


Le 12/04/2018 à 17:18, Marcus Denker a écrit :

I should have a fix ready tomorrow.


--
Dr. Geo
http://drgeo.eu





Re: [Pharo-users] In P7 scrpt variable to tmp when in debugger

2018-04-12 Thread Marcus Denker


> On 12 Apr 2018, at 17:06, Hilaire  wrote:
> 
> Hi Marcus, Benoit,
> 
> Nice to know. I was testing in a set up with both .changes and source files. 
> So I was suspecting something like what your described. I can imagine in 
> production code your feature to speed up compilation will be appreciated. For 
> Dr. Geo and Smalltalk sketch, it is better to have variable names.
> 

I should have a fix ready tomorrow.

> Thanks
> 
> Hilaire
> 
> Le 12/04/2018 à 16:31, Marcus Denker a écrit :
>> Hello,
>> 
>> I changed the way code is compiled for #evaluate: to speed it up, but it 
>> turns out that having nice vars is actually more important than
>> speed in most cases.
>> 
>> I will change this again and just add it as an optional feature (you then 
>> can set an option if you need speed, but the default will be to keep the
>> var names).
>> 
>> For an intermediate fix, you can change in OpalCompiler>>#evaluate the send 
>> of #generate to #generateWithSource.
>> 
>>  Marcus
> 
> -- 
> Dr. Geo
> http://drgeo.eu
> 
> 
> 




Re: [Pharo-users] In P7 scrpt variable to tmp when in debugger

2018-04-12 Thread Hilaire

Hi Marcus, Benoit,

Nice to know. I was testing in a set up with both .changes and source 
files. So I was suspecting something like what your described. I can 
imagine in production code your feature to speed up compilation will be 
appreciated. For Dr. Geo and Smalltalk sketch, it is better to have 
variable names.


Thanks

Hilaire

Le 12/04/2018 à 16:31, Marcus Denker a écrit :

Hello,

I changed the way code is compiled for #evaluate: to speed it up, but it turns 
out that having nice vars is actually more important than
speed in most cases.

I will change this again and just add it as an optional feature (you then can 
set an option if you need speed, but the default will be to keep the
var names).

For an intermediate fix, you can change in OpalCompiler>>#evaluate the send of 
#generate to #generateWithSource.

Marcus


--
Dr. Geo
http://drgeo.eu





Re: [Pharo-users] In P7 scrpt variable to tmp when in debugger

2018-04-12 Thread Benoit St-Jean via Pharo-users
--- Begin Message ---
What happens if you debug the script starting with a "self halt" ?  Are the 
variables there with their original name?  looks like decompiled code.  A 
problem with your .sources file?


- 
Benoît St-Jean 
Yahoo! Messenger: bstjean 
Twitter: @BenLeChialeux 
Pinterest: benoitstjean 
Instagram: Chef_Benito
IRC: lamneth 
Blogue: endormitoire.wordpress.com 
"A standpoint is an intellectual horizon of radius zero".  (A. Einstein) 

On Thursday, April 12, 2018, 10:11:37 a.m. EDT, Hilaire  
wrote:  
 
 Hi,

When an executed script throws an error, in the debugger the script lost 
its variable names and the code is not exactly the same.

Any idea why?

See screenshot

Thanks

Hilaire

-- 
Dr. Geo
http://drgeo.eu

  --- End Message ---


Re: [Pharo-users] In P7 scrpt variable to tmp when in debugger

2018-04-12 Thread Marcus Denker


> On 12 Apr 2018, at 16:10, Hilaire  wrote:
> 
> Hi,
> 
> When an executed script throws an error, in the debugger the script lost its 
> variable names and the code is not exactly the same.
> 
> Any idea why?
> 

Hello,

I changed the way code is compiled for #evaluate: to speed it up, but it turns 
out that having nice vars is actually more important than
speed in most cases.

I will change this again and just add it as an optional feature (you then can 
set an option if you need speed, but the default will be to keep the
var names).

For an intermediate fix, you can change in OpalCompiler>>#evaluate the send of 
#generate to #generateWithSource.

Marcus