ID: 46685
Updated by: paj...@php.net
Reported By: scott dot php at scottrix dot co dot uk
-Status: No Feedback
+Status: Assigned
Bug Type: Performance problem
Operating System: Linux
PHP Version: 5.2.6
-Assigned To:
+Assigned To: rasmus
New Comment:
assigned to Rasmus, looks like he is willing to figure out the cause
and improve this patch.
Previous Comments:
------------------------------------------------------------------------
[2008-11-26 13:36:31] scott dot php at scottrix dot co dot uk
Seems to me you don't understand, I could easily have found this with a
code walk and would not have any test case. The way you are using the
SSL libraries is (IMO and the openssl examples) wrong. Doesn't matter
if it has any effects on running scripts, it is still wrong. I DO
understand that you will want a test to show it has been fixed, but this
isn't possible with all coding problems as I'm sure you know, the main
thing from a change like this is that it doesn't break any of the
existing tests and regression tests that you already have. (or anybody
else code that is out there....)
The only test I have that shows the problem is an strace on a running
script. I don't have permission to release that script and you don't
have the server pages and software that the script runs against, so
would be useless anyway. I would try to create one, but I personally
don't know PHP so can't. Given the problem I would imagine that any PHP
script that is talking SSL and having to wait for data to come back
would have the same problem (viewable by strace output).
Anyway, if you NEED more to be able to apply a patch and test it, then
I guess you can close this bug. The important thing for me is that I
have tried to get someone upstream interested in writing better code,
and that it is searchable so that others that experience the problem can
find it and try my fix.
------------------------------------------------------------------------
[2008-11-26 13:19:34] paj...@php.net
You get it wrong.
A patch can and will be applied when tests are provided as well. The
goal is not only to be able to reproduce a possible issue, but also to
be sure about the patch is trying to fix.
You do not want to provide them and I'm not sure your patch is the
right to do it (as already said, that does not mean it is wrong). So
this bug has now in a "no feedback" status, until you have figured out
that what I asked is relevent.
That's a relatively simple process, isn't it?
------------------------------------------------------------------------
[2008-11-26 13:13:58] scott dot php at scottrix dot co dot uk
I didn't submit the patch to help me, I already have the fix for the
problem. If you aren't interested then that is fine. Just thought I'd
try and give something back to you guys. Next time I won't bother.
------------------------------------------------------------------------
[2008-11-26 13:07:36] paj...@php.net
your choice > no feedback.
------------------------------------------------------------------------
[2008-11-26 12:22:53] scott dot php at scottrix dot co dot uk
I don't see how the script is relevant. You should never sit in a busy
loop like this no matter what the php script is doing.
------------------------------------------------------------------------
The remainder of the comments for this report are too long. To view
the rest of the comments, please view the bug report online at
http://bugs.php.net/46685
--
Edit this bug report at http://bugs.php.net/?id=46685&edit=1
