#50303 [Bgs]: A few different autotools issues

2009-11-26 Thread galtgendo at o2 dot pl
 ID:   50303
 User updated by:  galtgendo at o2 dot pl
 Reported By:  galtgendo at o2 dot pl
 Status:   Bogus
 Bug Type: Compile Failure
 Operating System: Linux
 PHP Version:  5.2.11
 New Comment:

As for 1 - I could quote a part of autoconf info page
at you once again, but ...oh,well
As for 2 - in ext/curl/interface.c you have:
#   if defined(HAVE_GCRYPT_H)
#define PHP_CURL_NEED_GNUTLS_TSL
#include gcrypt.h
#   else
...
#   endif

But if you use AC_CHECK_HEADER, HAVE_GCRYPT_H
never gets defined, even if the header gets properly detected.
And I don't see how any of AC_TRY_RUN in ext/curl/config.m4
could succeed without libcurl being added to LIBS
for those tests.


Previous Comments:


[2009-11-26 10:05:46] j...@php.net

1. Wont fix
2. No idea what bug that is.

And last but not least: DO NOT report multiple issues in one report.



[2009-11-26 00:35:42] galtgendo at o2 dot pl

Description:

Seeing that bug 50291 got accepted,
I'd like to readdress a few issues,
some of which I already address here
(some of them were bogus, other were not).

1. Gentoo bug 151444 - '--as-needed' problem
a.k.a. using LDFLAGS instead of libs
while Gentoo is using a different fix now,
I still keep a patch (quite a bit reduced,
compared to the one in the bug), that modifies
PHP_CHECK_LIBRARY to use LIBS instead of
LDFLAGS - it modifies a few other ext specific
macros too; it works for me for over a year now,
but I'm not building all exts, so it could use some polishing

2. Gentoo bug 275240 - curl.m4
while changing from curl-config
to pkg-config is just an idea (curl, just as php 
needs to be kept up to date, due to security,
so it shouldn't be a big problem),
AC_CHECK_HEADER - AC_CHECK_HEADERS
is required for things to work







-- 
Edit this bug report at http://bugs.php.net/?id=50303edit=1



#50303 [Bgs]: A few different autotools issues

2009-11-26 Thread galtgendo at o2 dot pl
 ID:   50303
 User updated by:  galtgendo at o2 dot pl
 Reported By:  galtgendo at o2 dot pl
 Status:   Bogus
 Bug Type: Compile Failure
 Operating System: Linux
 PHP Version:  5.2.11
 New Comment:

As for pkg-config, it's just an idea, but:
- it's cleaner
- what if curl does the same thing that
gnutls did - drops it's custom script ?


Previous Comments:


[2009-11-26 11:07:28] galtgendo at o2 dot pl

As for 1 - I could quote a part of autoconf info page
at you once again, but ...oh,well
As for 2 - in ext/curl/interface.c you have:
#   if defined(HAVE_GCRYPT_H)
#define PHP_CURL_NEED_GNUTLS_TSL
#include gcrypt.h
#   else
...
#   endif

But if you use AC_CHECK_HEADER, HAVE_GCRYPT_H
never gets defined, even if the header gets properly detected.
And I don't see how any of AC_TRY_RUN in ext/curl/config.m4
could succeed without libcurl being added to LIBS
for those tests.



[2009-11-26 10:05:46] j...@php.net

1. Wont fix
2. No idea what bug that is.

And last but not least: DO NOT report multiple issues in one report.



[2009-11-26 00:35:42] galtgendo at o2 dot pl

Description:

Seeing that bug 50291 got accepted,
I'd like to readdress a few issues,
some of which I already address here
(some of them were bogus, other were not).

1. Gentoo bug 151444 - '--as-needed' problem
a.k.a. using LDFLAGS instead of libs
while Gentoo is using a different fix now,
I still keep a patch (quite a bit reduced,
compared to the one in the bug), that modifies
PHP_CHECK_LIBRARY to use LIBS instead of
LDFLAGS - it modifies a few other ext specific
macros too; it works for me for over a year now,
but I'm not building all exts, so it could use some polishing

2. Gentoo bug 275240 - curl.m4
while changing from curl-config
to pkg-config is just an idea (curl, just as php 
needs to be kept up to date, due to security,
so it shouldn't be a big problem),
AC_CHECK_HEADER - AC_CHECK_HEADERS
is required for things to work







-- 
Edit this bug report at http://bugs.php.net/?id=50303edit=1