ID: 13217 Updated by: [EMAIL PROTECTED] Reported By: [EMAIL PROTECTED] -Status: Open +Status: Closed Bug Type: Feature/Change Request Operating System: Debian GNU/Linux PHP Version: 4.0.6 New Comment:
this bit of code has been rewritten. Previous Comments: ------------------------------------------------------------------------ [2001-09-08 22:39:56] [EMAIL PROTECTED] Grr web interface: http://www.bubblesworth.com/php4.cvs2.diff ------------------------------------------------------------------------ [2001-09-08 22:37:15] [EMAIL PROTECTED] If (z_value && ZZ_STRLEN_PP(z_value) == 0) then encoded_value isn't used. So no need to generate it, surely? This patch'll be mangled by the wrapping in the window, so it's available at <a href="http://www.bubblesworth.com/php4.cvs2.diff";>http://www.bubblesworth.com/php4.cvs2.diff</a> --- ext/standard/head.c.cvs Sun Sep 9 12:13:27 2001 +++ ext/standard/head.c.new Sun Sep 9 12:39:47 2001 @@ -118,7 +118,7 @@ if (z_name) { len += Z_STRLEN_PP(z_name); } - if (z_value) { + if (z_value && Z_STRLEN_PP(z_value) != 0) { int encoded_value_len; encoded_value = php_url_encode(Z_STRVAL_PP(z_value), Z_STRLEN_PP(z_value), &encoded_value_len); ------------------------------------------------------------------------ -- Edit this bug report at http://bugs.php.net/?id=13217&edit=1
