Bug #60179 [PATCH]: wrong output with php_flag boolean

2011-11-03 Thread f...@php.net
Edit report at https://bugs.php.net/bug.php?id=60179&edit=1

 ID: 60179
 Patch added by: f...@php.net
 Reported by:dbetz at df dot eu
 Summary:wrong output with php_flag boolean
 Status: Assigned
 Type:   Bug
 Package:FPM related
 Operating System:   Gentoo Linux
 PHP Version:5.3.8
 Assigned To:fat
 Block user comment: N
 Private report: N

 New Comment:

The following patch has been added/updated:

Patch Name: fpm-bug60179-v2.patch
Revision:   1320332822
URL:
https://bugs.php.net/patch-display.php?bug=60179&patch=fpm-bug60179-v2.patch&revision=1320332822


Previous Comments:

[2011-10-31 14:44:52] dbetz at df dot eu

In the php manual http://php.net/ini_get is an notice:
Hinweis: When querying boolean values

A boolean ini value of off will be returned as an empty string or "0" while a 
boolean ini value of on will be returned as "1". The function can also return 
the literal string of INI value. 

--

It looks like, that the value is not boolen Off but string "Off"


[2011-10-31 14:34:49] dbetz at df dot eu

Hello,

yes, the option is set correct, but the return value of ini_get() is different 
than whith php-cgi.

Most apps like typo3, joomla, wordpress, eg. are checking in the installer, if 
php.ini settings are correct.
These setting are checked thru ini_get.

When ini_get(session.auto_start) is not 0 but "Off", then the check fails.

Here is the sample code from typo3 installer:

if (ini_get('session.auto_start')) {
$sessionCreationError = 'Error: session.auto-start
is enabled.';
$sessionCreationError .= 'The PHP option
session.auto-start is enabled. Disable this option in php.ini or
.htaccess:';

I hope you understand now my problem.


[2011-10-31 14:22:10] f...@php.net

hum ... not sure to understand your problem afterall :)

without the patch:
If I set php_flag[session.auto_start]=On
ini_get("session.auto_start") returns "On"
and session are created for each page (auto start is on as asked)

If I set php_flag[session.auto_start]=Off
ini_get("session.auto_start") returns "Off"
and session are NOT created for each page (auto start is off as asked)

For me this works as expected.
Do you have the same behavior ?


[2011-10-31 13:52:48] dbetz at df dot eu

Hi fat,

i have tested the latest snapshot with the patch and have changed the config to
php_flag[session.auto_start] = Off

But the problem is still here.

Looking into fpm_conf.c at: static char *fpm_conf_set_array(... :
if (convert_to_bool) {
char *err = fpm_conf_set_boolean(value, &subconf, 0);
if (err) return err;
kv->value = strdup(b ? "On" : "Off");
}

It looks like kv->value is either string "On" or "Off" or am i wrong ?


[2011-10-31 13:18:55] f...@php.net

1- On wich version did you apply the patch ? Please test the patch on the 
lastest 5.3.x snapshot.

2- you should not surrender the parameter with double quote:

php_flag["session.auto_start"] = Off

should be

php_flag[session.auto_start] = Off


Can you get rid of the bug. On my side, I have the last 5.3.x snapshot and it 
works great. I can't reproduce your problem.




The remainder of the comments for this report are too long. To view
the rest of the comments, please view the bug report online at

https://bugs.php.net/bug.php?id=60179


-- 
Edit this bug report at https://bugs.php.net/bug.php?id=60179&edit=1


Bug #60179 [PATCH]: wrong output with php_flag boolean

2011-10-31 Thread f...@php.net
Edit report at https://bugs.php.net/bug.php?id=60179&edit=1

 ID: 60179
 Patch added by: f...@php.net
 Reported by:dbetz at df dot eu
 Summary:wrong output with php_flag boolean
 Status: Open
 Type:   Bug
 Package:FPM related
 Operating System:   Gentoo Linux
 PHP Version:5.3.8
 Block user comment: N
 Private report: N

 New Comment:

The following patch has been added/updated:

Patch Name: fpm-bug60179.patch
Revision:   1320066041
URL:
https://bugs.php.net/patch-display.php?bug=60179&patch=fpm-bug60179.patch&revision=1320066041


Previous Comments:

[2011-10-31 08:43:30] dbetz at df dot eu

Description:

Hello,

when setting php_flag to Off or false, then PHP FPM sets it to the string "Off" 
rather than 0 or NULL.

In fpm.conf
php_flag["session.auto_start"] = Off
or
php_flag["session.auto_start"] = false

It seems that the failure is on all boolean flags.


Test script:
---





Expected result:

session.auto_start is : 0

Actual result:
--
session.auto_start is : Off






-- 
Edit this bug report at https://bugs.php.net/bug.php?id=60179&edit=1