Bug #61268 [Csd]: --enable-dtrace leads make to clobber Zend/zend_dtrace.d

2013-08-14 Thread sixd
Edit report at https://bugs.php.net/bug.php?id=61268edit=1

 ID: 61268
 Updated by: s...@php.net
 Reported by:mike at harschsystems dot com
 Summary:--enable-dtrace leads make to clobber
 Zend/zend_dtrace.d
 Status: Closed
 Type:   Bug
 Package:Compile Failure
 Operating System:   solaris
 PHP Version:5.4.0
 Assigned To:dsp
 Block user comment: N
 Private report: N

 New Comment:

Verified status is open and the problem confirmed to occur.


Previous Comments:

[2013-08-06 00:37:56] mike at harschsystems dot com

Building on solaris/illumos is still broken per the description in bug 62692.  
I 
don't know how it reached 'verified' state but it needs to be re-opened and 
evaluated.


[2013-08-05 22:50:43] s...@php.net

The fix for this bug has been committed.

Snapshots of the sources are packaged every three hours; this change
will be in the next snapshot. You can grab the snapshot at
http://snaps.php.net/.

 For Windows:

http://windows.php.net/snapshots/
 
Thank you for the report, and for helping us make PHP better.




[2013-08-05 16:05:25] mike at harschsystems dot com

The suggested patch does appear to fix the clobber problem on illumos.

This clears the way to hit bug 62692 (which also breaks dtrace on solaris-based 
systems).

Let's fix the issue of not applying the 'dtrace -G' step to the files in 
Zend/.libs so that we can reach a working state for dtrace on solaris.


[2013-08-03 01:14:49] s...@php.net

After some investigation, I think the easiest patch is below.  This has only 
been tested on Linux in one install scenario.  I'll continuing testing after 
the weekend.

diff --git a/acinclude.m4 b/acinclude.m4
index 07b1f8e..01eabf2 100644
--- a/acinclude.m4
+++ b/acinclude.m4
@@ -2962,8 +2962,12 @@ dnl DTrace objects
   esac
 
 dnl Generate Makefile.objects entries
+dnl The empty $ac_provsrc command stops an implicit circular dependency
+dnl triggering which lead to the .d file being overwritten with GNU make (Bug 
61268)
   catMakefile.objectsEOF
 
+$abs_srcdir/$ac_provsrc:;
+
 $ac_bdir[$]ac_hdrobj: $abs_srcdir/$ac_provsrc
CFLAGS=\$(CFLAGS_CLEAN) dtrace -h -C -s $ac_srcdir[$]ac_provsrc -o 
\$[]@  cp \$[]@ \$[]@.bak  \$(SED) 's,PHP_,DTRACE_,g' \$[]@.bak  \$[]@


[2013-08-03 01:14:49] s...@php.net

Related To: Bug #61268




The remainder of the comments for this report are too long. To view
the rest of the comments, please view the bug report online at

https://bugs.php.net/bug.php?id=61268


-- 
Edit this bug report at https://bugs.php.net/bug.php?id=61268edit=1


Bug #61268 [Csd]: --enable-dtrace leads make to clobber Zend/zend_dtrace.d

2013-08-05 Thread mike at harschsystems dot com
Edit report at https://bugs.php.net/bug.php?id=61268edit=1

 ID: 61268
 User updated by:mike at harschsystems dot com
 Reported by:mike at harschsystems dot com
 Summary:--enable-dtrace leads make to clobber
 Zend/zend_dtrace.d
 Status: Closed
 Type:   Bug
 Package:Compile Failure
 Operating System:   solaris
 PHP Version:5.4.0
 Assigned To:dsp
 Block user comment: N
 Private report: N

 New Comment:

Building on solaris/illumos is still broken per the description in bug 62692.  
I 
don't know how it reached 'verified' state but it needs to be re-opened and 
evaluated.


Previous Comments:

[2013-08-05 22:50:43] s...@php.net

The fix for this bug has been committed.

Snapshots of the sources are packaged every three hours; this change
will be in the next snapshot. You can grab the snapshot at
http://snaps.php.net/.

 For Windows:

http://windows.php.net/snapshots/
 
Thank you for the report, and for helping us make PHP better.




[2013-08-05 16:05:25] mike at harschsystems dot com

The suggested patch does appear to fix the clobber problem on illumos.

This clears the way to hit bug 62692 (which also breaks dtrace on solaris-based 
systems).

Let's fix the issue of not applying the 'dtrace -G' step to the files in 
Zend/.libs so that we can reach a working state for dtrace on solaris.


[2013-08-03 01:14:49] s...@php.net

After some investigation, I think the easiest patch is below.  This has only 
been tested on Linux in one install scenario.  I'll continuing testing after 
the weekend.

diff --git a/acinclude.m4 b/acinclude.m4
index 07b1f8e..01eabf2 100644
--- a/acinclude.m4
+++ b/acinclude.m4
@@ -2962,8 +2962,12 @@ dnl DTrace objects
   esac
 
 dnl Generate Makefile.objects entries
+dnl The empty $ac_provsrc command stops an implicit circular dependency
+dnl triggering which lead to the .d file being overwritten with GNU make (Bug 
61268)
   catMakefile.objectsEOF
 
+$abs_srcdir/$ac_provsrc:;
+
 $ac_bdir[$]ac_hdrobj: $abs_srcdir/$ac_provsrc
CFLAGS=\$(CFLAGS_CLEAN) dtrace -h -C -s $ac_srcdir[$]ac_provsrc -o 
\$[]@  cp \$[]@ \$[]@.bak  \$(SED) 's,PHP_,DTRACE_,g' \$[]@.bak  \$[]@


[2013-08-03 01:14:49] s...@php.net

Related To: Bug #61268


[2013-07-23 10:54:27] eugene at zhegan dot in

Still there on 5.5.1.




The remainder of the comments for this report are too long. To view
the rest of the comments, please view the bug report online at

https://bugs.php.net/bug.php?id=61268


-- 
Edit this bug report at https://bugs.php.net/bug.php?id=61268edit=1