Edit report at http://bugs.php.net/bug.php?id=51063&edit=1
ID: 51063 Updated by: paj...@php.net Reported by: bfra...@php.net Summary: Add getimagesizefromstring -Status: Assigned +Status: Closed Type: Feature/Change Request Package: GetImageSize related PHP Version: 5.3.1 Assigned To: pajoye New Comment: This bug has been fixed in SVN. Snapshots of the sources are packaged every three hours; this change will be in the next snapshot. You can grab the snapshot at http://snaps.php.net/. Thank you for the report, and for helping us make PHP better. Applied a slightly cleaner patch. Thanks for your work! Previous Comments: ------------------------------------------------------------------------ [2010-05-05 15:39:36] paj...@php.net Automatic comment from SVN on behalf of pajoye Revision: http://svn.php.net/viewvc/?view=revision&revision=299022 Log: - #51063, news and test ------------------------------------------------------------------------ [2010-05-05 15:37:42] paj...@php.net Automatic comment from SVN on behalf of pajoye Revision: http://svn.php.net/viewvc/?view=revision&revision=299021 Log: - #51063, implement getimagesizefromstring ------------------------------------------------------------------------ [2010-03-06 12:01:26] ka...@php.net Patch looks good except for one thing, that is the parameter parsing. You should use something along the lines of: char *file; int file_len; HashTable *ht; if (zend_parse_parameters(ZEND_NUM_ARGS() TSRMS_CC, "s|H", &file, &file_len, &ht) == FAILURE) The old (and deprecated) way of first doing a switch and use zend_get_parameters*() should be avoided. Else good work on the patch ;) ------------------------------------------------------------------------ [2010-02-17 14:25:04] paj...@php.net Will apply it shortly after review (probably this WE). However it looks good already, thanks :) ------------------------------------------------------------------------ [2010-02-17 03:59:22] bfra...@php.net Here is a test for the new function: http://www.brianfrance.com/software/php/getimagesizefromstring/001.phpt and the required test.gif (php logo image): http://static.php.net/www.php.net/images/php.gif ------------------------------------------------------------------------ The remainder of the comments for this report are too long. To view the rest of the comments, please view the bug report online at http://bugs.php.net/bug.php?id=51063 -- Edit this bug report at http://bugs.php.net/bug.php?id=51063&edit=1
