Req #60760 [PATCH]: Converting zend_parse_parameters() to zend_parse_parameters_none()
Edit report at https://bugs.php.net/bug.php?id=60760edit=1 ID: 60760 Patch added by: le...@php.net Reported by:dragoo...@php.net Summary:Converting zend_parse_parameters() to zend_parse_parameters_none() Status: Assigned Type: Feature/Change Request Package:SPL related Operating System: N/A PHP Version:5 Assigned To:levim Block user comment: N Private report: N New Comment: The following patch has been added/updated: Patch Name: spl_zpp_none.diff Revision: 1379516433 URL: https://bugs.php.net/patch-display.php?bug=60760patch=spl_zpp_none.diffrevision=1379516433 Previous Comments: [2013-09-18 09:39:20] ni...@php.net @levi You should use the == FAILURE variant. Nearly all PHP code does the failure/success comparison at the end :) [2013-09-17 23:58:15] le...@php.net My latest patch changes a few of these. Also, there were two styles in use: if (zend_parse_parameters_none() == FAILURE) if (FAILURE == zend_parse_parameters_none()) I picked the latter as `if (FAILURE` indicates the purpose a bit better, in my opinion. If I should have picked the former: let me know and I'll attach a new patch. [2013-09-17 23:55:45] le...@php.net The following patch has been added/updated: Patch Name: spl_zpp_none.patch Revision: 1379462145 URL: https://bugs.php.net/patch-display.php?bug=60760patch=spl_zpp_none.patchrevision=1379462145 [2012-01-20 02:37:31] dragoo...@php.net This is just the way a lot of the phpsrc has been built. Look around various /ext/ places and you'll see it. I'm just cleaning things up and keeping consistency. Got a few more cleanup patches to submit on the SplHeap class for this same reason as i've been working on that class recently. - Paul. [2012-01-20 02:23:52] larue...@php.net if no parameters will be accpected, why call to zend_parse_parameters? just a arginfo will be enough. The remainder of the comments for this report are too long. To view the rest of the comments, please view the bug report online at https://bugs.php.net/bug.php?id=60760 -- Edit this bug report at https://bugs.php.net/bug.php?id=60760edit=1
Req #60760 [PATCH]: Converting zend_parse_parameters() to zend_parse_parameters_none()
Edit report at https://bugs.php.net/bug.php?id=60760edit=1 ID: 60760 Patch added by: le...@php.net Reported by:dragoo...@php.net Summary:Converting zend_parse_parameters() to zend_parse_parameters_none() Status: Assigned Type: Feature/Change Request Package:SPL related Operating System: N/A PHP Version:5 Assigned To:levim Block user comment: N Private report: N New Comment: The following patch has been added/updated: Patch Name: spl_zpp_none.patch Revision: 1379462145 URL: https://bugs.php.net/patch-display.php?bug=60760patch=spl_zpp_none.patchrevision=1379462145 Previous Comments: [2012-01-20 02:37:31] dragoo...@php.net This is just the way a lot of the phpsrc has been built. Look around various /ext/ places and you'll see it. I'm just cleaning things up and keeping consistency. Got a few more cleanup patches to submit on the SplHeap class for this same reason as i've been working on that class recently. - Paul. [2012-01-20 02:23:52] larue...@php.net if no parameters will be accpected, why call to zend_parse_parameters? just a arginfo will be enough. [2012-01-15 03:33:27] dragoo...@php.net The following patch has been added/updated: Patch Name: spl_dllist_zend_parse_parameters_none.diff Revision: 1326598407 URL: https://bugs.php.net/patch-display.php?bug=60760patch=spl_dllist_zend_parse_parameters_none.diffrevision=1326598407 [2012-01-15 03:32:21] dragoo...@php.net Description: Half of the file base uses zend_parse_parameters() to check if theres no params passed. Half of the file already uses zend_parse_parameters_none(). The work done here just updates zend_parse_parameters() calls to zend_parse_parameters_none() where necessary. Test script: --- N/A Expected result: N/A Actual result: -- N/A -- Edit this bug report at https://bugs.php.net/bug.php?id=60760edit=1
Req #60760 [PATCH]: Converting zend_parse_parameters() to zend_parse_parameters_none()
Edit report at https://bugs.php.net/bug.php?id=60760edit=1 ID: 60760 Patch added by: dragoo...@php.net Reported by:dragoo...@php.net Summary:Converting zend_parse_parameters() to zend_parse_parameters_none() Status: Open Type: Feature/Change Request Package:SPL related Operating System: N/A PHP Version:5.4.0RC5 Block user comment: N Private report: N New Comment: The following patch has been added/updated: Patch Name: spl_dllist_zend_parse_parameters_none.diff Revision: 1326598407 URL: https://bugs.php.net/patch-display.php?bug=60760patch=spl_dllist_zend_parse_parameters_none.diffrevision=1326598407 Previous Comments: [2012-01-15 03:32:21] dragoo...@php.net Description: Half of the file base uses zend_parse_parameters() to check if theres no params passed. Half of the file already uses zend_parse_parameters_none(). The work done here just updates zend_parse_parameters() calls to zend_parse_parameters_none() where necessary. Test script: --- N/A Expected result: N/A Actual result: -- N/A -- Edit this bug report at https://bugs.php.net/bug.php?id=60760edit=1
