[PHP-CVS-DAILY] cvs: ZendEngine2 / ChangeLog

2005-04-23 Thread changelog
changelog   Sat Apr 23 20:33:38 2005 EDT

  Modified files:  
/ZendEngine2ChangeLog 
  Log:
  ChangeLog update
  
http://cvs.php.net/diff.php/ZendEngine2/ChangeLog?r1=1.677r2=1.678ty=u
Index: ZendEngine2/ChangeLog
diff -u ZendEngine2/ChangeLog:1.677 ZendEngine2/ChangeLog:1.678
--- ZendEngine2/ChangeLog:1.677 Thu Apr 21 20:45:41 2005
+++ ZendEngine2/ChangeLog   Sat Apr 23 20:33:38 2005
@@ -1,3 +1,10 @@
+2005-04-23  Marcus Boerger  [EMAIL PROTECTED]
+
+* tests/bug29674.phpt
+  tests/bug30161.phpt
+  tests/bug30346.phpt:
+  - Add new tests
+
 2005-04-21  Jani Taskinen  [EMAIL PROTECTED]
 
 * tests/unset_cv05.phpt:
@@ -7588,7 +7595,7 @@
 2003-06-10  Jani Taskinen  [EMAIL PROTECTED]
 
 * zend_multiply.h:
-  - Missing $Id: ChangeLog,v 1.677 2005/04/22 00:45:41 changelog Exp $ tag
+  - Missing $Id: ChangeLog,v 1.678 2005/04/24 00:33:38 changelog Exp $ tag
 
 2003-06-10  James Cox  [EMAIL PROTECTED]
 
@@ -9312,7 +9319,7 @@
   zend_types.h
   zend_variables.c
   zend_variables.h:
-  - Added some missing CVS $Id: ChangeLog,v 1.677 2005/04/22 00:45:41 
changelog Exp $ tags, headers and footers.
+  - Added some missing CVS $Id: ChangeLog,v 1.678 2005/04/24 00:33:38 
changelog Exp $ tags, headers and footers.
 
 2003-01-30  Ilia Alshanetsky  [EMAIL PROTECTED]
 


[PHP-CVS-DAILY] cvs: php-src / ChangeLog

2005-04-23 Thread changelog
changelog   Sat Apr 23 20:33:24 2005 EDT

  Modified files:  
/php-srcChangeLog 
  Log:
  ChangeLog update
  
http://cvs.php.net/diff.php/php-src/ChangeLog?r1=1.1962r2=1.1963ty=u
Index: php-src/ChangeLog
diff -u php-src/ChangeLog:1.1962 php-src/ChangeLog:1.1963
--- php-src/ChangeLog:1.1962Fri Apr 22 20:35:03 2005
+++ php-src/ChangeLog   Sat Apr 23 20:33:23 2005
@@ -1,3 +1,37 @@
+2005-04-23  Jani Taskinen  [EMAIL PROTECTED]
+
+* (PHP_4_3)
+  NEWS
+  NEWS:
+  typo
+
+* ext/snmp/snmp.c:
+  - Fix memleak
+
+* (PHP_4_3)
+  NEWS
+  NEWS
+  main/php_variables.c
+  main/php_variables.c:
+  MFH: - Fixed bug #32111 (Cookies can also be separated by colon)
+
+* main/php_variables.c:
+  - Fixed bug #32111 (Cookies can also be separated by colon)
+
+* main/php_variables.c:
+  ws, pval - zval
+
+2005-04-23  Marcus Boerger  [EMAIL PROTECTED]
+
+* ZendEngine2/tests/bug29674.phpt
+  ZendEngine2/tests/bug30161.phpt
+  ZendEngine2/tests/bug30346.phpt
+  tests/classes/__set__get_004.phpt:
+  - Add new tests
+
+* acinclude.m4:
+  - Change bison check to positive logic and allow bison 2.0
+
 2005-04-22  Joe Orton  [EMAIL PROTECTED]
 
 * (PHP_4_3)
@@ -746,7 +780,7 @@
 
 * (PHP_4_3)
   ext/standard/url_scanner_ex.re:
-  Missing $Id: ChangeLog,v 1.1962 2005/04/23 00:35:03 changelog Exp $ tag
+  Missing $Id: ChangeLog,v 1.1963 2005/04/24 00:33:23 changelog Exp $ tag
 
 * (PHP_5_0)
   ext/standard/url_scanner_ex.c:
@@ -4147,7 +4181,7 @@
   ext/session/mod_mm.h
   ext/session/mod_user.h
   ext/session/php_session.h:
-  - Missing $Id: ChangeLog,v 1.1962 2005/04/23 00:35:03 changelog Exp $ 
tags
+  - Missing $Id: ChangeLog,v 1.1963 2005/04/24 00:33:23 changelog Exp $ 
tags
 
 * (PHP_4_3)
   ext/session/session.c:
@@ -4628,7 +4662,7 @@
 
 * (PHP_4_3)
   Zend/zend_ini_scanner.l:
-  Missing $Id: ChangeLog,v 1.1962 2005/04/23 00:35:03 changelog Exp $ tag 
+ ws fix
+  Missing $Id: ChangeLog,v 1.1963 2005/04/24 00:33:23 changelog Exp $ tag 
+ ws fix
 
 * ZendEngine2/zend_ini_scanner.l
   ZendEngine2/zend_ini_scanner.l:
@@ -6102,7 +6136,7 @@
   ext/standard/url_scanner_ex.c
   ext/standard/url_scanner_ex.h
   ext/standard/url_scanner_ex.re:
-  Missing $Id: ChangeLog,v 1.1962 2005/04/23 00:35:03 changelog Exp $ tag
+  Missing $Id: ChangeLog,v 1.1963 2005/04/24 00:33:23 changelog Exp $ tag
 
 * ext/standard/credits_ext.h
   ext/standard/credits_sapi.h:


Re: [PHP-CVS] cvs: php-src /ext/com_dotnet com_extension.c /sapi/caudium caudium.c

2005-04-23 Thread Wez Furlong
Bah, com is compiled on windows only using a compiler that groks c++ comments.
Please try to avoid changing files that don't really need it; I've
already got to manually merge a big COM/.Net patch because someone
removed some supposedly unused vars from that extension.

--Wez.

On 4/22/05, Antony Dovgal [EMAIL PROTECTED] wrote:
 tony2001Fri Apr 22 04:59:21 2005 EDT
 
   Modified files:
 /php-src/ext/com_dotnet com_extension.c

--
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php



Re: [PHP-CVS] cvs: php-src(PHP_5_0) /ext/mbstring/libmbfl/mbfl mbfilter.c

2005-04-23 Thread Masaki Fujimoto
Current one should be correct (I tested all the cases with my patch). 

Actually I also wondered, but it seems that former one (I mean for (i 
= num; --i = 0;) which is commited only to the PHP_5_0 branch) 
should be a trace of your first patch (in 2005/04/13).


The Message From Moriyoshi Koizumi on Sat, 23 Apr 2005 14:27:01 +0900:
 
 On 2005/04/22, at 14:03, Masaki Fujimoto wrote:
 
  @@ -571,7 +573,7 @@
  /* judge */
  encoding = NULL;
 
  -   for (i = num; --i = 0;) {
  +   for (i = 0; i  num; i++) {
  filter = flist[i];
  if (!filter-flag) {
  encoding = filter-encoding;
 
 
 Looks like this hunk of the change wasn't applied to the other two.
 
 http://cvs.php.net/diff.php/php-src/ext/mbstring/libmbfl/mbfl/ 
 mbfilter.c?r1=1.6r2=1.7ty=u
 http://cvs.php.net/diff.php/php-src/ext/mbstring/libmbfl/mbfl/ 
 mbfilter.c?r1=1.1.2.6r2=1.1.2.7ty=u
 
 Just wondering which patch is correct...
 
 Moriyoshi

-- 
Masaki Fujimoto
[EMAIL PROTECTED]

-- 
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php



[PHP-CVS] cvs: php-src / acinclude.m4

2005-04-23 Thread Marcus Boerger
helly   Sat Apr 23 07:30:12 2005 EDT

  Modified files:  
/php-srcacinclude.m4 
  Log:
  - Change bison check to positive logic and allow bison 2.0
  
http://cvs.php.net/diff.php/php-src/acinclude.m4?r1=1.299r2=1.300ty=u
Index: php-src/acinclude.m4
diff -u php-src/acinclude.m4:1.299 php-src/acinclude.m4:1.300
--- php-src/acinclude.m4:1.299  Wed Apr 20 16:48:19 2005
+++ php-src/acinclude.m4Sat Apr 23 07:30:11 2005
@@ -1,5 +1,5 @@
 dnl
-dnl $Id: acinclude.m4,v 1.299 2005/04/20 20:48:19 bfrance Exp $
+dnl $Id: acinclude.m4,v 1.300 2005/04/23 11:30:11 helly Exp $
 dnl
 dnl This file contains local autoconf functions.
 dnl
@@ -1936,10 +1936,10 @@
   if test $YACC = bison -y; then
 AC_CACHE_CHECK([for bison version], php_cv_bison_version, [
   set `bison --version| grep 'GNU Bison' | cut -d ' ' -f 4 | sed -e 's/\./ 
/'|tr -d a-z`
-  if test ${1} -ne 1 -o ( ${2} != 28 -a ${2} != 35 -a ${2} 
!= 75 -a ${2} != 875 ); then 
-php_cv_bison_version=invalid
-  else
+  if test ( ${1} = 1 -a ( ${2} = 28 -o ${2} = 35 -o ${2} 
= 75 -o ${2} = 875 ) ) -o ( ${1} = 2 -a ( ${2} = 0 ) 
); then
 php_cv_bison_version=${1}.${2} (ok)
+  else
+php_cv_bison_version=invalid
   fi
 ])
   fi

-- 
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php



[PHP-CVS] cvs: php-src /ext/sqlite/tests/pdo pdo_024.phpt /tests/classes __set__get_004.phpt

2005-04-23 Thread Marcus Boerger
helly   Sat Apr 23 11:21:07 2005 EDT

  Added files: 
/php-src/tests/classes  __set__get_004.phpt 
/php-src/ext/sqlite/tests/pdo   pdo_024.phpt 
  Log:
  - Add new tests
  

http://cvs.php.net/co.php/php-src/tests/classes/__set__get_004.phpt?r=1.1p=1
Index: php-src/tests/classes/__set__get_004.phpt
+++ php-src/tests/classes/__set__get_004.phpt
--TEST--
ZE2 __set() and __get()
--SKIPIF--
?php if (version_compare(zend_version(), '2.0.0-dev', '')) die('skip 
ZendEngine 2 needed'); ?
--FILE--
?php
class Test {
protected $x;

function __get($name) {
if (isset($this-x[$name])) {
return $this-x[$name];
} 
else
{
return NULL;
}
}

function __set($name, $val) {
$this-x[$name] = $val;
}
}

$foo = new Test();
$bar = new Test();
$bar-baz = Check;

$foo-bar = $bar;

var_dump($bar-baz);
var_dump($foo-bar-baz);

?
===DONE===
--EXPECTF--
string(5) Check
string(5) Check
===DONE===

http://cvs.php.net/co.php/php-src/ext/sqlite/tests/pdo/pdo_024.phpt?r=1.1p=1
Index: php-src/ext/sqlite/tests/pdo/pdo_024.phpt
+++ php-src/ext/sqlite/tests/pdo/pdo_024.phpt
--TEST--
PDO_SQLite2: Bind does not convert NULL
--SKIPIF--
?php # vim:ft=php
require_once('skipif.inc'); ?
--FILE--
?php

require_once('connection.inc');
require_once('prepare.inc');

require_once($PDO_TESTS . 'pdo_024.inc');

?
===DONE===
?php exit(0); ?
--EXPECTF--
bind: success
bool(true)
NULL
===DONE===

-- 
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php



[PHP-CVS] cvs: php-src /main php_variables.c

2005-04-23 Thread Jani Taskinen
sniper  Sat Apr 23 15:30:29 2005 EDT

  Modified files:  
/php-src/main   php_variables.c 
  Log:
  ws, pval - zval
  http://cvs.php.net/diff.php/php-src/main/php_variables.c?r1=1.88r2=1.89ty=u
Index: php-src/main/php_variables.c
diff -u php-src/main/php_variables.c:1.88 php-src/main/php_variables.c:1.89
--- php-src/main/php_variables.c:1.88   Mon Apr  4 11:06:33 2005
+++ php-src/main/php_variables.cSat Apr 23 15:30:29 2005
@@ -17,7 +17,7 @@
+--+
  */
 
-/* $Id: php_variables.c,v 1.88 2005/04/04 15:06:33 hirokawa Exp $ */
+/* $Id: php_variables.c,v 1.89 2005/04/23 19:30:29 sniper Exp $ */
 
 #include stdio.h
 #include php.h
@@ -28,10 +28,8 @@
 #include php_content_types.h
 #include SAPI.h
 #include php_logos.h
-
 #include zend_globals.h
 
-
 /* for systems that need to override reading of environment variables */
 void _php_import_environment_variables(zval *array_ptr TSRMLS_DC);
 PHPAPI void (*php_import_environment_variables)(zval *array_ptr TSRMLS_DC) = 
_php_import_environment_variables;
@@ -41,7 +39,6 @@
php_register_variable_safe(var, strval, strlen(strval), 
track_vars_array TSRMLS_CC);
 }
 
-
 /* binary-safe version */
 PHPAPI void php_register_variable_safe(char *var, char *strval, int str_len, 
zval *track_vars_array TSRMLS_DC)
 {
@@ -60,8 +57,7 @@
php_register_variable_ex(var, new_entry, track_vars_array TSRMLS_CC);
 }
 
-
-PHPAPI void php_register_variable_ex(char *var, zval *val, pval 
*track_vars_array TSRMLS_DC)
+PHPAPI void php_register_variable_ex(char *var, zval *val, zval 
*track_vars_array TSRMLS_DC)
 {
char *p = NULL;
char *ip;   /* index pointer */
@@ -69,7 +65,7 @@
int var_len, index_len;
zval *gpc_element, **gpc_element_p;
zend_bool is_array;
-   HashTable *symtable1=NULL;
+   HashTable *symtable1 = NULL;
 
assert(var != NULL);

@@ -105,7 +101,7 @@
}
/* ensure that we don't have spaces or dots in the variable name (not 
binary safe) */
for (p=var; *p; p++) {
-   switch(*p) {
+   switch (*p) {
case ' ':
case '.':
*p='_';
@@ -150,19 +146,19 @@
array_init(gpc_element);
zend_hash_next_index_insert(symtable1, 
gpc_element, sizeof(zval *), (void **) gpc_element_p);
} else {
-   if (PG(magic_quotes_gpc)  (index!=var)) {
+   if (PG(magic_quotes_gpc)  (index != var)) {
/* no need to addslashes() the index if 
it's the main variable name */
escaped_index = php_addslashes(index, 
index_len, index_len, 0 TSRMLS_CC);
} else {
escaped_index = index;
}
-   if (zend_symtable_find(symtable1, 
escaped_index, index_len+1, (void **) gpc_element_p)==FAILURE
+   if (zend_symtable_find(symtable1, 
escaped_index, index_len + 1, (void **) gpc_element_p) == FAILURE
|| Z_TYPE_PP(gpc_element_p) != 
IS_ARRAY) {
MAKE_STD_ZVAL(gpc_element);
array_init(gpc_element);
-   zend_symtable_update(symtable1, 
escaped_index, index_len+1, gpc_element, sizeof(zval *), (void **) 
gpc_element_p);
+   zend_symtable_update(symtable1, 
escaped_index, index_len + 1, gpc_element, sizeof(zval *), (void **) 
gpc_element_p);
}
-   if (index!=escaped_index) {
+   if (index != escaped_index) {
efree(escaped_index);
}
}
@@ -172,7 +168,7 @@
index_len = new_idx_len;
 
ip++;
-   if (*ip=='[') {
+   if (*ip == '[') {
is_array = 1;
*ip = 0;
} else {
@@ -187,7 +183,7 @@
zend_hash_next_index_insert(symtable1, 
gpc_element, sizeof(zval *), (void **) gpc_element_p);
} else {
char *escaped_index = php_addslashes(index, 
index_len, index_len, 0 TSRMLS_CC);
-   zend_symtable_update(symtable1, escaped_index, 
index_len+1, gpc_element, sizeof(zval *), (void **) gpc_element_p);
+   zend_symtable_update(symtable1, escaped_index, 
index_len + 1, gpc_element, sizeof(zval 

[PHP-CVS] cvs: php-src /main php_variables.c

2005-04-23 Thread Jani Taskinen
sniper  Sat Apr 23 16:33:35 2005 EDT

  Modified files:  
/php-src/main   php_variables.c 
  Log:
  - Fixed bug #32111 (Cookies can also be separated by colon)
  
http://cvs.php.net/diff.php/php-src/main/php_variables.c?r1=1.89r2=1.90ty=u
Index: php-src/main/php_variables.c
diff -u php-src/main/php_variables.c:1.89 php-src/main/php_variables.c:1.90
--- php-src/main/php_variables.c:1.89   Sat Apr 23 15:30:29 2005
+++ php-src/main/php_variables.cSat Apr 23 16:33:34 2005
@@ -17,7 +17,7 @@
+--+
  */
 
-/* $Id: php_variables.c,v 1.89 2005/04/23 19:30:29 sniper Exp $ */
+/* $Id: php_variables.c,v 1.90 2005/04/23 20:33:34 sniper Exp $ */
 
 #include stdio.h
 #include php.h
@@ -296,7 +296,7 @@
separator = (char *) estrdup(PG(arg_separator).input);
break;
case PARSE_COOKIE:
-   separator = ;\0;
+   separator = ;,\0; /* Cookies can be separated with , 
or ; */
break;
}


-- 
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php



[PHP-CVS] cvs: php-src(PHP_5_0) / NEWS /main php_variables.c

2005-04-23 Thread Jani Taskinen
sniper  Sat Apr 23 16:34:23 2005 EDT

  Modified files:  (Branch: PHP_5_0)
/php-srcNEWS 
/php-src/main   php_variables.c 
  Log:
  MFH: - Fixed bug #32111 (Cookies can also be separated by colon)
  
http://cvs.php.net/diff.php/php-src/NEWS?r1=1.1760.2.338r2=1.1760.2.339ty=u
Index: php-src/NEWS
diff -u php-src/NEWS:1.1760.2.338 php-src/NEWS:1.1760.2.339
--- php-src/NEWS:1.1760.2.338   Thu Apr 21 10:46:03 2005
+++ php-src/NEWSSat Apr 23 16:34:23 2005
@@ -36,6 +36,7 @@
 - Fixed bug #32405 (mysqli::fetch() returns bad data - 64bit problem). (Andrey)
 - Fixed bug #32282 (Segfault in mysqli_fetch_array on 64-bit). (Georg)
 - Fixed bug #32282 (Segfault in mysqli_fetch_array on 64-bit) (Georg).
+- Fixed bug #32111 (Cookies can also be separated by colon). (Jani)
 - Fixed bug #31887 (ISAPI: Custom 5xx error does not return correct HTTP 
   response message). (Jani)
 - Fixed bug #31636 (another crash when echoing a COM object). (Wez)
http://cvs.php.net/diff.php/php-src/main/php_variables.c?r1=1.81.2.4r2=1.81.2.5ty=u
Index: php-src/main/php_variables.c
diff -u php-src/main/php_variables.c:1.81.2.4 
php-src/main/php_variables.c:1.81.2.5
--- php-src/main/php_variables.c:1.81.2.4   Sun Apr  3 07:55:44 2005
+++ php-src/main/php_variables.cSat Apr 23 16:34:23 2005
@@ -17,7 +17,7 @@
+--+
  */
 
-/* $Id: php_variables.c,v 1.81.2.4 2005/04/03 11:55:44 tony2001 Exp $ */
+/* $Id: php_variables.c,v 1.81.2.5 2005/04/23 20:34:23 sniper Exp $ */
 
 #include stdio.h
 #include php.h
@@ -301,7 +301,7 @@
separator = (char *) estrdup(PG(arg_separator).input);
break;
case PARSE_COOKIE:
-   separator = ;\0;
+   separator = ;,\0; /* Cookies can be separated with , 
or ; */
break;
}


-- 
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php



[PHP-CVS] cvs: php-src /ext/snmp snmp.c

2005-04-23 Thread Jani Taskinen
sniper  Sat Apr 23 17:15:24 2005 EDT

  Modified files:  
/php-src/ext/snmp   snmp.c 
  Log:
  - Fix memleak
  
http://cvs.php.net/diff.php/php-src/ext/snmp/snmp.c?r1=1.101r2=1.102ty=u
Index: php-src/ext/snmp/snmp.c
diff -u php-src/ext/snmp/snmp.c:1.101 php-src/ext/snmp/snmp.c:1.102
--- php-src/ext/snmp/snmp.c:1.101   Fri Apr 15 18:06:03 2005
+++ php-src/ext/snmp/snmp.c Sat Apr 23 17:15:24 2005
@@ -20,7 +20,7 @@
+--+
  */
 
-/* $Id: snmp.c,v 1.101 2005/04/15 22:06:03 sniper Exp $ */
+/* $Id: snmp.c,v 1.102 2005/04/23 21:15:24 sniper Exp $ */
 
 #ifdef HAVE_CONFIG_H
 #include config.h
@@ -452,6 +452,8 @@
if (st == SNMP_CMD_GET) {
*return_value = *snmpval;
zval_copy_ctor(return_value);
+   zval_dtor(snmpval);
+   efree(snmpval);
snmp_close(ss);
return;
} else if (st == SNMP_CMD_GETNEXT) {

-- 
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php



[PHP-CVS] cvs: php-src(PHP_4_3) /ext/snmp snmp.c

2005-04-23 Thread Jani Taskinen
sniper  Sat Apr 23 17:15:39 2005 EDT

  Modified files:  (Branch: PHP_4_3)
/php-src/ext/snmp   snmp.c 
  Log:
  MFH: fix memleak
  
http://cvs.php.net/diff.php/php-src/ext/snmp/snmp.c?r1=1.70.2.19r2=1.70.2.20ty=u
Index: php-src/ext/snmp/snmp.c
diff -u php-src/ext/snmp/snmp.c:1.70.2.19 php-src/ext/snmp/snmp.c:1.70.2.20
--- php-src/ext/snmp/snmp.c:1.70.2.19   Fri Apr 15 18:08:43 2005
+++ php-src/ext/snmp/snmp.c Sat Apr 23 17:15:39 2005
@@ -20,7 +20,7 @@
   +--+
 */
 
-/* $Id: snmp.c,v 1.70.2.19 2005/04/15 22:08:43 sniper Exp $ */
+/* $Id: snmp.c,v 1.70.2.20 2005/04/23 21:15:39 sniper Exp $ */
 
 #ifdef HAVE_CONFIG_H
 #include config.h
@@ -442,6 +442,8 @@
if (st == 1) {
*return_value = *snmpval;
zval_copy_ctor(return_value);
+   zval_dtor(snmpval);
+   efree(snmpval);
snmp_close(ss);
return;
} else if (st == 2) {

-- 
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php



[PHP-CVS] cvs: php-src(PHP_5_0) /ext/snmp snmp.c

2005-04-23 Thread Jani Taskinen
sniper  Sat Apr 23 17:15:54 2005 EDT

  Modified files:  (Branch: PHP_5_0)
/php-src/ext/snmp   snmp.c 
  Log:
  MFH: fix memleak
  
http://cvs.php.net/diff.php/php-src/ext/snmp/snmp.c?r1=1.92.2.6r2=1.92.2.7ty=u
Index: php-src/ext/snmp/snmp.c
diff -u php-src/ext/snmp/snmp.c:1.92.2.6 php-src/ext/snmp/snmp.c:1.92.2.7
--- php-src/ext/snmp/snmp.c:1.92.2.6Fri Apr 15 18:07:05 2005
+++ php-src/ext/snmp/snmp.c Sat Apr 23 17:15:54 2005
@@ -20,7 +20,7 @@
+--+
  */
 
-/* $Id: snmp.c,v 1.92.2.6 2005/04/15 22:07:05 sniper Exp $ */
+/* $Id: snmp.c,v 1.92.2.7 2005/04/23 21:15:54 sniper Exp $ */
 
 #ifdef HAVE_CONFIG_H
 #include config.h
@@ -447,6 +447,8 @@
if (st == 1) {
*return_value = *snmpval;
zval_copy_ctor(return_value);
+   zval_dtor(snmpval);
+   efree(snmpval);
snmp_close(ss);
return;
} else if (st == 2) {

-- 
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php



Re: [PHP-CVS] cvs: php-src /main php_variables.c

2005-04-23 Thread Stefan Esser
Jani Taskinen wrote:
sniper  Sat Apr 23 16:33:35 2005 EDT
  Modified files:  
/php-src/main	php_variables.c 
  Log:
  - Fixed bug #32111 (Cookies can also be separated by colon)
Could you please revert that patch, or implement the RFC correctly?
Now PHP handles cookies in a completely RFC uncovered way.
Either we have support for , ;  or only for ; but not something in 
between. F.e. with your patch you just fucked modsecurity again which 
will fail to correctly detect evil cookie variables. No matter if you 
configure it to use V0 or V1 of its detection.

Stefan
--
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php


[PHP-CVS] cvs: php-src(PHP_4_3) / NEWS

2005-04-23 Thread Jani Taskinen
sniper  Sat Apr 23 19:57:42 2005 EDT

  Modified files:  (Branch: PHP_4_3)
/php-srcNEWS 
  Log:
  typo
  
http://cvs.php.net/diff.php/php-src/NEWS?r1=1.1247.2.884r2=1.1247.2.885ty=u
Index: php-src/NEWS
diff -u php-src/NEWS:1.1247.2.884 php-src/NEWS:1.1247.2.885
--- php-src/NEWS:1.1247.2.884   Sat Apr 23 16:34:14 2005
+++ php-src/NEWSSat Apr 23 19:57:40 2005
@@ -27,7 +27,7 @@
   (Uwe Schindler)
 - Fixed bug #32311 (mb_encode_mimeheader() does not properly escape 
characters).
   (Moriyoshi)
-- Fixed bug #32111 (Cookies can also be separated by colon). (Jani)
+- Fixed bug #32111 (Cookies can also be separated by comma). (Jani)
 - Fixed bug #31887 (ISAPI: Custom 5xx error does not return correct HTTP 
   response message). (Jani) 
 - Fixed bug #31583 (php_std_date() uses short day names in non-y2k_compliance 
mode).

-- 
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php



[PHP-CVS] cvs: php-src(PHP_5_0) / NEWS

2005-04-23 Thread Jani Taskinen
sniper  Sat Apr 23 19:57:56 2005 EDT

  Modified files:  (Branch: PHP_5_0)
/php-srcNEWS 
  Log:
  typo
  
http://cvs.php.net/diff.php/php-src/NEWS?r1=1.1760.2.339r2=1.1760.2.340ty=u
Index: php-src/NEWS
diff -u php-src/NEWS:1.1760.2.339 php-src/NEWS:1.1760.2.340
--- php-src/NEWS:1.1760.2.339   Sat Apr 23 16:34:23 2005
+++ php-src/NEWSSat Apr 23 19:57:56 2005
@@ -36,7 +36,7 @@
 - Fixed bug #32405 (mysqli::fetch() returns bad data - 64bit problem). (Andrey)
 - Fixed bug #32282 (Segfault in mysqli_fetch_array on 64-bit). (Georg)
 - Fixed bug #32282 (Segfault in mysqli_fetch_array on 64-bit) (Georg).
-- Fixed bug #32111 (Cookies can also be separated by colon). (Jani)
+- Fixed bug #32111 (Cookies can also be separated by comma). (Jani)
 - Fixed bug #31887 (ISAPI: Custom 5xx error does not return correct HTTP 
   response message). (Jani)
 - Fixed bug #31636 (another crash when echoing a COM object). (Wez)

-- 
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php