Mike:
you may want to review this fix, http://news.php.net/php.cvs/68772
, thanks
On Sun, Apr 15, 2012 at 1:00 PM, Laruence <larue...@php.net> wrote:
> On Sun, Apr 15, 2012 at 12:36 PM, Stas Malyshev <smalys...@sugarcrm.com>
> wrote:
>> Hi!
>>
>>>> I'm not sure this is a good idea - output buffers can include output
>>>> functions IIRC, but you have already shut down modules. I would be very,
>>> Stas, they are request shutdown, not module shutdown :)
>>
>> Request shutdown IIRC destroys functions and module's per-request data
>> structures, which user-supplied output handlers may need. Did you check
>> that user-supplied output handlers - especially those that use
>> extensions and per-request data structures - actually work after this
>> change?
>
> Ah, thanks, I got your point. but output handler is called in step 3:
> /* 3. Flush all output buffers */
>
> and as I said, all tests passed.
>
> anyway, you are right, we should be careful, I will double check it. :)
>
> thanks
>>
>> --
>> Stanislav Malyshev, Software Architect
>> SugarCRM: http://www.sugarcrm.com/
>> (408)454-6900 ext. 227
>
>
>
> --
> Laruence Xinchen Hui
> http://www.laruence.com/
--
Laruence Xinchen Hui
http://www.laruence.com/
--
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php
