Re: [PHP-CVS] com php-src: Remove a useless memory write in zend_llist_del_element: Zend/zend_llist.c

2012-12-26 Thread Pierrick Charron 
Sorry about that. I thought it was a small change safe enough to be
committed without asking to the list but apparently I was wrong. I'm
going to revert it right now on 5.3 and 5.4, but just for my personnel
knowledge, could you tell me what kind of problem this change can
introduce ?

Thanks
Pierrick

On 26 December 2012 01:31, Stas Malyshev smalys...@sugarcrm.com wrote:
 Hi!



 On 12/25/2012 05:45 PM, Pierrick Charron wrote:
 Commit:fad960a4045da86cdbd8308a165ffc47892f05b9
 Author:Pierrick Charron pierr...@php.net Tue, 25 Dec 2012 
 20:45:24 -0500
 Parents:   a2b6d9c1047a4e5f3419ebc3489a66d62aa12d07
 Branches:  PHP-5.3 PHP-5.4 PHP-5.5 master

 Link:   
 http://git.php.net/?p=php-src.git;a=commitdiff;h=fad960a4045da86cdbd8308a165ffc47892f05b9

 Log:
 Remove a useless memory write in zend_llist_del_element

 The zend_llist_element *next pointer is not necessary and removing
 it will also remove a write on memory

 Was this really worth potentially destabilizing 5.3 to change?  Or even 5.4?

 I don't think so. And BTW, why no asking maintainers about this? It's
 not even a bug fix as far as I can see. Could you please do it in 5.5+?


 --
 Stanislav Malyshev, Software Architect
 SugarCRM: http://www.sugarcrm.com/
 (408)454-6900 ext. 227

-- 
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php

[PHP-CVS] com php-src: Revert Remove a useless memory write in zend_llist_del_element: Zend/zend_llist.c

2012-12-26 Thread Pierrick Charron 
Commit:b35ffdeae10eb1b71470eb831c02b3b7b838945d
Author:Pierrick Charron pierr...@php.net Wed, 26 Dec 2012 
10:13:56 -0500
Parents:   fad960a4045da86cdbd8308a165ffc47892f05b9
Branches:  PHP-5.3 PHP-5.4 PHP-5.5 master

Link:   
http://git.php.net/?p=php-src.git;a=commitdiff;h=b35ffdeae10eb1b71470eb831c02b3b7b838945d

Log:
Revert Remove a useless memory write in zend_llist_del_element

This reverts commit fad960a4045da86cdbd8308a165ffc47892f05b9 as
required by Stas and Christopher

Changed paths:
  M  Zend/zend_llist.c


Diff:
diff --git a/Zend/zend_llist.c b/Zend/zend_llist.c
index 26baf4d..4656420 100644
--- a/Zend/zend_llist.c
+++ b/Zend/zend_llist.c
@@ -91,13 +91,15 @@ ZEND_API void zend_llist_prepend_element(zend_llist *l, 
void *element)
 ZEND_API void zend_llist_del_element(zend_llist *l, void *element, int 
(*compare)(void *element1, void *element2))
 {
zend_llist_element *current=l-head;
+   zend_llist_element *next;
 
while (current) {
+   next = current-next;
if (compare(current-data, element)) {
DEL_LLIST_ELEMENT(current, l);
break;
}
-   current = current-next;
+   current = next;
}
 }


--
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php