Re: [PHP-CVS] cvs: php4 /ext/gd gd.c

2002-10-11 Thread Pierre-Alain Joye

On Fri, 11 Oct 2002 05:53:18 -0700 (PDT)
Rasmus Lerdorf <[EMAIL PROTECTED]> wrote:

> I don't think we can do that.  Like someone said, they have to use GIF
> in order to generate images for a mobile device.  That means they
> either need to use GD-1.3 or a hacked up later version.

Is only the compression system licenced ? Anyway, that is not too
difficult to add GIF support to the bundled (maybe not in the upcoming
release), regardless to the licence, which I did not take about it as
far as I do not use gif anymore.

pa

-- 
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php




Re: [PHP-CVS] cvs: php4 /ext/gd gd.c

2002-10-11 Thread Pierre-Alain Joye

On Fri, 11 Oct 2002 14:32:22 +0200
Andi Gutmans <[EMAIL PROTECTED]> wrote:

> I don't think this is a good idea. I'd definitely change the name to 
> GD_something but it still doesn't make so much sense to me. When would
> 
> people use this and not function_exists()?

When they ll realize function_exists is not a good thing to do with gd
functions :)

pa

-- 
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php




Re: [PHP-CVS] cvs: php4 /ext/gd gd.c

2002-10-11 Thread Pierre-Alain Joye

On Fri, 11 Oct 2002 14:45:22 +0200
Andi Gutmans <[EMAIL PROTECTED]> wrote:

> 
> In that case we should maybe consider to only allow the bundled one.

imho, Definitely a good thing, less confusion, and (maybe ;) ) more
stable.

pa




-- 
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php




Re: [PHP-CVS] cvs: php4 /main config.w32.h.in

2002-10-16 Thread Pierre-Alain Joye

On Wed, 16 Oct 2002 14:53:34 -
"Sebastian Bergmann" <[EMAIL PROTECTED]> wrote:

:

Cannot test the stuffs ;)

What s happened ? or where is actually the error/problem ?


pa

-- 
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php




Re: [PHP-CVS] cvs: php4 /ext/gd/libgd gd.c gd_gd2.c gdft.c

2002-11-12 Thread Pierre-Alain Joye
Hello,

On Tue, 12 Nov 2002 13:12:59 -

"Marcus Boerger" <[EMAIL PROTECTED]> wrote:

> helly Tue Nov 12 08:12:59 2002 EDT
> 
>   Modified files:  
> /php4/ext/gd/libgdgd.c gd_gd2.c gdft.c 
>   Log:
>   fix warnings

Thx to fix warnings :-)

While you are on, here are some warns I got on gd_png.c (-W
-g3):

php4/ext/gd/libgd/gd_png.c: In function `gdImageCreateFromPngCtx':
php4/ext/gd/libgd/gd_png.c:126: warning: variable `image_data' might be
clobbered by `longjmp' or `vfork'
php4/ext/gd/libgd/gd_png.c:127: warning: variable `row_pointers' might
be clobbered by `longjmp' or `vfork'
php4/ext/gd/libgd/gd_png.c:129: warning: variable `open' might be
clobbered by `longjmp' or `vfork'
php4/ext/gd/libgd/gd_png.c: In function `gdImagePngCtx':
php4/ext/gd/libgd/gd_png.c:447: warning: variable `bit_depth' might be
clobbered by `longjmp' or `vfork'
php4/ext/gd/libgd/gd_png.c:450: warning: variable `colors' might be
clobbered by `longjmp' or `vfork'

hth

pa

-- 
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php




[PHP-CVS] cvs: php4 /ext/gd gd.c

2002-12-03 Thread Pierre-Alain Joye
pajoye  Tue Dec  3 21:37:21 2002 EDT

  Modified files:  
/php4/ext/gdgd.c 
  Log:
  Fix imagegd crashes when used with truecolor image (from jpeg,png, or 
imagecreatetruecolor)
  may we add parameters to imagegd to let user specify the palette size and dither 
(set to 256 and true) ?
  
  
Index: php4/ext/gd/gd.c
diff -u php4/ext/gd/gd.c:1.229 php4/ext/gd/gd.c:1.230
--- php4/ext/gd/gd.c:1.229  Thu Nov 28 17:48:20 2002
+++ php4/ext/gd/gd.cTue Dec  3 21:37:21 2002
@@ -18,7 +18,7 @@
+--+
  */
 
-/* $Id: gd.c,v 1.229 2002/11/28 22:48:20 helly Exp $ */
+/* $Id: gd.c,v 1.230 2002/12/04 02:37:21 pajoye Exp $ */
 
 /* gd 1.2 is copyright 1994, 1995, Quest Protein Database Center, 
Cold Spring Harbor Labs. */
@@ -1588,6 +1588,12 @@
if(gdImageRed(im, i) == 0) break;
}
(*func_p)(im, i, fp);
+   break;
+   case PHP_GDIMG_TYPE_GD:
+   if(im->trueColor){
+   gdImageTrueColorToPalette(im,1,255);
+   }
+   (*func_p)(im, fp);
break;
default:
(*func_p)(im, fp);



-- 
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php




[PHP-CVS] cvs: php4 /ext/gd gd.c

2002-12-03 Thread Pierre-Alain Joye
pajoye  Tue Dec  3 21:48:23 2002 EDT

  Modified files:  
/php4/ext/gdgd.c 
  Log:
  Fix imagegd stdoutput
  Typo 256 colors
  
  
Index: php4/ext/gd/gd.c
diff -u php4/ext/gd/gd.c:1.230 php4/ext/gd/gd.c:1.231
--- php4/ext/gd/gd.c:1.230  Tue Dec  3 21:37:21 2002
+++ php4/ext/gd/gd.cTue Dec  3 21:48:23 2002
@@ -18,7 +18,7 @@
+--+
  */
 
-/* $Id: gd.c,v 1.230 2002/12/04 02:37:21 pajoye Exp $ */
+/* $Id: gd.c,v 1.231 2002/12/04 02:48:23 pajoye Exp $ */
 
 /* gd 1.2 is copyright 1994, 1995, Quest Protein Database Center, 
Cold Spring Harbor Labs. */
@@ -1591,7 +1591,7 @@
break;
case PHP_GDIMG_TYPE_GD:
if(im->trueColor){
-   gdImageTrueColorToPalette(im,1,255);
+   gdImageTrueColorToPalette(im,1,256);
}
(*func_p)(im, fp);
break;
@@ -1626,6 +1626,12 @@
}
(*func_p)(im, q, tmp);
break;
+case PHP_GDIMG_TYPE_GD:
+if(im->trueColor){
+   gdImageTrueColorToPalette(im,1,256);
+   }
+(*func_p)(im, tmp);
+break;
default:
(*func_p)(im, tmp);
break;



-- 
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php