AW: [PHP-CVS] cvs: php-src(PHP_5_2) /ext/spl/tests spl_classes.phpt /ext/standard/tests/general_functions call_user_method.phpt /ext/standard/tests/versioning php_sapi_name_variation001.phpt

2009-04-26 Thread S . Schürmann

Hey. 

I will add some variants that are working with pass sections for each PHP 
Version. 

Sebastian



- Ursprüngliche Mail 
Von: Kalle Sommer Nielsen ka...@php.net
An: Sebastian Schürmann s...@php.net
CC: php-cvs@lists.php.net
Gesendet: Montag, den 27. April 2009, 02:09:41 Uhr
Betreff: Re: [PHP-CVS] cvs: php-src(PHP_5_2) /ext/spl/tests spl_classes.phpt  
/ext/standard/tests/general_functions call_user_method.phpt  
/ext/standard/tests/versioning php_sapi_name_variation001.phpt

Hi Sebastian

2009/4/27 Sebastian Schürmann s...@php.net:
 sebsSun Apr 26 23:54:12 2009 UTC

  Modified files:  (Branch: PHP_5_2)
/php-src/ext/spl/tests  spl_classes.phpt
/php-src/ext/standard/tests/general_functions   call_user_method.phpt
/php-src/ext/standard/tests/versioning
php_sapi_name_variation001.phpt
  Log:
  - fixes to tests
  - spl_classes only checks  for is_array(), the output in 5_3_0 and 5_2_0 is 
 very different,
  test will run this way in 5.2 and 5.3 w.o. problems
  - call user method recognizes the different errormessage in 5_2_0 now
  - the php_sap_name_variation001 check now goes for cgi instead of the 
 cgi-fcgi output string


  --FILE--
  ?php
 -var_dump(spl_classes());
 +var_dump(is_array(spl_classes()));
  ?

The only thing thats different with spl_classes() in 5.2  5.3+ is
just that in 5.3 a few more classes have been added, I still think its
better to have them listed else the test seems pretty much pointless
here as spl_classes() always returns an array.

  --EXPECT--

 [snip]

 --
 PHP CVS Mailing List (http://www.php.net/)
 To unsubscribe, visit: http://www.php.net/unsub.php



regrads

-- 
Kalle Sommer Nielsen
ka...@php.net






--
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php



AW: AW: [PHP-CVS] cvs: php-src(PHP_5_2) /ext/spl/tests spl_classes.phpt /ext/standard/tests/general_functions call_user_method.phpt /ext/standard/tests/versioning php_sapi_name_variation001.phpt

2009-04-26 Thread S . Schürmann

And: 

Thanks for the feedback ;) 

S. 




- Ursprüngliche Mail 
Von: S. Schürmann sschuermann...@yahoo.de
An: Kalle Sommer Nielsen ka...@php.net; Sebastian Schürmann s...@php.net
CC: php-cvs@lists.php.net
Gesendet: Montag, den 27. April 2009, 02:13:26 Uhr
Betreff: AW: [PHP-CVS] cvs: php-src(PHP_5_2) /ext/spl/tests spl_classes.phpt  
/ext/standard/tests/general_functions call_user_method.phpt  
/ext/standard/tests/versioning php_sapi_name_variation001.phpt

Hey. 

I will add some variants that are working with pass sections for each PHP 
Version. 

Sebastian



- Ursprüngliche Mail 
Von: Kalle Sommer Nielsen ka...@php.net
An: Sebastian Schürmann s...@php.net
CC: php-cvs@lists.php.net
Gesendet: Montag, den 27. April 2009, 02:09:41 Uhr
Betreff: Re: [PHP-CVS] cvs: php-src(PHP_5_2) /ext/spl/tests spl_classes.phpt  
/ext/standard/tests/general_functions call_user_method.phpt  
/ext/standard/tests/versioning php_sapi_name_variation001.phpt

Hi Sebastian

2009/4/27 Sebastian Schürmann s...@php.net:
 sebsSun Apr 26 23:54:12 2009 UTC

  Modified files:  (Branch: PHP_5_2)
/php-src/ext/spl/tests  spl_classes.phpt
/php-src/ext/standard/tests/general_functions   call_user_method.phpt
/php-src/ext/standard/tests/versioning
php_sapi_name_variation001.phpt
  Log:
  - fixes to tests
  - spl_classes only checks  for is_array(), the output in 5_3_0 and 5_2_0 is 
 very different,
  test will run this way in 5.2 and 5.3 w.o. problems
  - call user method recognizes the different errormessage in 5_2_0 now
  - the php_sap_name_variation001 check now goes for cgi instead of the 
 cgi-fcgi output string


  --FILE--
  ?php
 -var_dump(spl_classes());
 +var_dump(is_array(spl_classes()));
  ?

The only thing thats different with spl_classes() in 5.2  5.3+ is
just that in 5.3 a few more classes have been added, I still think its
better to have them listed else the test seems pretty much pointless
here as spl_classes() always returns an array.

  --EXPECT--

 [snip]

 --
 PHP CVS Mailing List (http://www.php.net/)
 To unsubscribe, visit: http://www.php.net/unsub.php



regrads

-- 
Kalle Sommer Nielsen
ka...@php.net





--
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php



AW: [PHP-CVS] cvs: php-src(PHP_5_3) /ext/standard/tests/versioning php_sapi_name_variation001.phpt

2009-04-25 Thread S . Schürmann

Hello

Thanks for the heads up. The answer is that i made a mistake not starting 6.0 
and i am not yet finished. 
Ill change my way of work and go test by test adding to all branches.  Dont 
mind hinting me about other tthings you see. 

ty 

Sebastian 




- Ursprüngliche Mail 
Von: Jani Taskinen jani.taski...@sci.fi
An: Sebastian Schürmann s...@php.net; php-cvs@lists.php.net
Gesendet: Samstag, den 25. April 2009, 16:13:33 Uhr
Betreff: Re: [PHP-CVS] cvs: php-src(PHP_5_3) /ext/standard/tests/versioning 
php_sapi_name_variation001.phpt

Sebastian Schürmann kirjoitti:
 sebsSat Apr 25 11:33:26 2009 UTC
 
   Added files: (Branch: PHP_5_3)
 /php-src/ext/standard/tests/versioning
   php_sapi_name_variation001.phpt 
   Log:
   - Initial commit

 http://cvs.php.net/viewvc.cgi/php-src/ext/standard/tests/versioning/php_sapi_name_variation001.phpt?view=markuprev=1.1
 Index: php-src/ext/standard/tests/versioning/php_sapi_name_variation001.phpt
 +++ php-src/ext/standard/tests/versioning/php_sapi_name_variation001.phpt
 

Why are you committing tests only to PHP_5_3 branch and not to HEAD / PHP_5_2 ?

--Jani





--
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php