[PHP-CVS] Re: [PHP-DEV] Re: [PHP-CVS] cvs: php-src /ext/session/tests 020.phpt

2008-09-07 Thread Jani Taskinen

Pierre Joye kirjoitti:

hi Bjori,

On Sun, Sep 7, 2008 at 3:44 PM, Hannes Magnusson
[EMAIL PROTECTED] wrote:


I don't understand...
Does arg_separator.output=amp; in php.ini not work on windows - or
is this a bug in run-tests.php?


It does not. run-tests should take care of escaping the cmd line
arguments arguments using escapeshellargs. We can then use:

inisetting=amp;

instead of

inisetting=amp;

Especially as  is not always portable.


Just use single quotes then.. where the hell isn't  portable? Windows?
What in this isn't portable???

--Jani

--
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php



[PHP-CVS] Re: [PHP-DEV] Re: [PHP-CVS] cvs: php-src /ext/session/tests 020.phpt

2008-09-07 Thread Kalle Sommer Nielsen
Hi Jani

2008/9/7 Jani Taskinen [EMAIL PROTECTED]

 Pierre Joye kirjoitti:

 hi Bjori,

 On Sun, Sep 7, 2008 at 3:44 PM, Hannes Magnusson
 [EMAIL PROTECTED] wrote:

 I don't understand...
 Does arg_separator.output=amp; in php.ini not work on windows - or
 is this a bug in run-tests.php?


 It does not. run-tests should take care of escaping the cmd line
 arguments arguments using escapeshellargs. We can then use:

 inisetting=amp;

 instead of

 inisetting=amp;

 Especially as  is not always portable.


 Just use single quotes then.. where the hell isn't  portable? Windows?
 What in this isn't portable???


Windows uses double quotes on command line for php, eg. this will result in
a parse error (Unexpected character in input (ASCII=39):
php -r 'echo test;'

However the following works:
php -r echo test;
I don't know what, why ect. but inside run-tests.php (as Pierre said) using
double
quotes in INI section will break out of the string generated by
settings2params()
in run-tests.php and try to execute another command, since it breaks out on
020.phpt
in session it will generate two popups (MessageBox()) calls saying Invalid
configuration
directive.

I asked Felipe on IRC and he said the test didn't break without quotes on
Linux. But either
way this needs to be fixed insted of this work-a-around.




 --Jani



Cheers

-- 
Kalle Sommer Nielsen