[PHP-CVS] com karma: Remove the branch emails: lib/Git/PostReceiveHook.php

[David Soria Parra]

Commit:2b3dd00e18e1fb94b2194820257e06a2e1243838
Author:David Soria Parra d...@php.net Tue, 20 Mar 2012 19:01:11 
+0100
Parents:   148ceef33ccd6edb12a4f6d962bd2a3860557415
Branches:   master

Link:   
http://git.php.net/?p=karma.git;a=commitdiff;h=2b3dd00e18e1fb94b2194820257e06a2e1243838

Log:
Remove the branch emails

Branch emails are only useful if we have more than one commit. Then still
you are most likely only interested in the commits itself. We will come up
with a solution that sends out branch mails but reduce noise in general
in the future.

Changed paths:
  M  lib/Git/PostReceiveHook.php


Diff:
2b3dd00e18e1fb94b2194820257e06a2e1243838
diff --git a/lib/Git/PostReceiveHook.php b/lib/Git/PostReceiveHook.php
index 314ca86..3cf6ec8 100644
--- a/lib/Git/PostReceiveHook.php
+++ b/lib/Git/PostReceiveHook.php
@@ -84,8 +84,6 @@ class PostReceiveHook extends ReceiveHook
 foreach ($this-refs as $ref) {
 if ($ref['reftype'] == self::REF_TAG) {
 $this-sendTagMail($ref['refname'], $ref['changetype'], 
$ref['old'], $ref['new']);
-} elseif ($ref['reftype'] == self::REF_BRANCH){
-$this-branchesMailIds[$ref['refname']] = 
$this-sendBranchMail($ref['refname'], $ref['changetype'], $ref['old'], 
$ref['new']);
 }
 }
 
@@ -573,12 +571,6 @@ class PostReceiveHook extends ReceiveHook
 $mail-setFrom($this-pushAuthor . '@php.net', 
$this-pushAuthorName);
 $mail-addTo($this-mailingList);
 
-foreach ($branches as $branch) {
-if (isset($this-branchesMailIds[$branch])) {
-$mail-addReplyTo($this-branchesMailIds[$branch]);
-}
-}
-
 $mail-send();
 }
 }


--
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-CVS] com karma: Remove the branch emails: lib/Git/PostReceiveHook.php

[Alexander Moskaliov]

In  sendBranchMail  we call  getBranchRevisions method.
In this method we cache revisions in $this-revisions. So now we have
$this-revisions empty, because remove sendBranchMail  call.
With regards, Alexander Moskaliov
ir...@irker.net


2012/3/20 David Soria Parra d...@php.net

 sendBranchMail

--
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php

[PHP-CVS] com karma: Remove the branch emails: lib/Git/PostReceiveHook.php

[David Soria Parra]

Commit:2b3dd00e18e1fb94b2194820257e06a2e1243838
Author:David Soria Parra d...@php.net Tue, 20 Mar 2012 19:01:11 
+0100
Parents:   148ceef33ccd6edb12a4f6d962bd2a3860557415
Branches:  master

Link:   
http://git.php.net/?p=karma.git;a=commitdiff;h=2b3dd00e18e1fb94b2194820257e06a2e1243838

Log:
Remove the branch emails

Branch emails are only useful if we have more than one commit. Then still
you are most likely only interested in the commits itself. We will come up
with a solution that sends out branch mails but reduce noise in general
in the future.

Changed paths:
  M  lib/Git/PostReceiveHook.php


Diff:
2b3dd00e18e1fb94b2194820257e06a2e1243838
diff --git a/lib/Git/PostReceiveHook.php b/lib/Git/PostReceiveHook.php
index 314ca86..3cf6ec8 100644
--- a/lib/Git/PostReceiveHook.php
+++ b/lib/Git/PostReceiveHook.php
@@ -84,8 +84,6 @@ class PostReceiveHook extends ReceiveHook
 foreach ($this-refs as $ref) {
 if ($ref['reftype'] == self::REF_TAG) {
 $this-sendTagMail($ref['refname'], $ref['changetype'], 
$ref['old'], $ref['new']);
-} elseif ($ref['reftype'] == self::REF_BRANCH){
-$this-branchesMailIds[$ref['refname']] = 
$this-sendBranchMail($ref['refname'], $ref['changetype'], $ref['old'], 
$ref['new']);
 }
 }
 
@@ -573,12 +571,6 @@ class PostReceiveHook extends ReceiveHook
 $mail-setFrom($this-pushAuthor . '@php.net', 
$this-pushAuthorName);
 $mail-addTo($this-mailingList);
 
-foreach ($branches as $branch) {
-if (isset($this-branchesMailIds[$branch])) {
-$mail-addReplyTo($this-branchesMailIds[$branch]);
-}
-}
-
 $mail-send();
 }
 }


--
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php