Re: [PHP-CVS] com php-src: fix build - PRIu64 vs %I64u: main/php_variables.c

2013-09-18 Thread Michael Wallner
On 17 September 2013 16:02, Anatol Belski a...@php.net wrote:
 Commit:4a85b5e190d6651bee26bbbeff4ed09d2932f352
 Author:Anatol Belski a...@php.net Tue, 17 Sep 2013 16:02:08 
 +0200
 Parents:   e6084da4735c945cb071c4d9259ea0d702eb77c6
 Branches:  master

 Link:   
 http://git.php.net/?p=php-src.git;a=commitdiff;h=4a85b5e190d6651bee26bbbeff4ed09d2932f352

 Log:
 fix build - PRIu64 vs %I64u


How about adding such constants to win32/php_stdint.h instead?

-- 
Regards,
Mike

-- 
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php



Re: [PHP-CVS] com php-src: fix build - PRIu64 vs %I64u: main/php_variables.c

2013-09-18 Thread Anatol Belski
On Wed, September 18, 2013 09:52, Michael Wallner wrote:
 On 17 September 2013 16:02, Anatol Belski a...@php.net wrote:

 Commit:4a85b5e190d6651bee26bbbeff4ed09d2932f352
 Author:Anatol Belski a...@php.net Tue, 17 Sep 2013 16:02:08
 +0200
 Parents:   e6084da4735c945cb071c4d9259ea0d702eb77c6
 Branches:  master


 Link:
 http://git.php.net/?p=php-src.git;a=commitdiff;h=4a85b5e190d6651bee26bb
 beff4ed09d2932f352

 Log:
 fix build - PRIu64 vs %I64u


 How about adding such constants to win32/php_stdint.h instead?


 --
 Regards,
 Mike



That's a good idea, i also thought about macrifying all those at once. Not
sure it belongs to stdint, it's actually more like printf format. I'll do
this anyway, have to look for a right place.

Regards

Anatol


-- 
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php



Re: [PHP-CVS] com php-src: fix build - PRIu64 vs %I64u: main/php_variables.c

2013-09-18 Thread Michael Wallner
Hi Anatol!

On 18 September 2013 10:34, Anatol Belski a...@php.net wrote:
 That's a good idea, i also thought about macrifying all those at once. Not
 sure it belongs to stdint, it's actually more like printf format. I'll do
 this anyway, have to look for a right place.

POSIX has it in inttypes.h



-- 
Regards,
Mike

-- 
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php



Re: [PHP-CVS] com php-src: fix build - PRIu64 vs %I64u: main/php_variables.c

2013-09-18 Thread Anatol Belski
On Wed, September 18, 2013 10:59, Michael Wallner wrote:
 Hi Anatol!


 On 18 September 2013 10:34, Anatol Belski a...@php.net wrote:

 That's a good idea, i also thought about macrifying all those at once.
 Not
 sure it belongs to stdint, it's actually more like printf format. I'll
 do this anyway, have to look for a right place.

 POSIX has it in inttypes.h




 --
 Regards,
 Mike



Hi Michael,

oki then, i'll rework this fix to put it to win/php_stdint.h

Regards

Anatol


-- 
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php



[PHP-CVS] com php-src: fix build - PRIu64 vs %I64u: main/php_variables.c

2013-09-17 Thread Anatol Belski
Commit:4a85b5e190d6651bee26bbbeff4ed09d2932f352
Author:Anatol Belski a...@php.net Tue, 17 Sep 2013 16:02:08 +0200
Parents:   e6084da4735c945cb071c4d9259ea0d702eb77c6
Branches:  master

Link:   
http://git.php.net/?p=php-src.git;a=commitdiff;h=4a85b5e190d6651bee26bbbeff4ed09d2932f352

Log:
fix build - PRIu64 vs %I64u

Changed paths:
  M  main/php_variables.c


Diff:
diff --git a/main/php_variables.c b/main/php_variables.c
index af3a6aa..353aa63 100644
--- a/main/php_variables.c
+++ b/main/php_variables.c
@@ -292,7 +292,11 @@ static inline int add_post_vars(zval *arr, post_var_data_t 
*vars, zend_bool eof
while (add_post_var(arr, vars, eof TSRMLS_CC)) {
if (++vars-cnt  max_vars) {
php_error_docref(NULL TSRMLS_CC, E_WARNING,
+#ifdef PHP_WIN32
+   Input variables exceeded %I64u. 
+#else
Input variables exceeded % PRIu64 . 
+#endif
To increase the limit change 
max_input_vars in php.ini.,
max_vars);
return FAILURE;


--
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php