Re[2]: [PHP-CVS] cvs: php-src(PHP_4_3) /ext/mnogosearch php_mnogo.c
Hi! MB This looks like new features in a bugfix release. This is compilation fixes if using with mnogosearch-3.2.16-CVS. We discussed about such mnogosearch module changes this July, and decided to permit such changes since they are cound not make harm while maintaining backwards compatilbility. -- Regards, Sergey aka gluke. -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php
Re[2]: [PHP-CVS] cvs: php-src(PHP_4_3) /ext/mnogosearch php_mnogo.c
Hi! + REGISTER_LONG_CONSTANT(UDM_PARAM_RESULTS_LIMIT,UDM_PARAM_RESULTS_LIMIT,CONST_CS | CONST_PERSISTENT); JT Shouldn't that be wrapped inside the #if UDM_VERSION_ID = 30215 .. #endif too?? I think this is not nesessary, since constant declarations are local to extension and there is no harm if it is declared for earlier versions. JT Also, wouldn't it be much easier for you to put this extension into PECL? JT You could release new versions more often.. I thought abount that, but i still sure that putting extensions into php is much better for end-users (there no additional packages to worry about to find required extension). Possibly the best way is to duplicate extension in PECL and php both giving the users possibility to stay on the cutting edge with the favourite extension. This is only my opinion of course. -- Regards, Sergey aka gluke. -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php
Re[2]: [PHP-CVS] cvs: php-src(PHP_4_3) /ext/mnogosearch php_mnogo.c
On Mon, 1 Sep 2003, Sergey Kartashoff wrote: + REGISTER_LONG_CONSTANT(UDM_PARAM_RESULTS_LIMIT,UDM_PARAM_RESULTS_LIMIT,CONST_CS | CONST_PERSISTENT); Shouldn't that be wrapped inside the #if UDM_VERSION_ID = 30215 .. #endif too?? I think this is not nesessary, since constant declarations are local to extension and there is no harm if it is declared for earlier versions. But is that constant _defined_ in earlier versions??? (speaking of UDM_PARAM_RESULTS_LIMIT, in the C side) --Jani -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php
