Hi all,

I've recently got a FastCGI implementation of PHP up and running, and
I'd like to submit it to be included in PHP. However, I'm no expert on
the PHP build system, and I'd like to be sure that what I'm about to
submit isn't hideously wrong!

Mostly, the new sapi is fine, it lives inside sapi/fastcgi. However, it
needs to pull in a static library from the FastCGI development kit
(downloadable from http://www.fastcgi.com, nice-looking license).
To build a php executable with this library, I've had to modify
Makefile.in:

 PROGRAM_NAME         = php
 PROGRAM_SOURCES      = stub.c
-PROGRAM_LDADD        = libphp4.la
+PROGRAM_LDADD        = libphp4.la $(EXT_PROGRAM_LDADD)
 PROGRAM_LDFLAGS      = -export-dynamic
 PROGRAM_DEPENDENCIES = $(PROGRAM_LDADD)

My sapi/fastcgi/config.m4 then sets this new variable with:
EXT_PROGRAM_LDADD="$EXT_PROGRAM_LDADD $FASTCGIPATH/lib/libfcgi.a"

Configure.in also has to be modified, with the additional lines:

if test "$PHP_SAPI" = "fastcgi"; then
  PHP_PROGRAM=php
fi


My question is: Is this the best way to do it? Is there a better way to
pull in non-libtool static files into the build? It seems a simple
changes, but I'm hesitant to modify Makefile.in if I don't have to.

Ideally, the CGI devkit would be integrated into the PHP sourcetree. I
think the license would permit this, though I'm no expert on this kind
of thing. Could anyone advise?


Cheers,
Ben



-- 
Ben Mansell, <[EMAIL PROTECTED]>                       Zeus Technology Ltd
Download the world's fastest webserver!   Universally Serving the Net
T:+44(0)1223 525000 F:+44(0)1223 525100           http://www.zeus.com
Zeus House, Cowley Road, Cambridge, CB4 0ZT, ENGLAND



-- 
PHP Development Mailing List <http://www.php.net/>
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
To contact the list administrators, e-mail: [EMAIL PROTECTED]

Reply via email to